From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8AD49A0503; Wed, 18 May 2022 17:24:37 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 32EF640156; Wed, 18 May 2022 17:24:37 +0200 (CEST) Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) by mails.dpdk.org (Postfix) with ESMTP id 2CBBA400D6 for ; Wed, 18 May 2022 17:24:36 +0200 (CEST) Received: by mail-pg1-f176.google.com with SMTP id g184so2467978pgc.1 for ; Wed, 18 May 2022 08:24:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ln5X4YFeEF75mTONrkNOzNurNu+p20DSVmBP25gjRH4=; b=pn8gbWAD7FImOScrPM/YfDAFkdcxKKle2tnd717FhgMMdfFnHyBrKNQ1Jy9i1FdF3l euSfNUbW3JvFoDFbAmXXJbVTKzfdNsmbRBb9MJgOIdLdkHKOdZASlST68/B+jrGFZujp 3sZUrYLLNDvoOztAT+yP9Mfwu+TekWV+sPBpYYl8kM3mOG0skTBqiu1p7OBSKqQi7jyY I4357lqRmGmKQPnzJH6xwM8qTylqXbGsqy1bO5Ja7RVYDhgKt98Fb235LNz5xPVyU+NH 2rLD9ubbfqsdWafPfv7KOrOEgHKI5b6uk8l8PYWnLr1k+s6KeEM0oTdq3O89C+YmZSXA Puzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ln5X4YFeEF75mTONrkNOzNurNu+p20DSVmBP25gjRH4=; b=lNcMkcszmI3YYq3MLCEjkc56qaIbYDmWRTzZvT/V1bo6ACowJI/bKc8bS7r+RRgC/8 nep68ZlsSFQSikMkkLYKYwBCpV/Mjn7uUI6ZtNSfcpr+kBDTnprGyUCrCRfiLTXQum1h GBdhjQ6QlqqFwOP8pGH/SrPNjy8v1xNRTNNU2eUxV/Vnw8VVWKbx9VlruIV9455HkG1p gFXlIFwsheHihwv3i6hW+8XKrS3FMliM7Mp6QbEJlCXRJx6B1jhPDe71gRcte55WDyQT rc07GO/u9mcDsjdYaLK2B9fh7I1hBMxYatrugVy6ojPT8PHHqUvEfjvFL7UGtU/TYN0O JOSQ== X-Gm-Message-State: AOAM532CcDVj0MiFf/hv5YZf/IuEVPGz6c9aJv6pfKYJoCit43urIyvC 8pMPLxnnlTwFGZDeMa6RA0X8HA== X-Google-Smtp-Source: ABdhPJykxTEORmAAA+jVBouo9giErvDowNtqbMPA9jHmUuZHmMCbbEPtC7kZE7w35WDB+v2X0jc0GA== X-Received: by 2002:a65:4c0c:0:b0:3c1:5bb1:6701 with SMTP id u12-20020a654c0c000000b003c15bb16701mr47875pgq.136.1652887475288; Wed, 18 May 2022 08:24:35 -0700 (PDT) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id j9-20020aa78009000000b00510952c52e3sm1987856pfi.180.2022.05.18.08.24.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 May 2022 08:24:34 -0700 (PDT) Date: Wed, 18 May 2022 08:24:32 -0700 From: Stephen Hemminger To: Steve Yang Cc: dev@dpdk.org, yuying.zhang@intel.com, qi.z.zhang@intel.com Subject: Re: [PATCH v3] app/testpmd: support ddp dump command for ice Message-ID: <20220518082432.4072557b@hermes.local> In-Reply-To: <20220518065806.1005694-1-stevex.yang@intel.com> References: <20220512020618.474816-1-stevex.yang@intel.com> <20220518065806.1005694-1-stevex.yang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 18 May 2022 06:58:06 +0000 Steve Yang wrote: > +#define ICE_BUFF_SIZE 0x000c9000 Having magic size hard coded in testpmd is bad idea. If there is driver specific size it should be exposed by API > + size = ICE_BUFF_SIZE; > + buff = (uint8_t *)malloc(ICE_BUFF_SIZE); Cast of void * is not necessary in C (only C++)