From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 20E61A0503; Wed, 18 May 2022 11:42:50 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C549E40156; Wed, 18 May 2022 11:42:49 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2072.outbound.protection.outlook.com [40.107.236.72]) by mails.dpdk.org (Postfix) with ESMTP id 36CE3400D6; Wed, 18 May 2022 11:42:48 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bMpNrU2nepoOghUi3ybN65RNIiRYPI5SLy3C8ZFbIP6GThTpemFxbpUfK0hx1BiEMfSaVcFXg03TnH5IJYkDbaCCEqNRumohGGn2Kf8Uh+sUhlKnDav3so+MO6D8uruT7uiLf9fQX7okamPb9a0A2jHLuNhCL7mhsrlcM/oqrzwSNOR2AMnEvWwZ/rk6Rde407RWt9FA76saLezCCi9z6UxDGUQuGrpnaxII/jOB4i3aVbyY77uqYWSsUgwItuxuVhUIc2WuO+/N8BYshs5r/Lu1vKVWyJ9hizN9PJftpSgpv6rGNmtvZWV5qkXJt0j98qcyTUnfdoC8h348rpJngg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zV2NXqb7tZZJYAEm5U61gWN/MeWAb3pqL/3kH9gN4Ls=; b=O2L2Dtsvu+ewZ9GhtVO7ibNBqCADXDy0espCRCRzfDjzYJej0L+igRtMNjRwO18DaN9TmqwEQuuiaj9ANah0rzwv/9MKGshWXspLh7ct6CZjtGLyWsYgT4SsCIDFhOiuMtF7jMQSVBY6aQQJ5JfFSqXY03bGE64DFnKAy52qVTGB+XwQqsveB28O79lQ15XeYfVGdMIYihlz0zphjGTNb4Wq5097La4XpBZUSCjn3ywWQL+5bj5PoJ/rvF/FCx3BcPiaPhcTO1QsQyR5snQKypNtk7UKhdTNiE+dZNjGaDm8M0w8lbnweeyAi6RSxZVNeC3NfuBGs35NyNVVdqAZqw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 12.22.5.238) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zV2NXqb7tZZJYAEm5U61gWN/MeWAb3pqL/3kH9gN4Ls=; b=AQ0itYkXYoSnlNPDp9DfSE52gr1Q+LNwzPxy0JiAlgCSqsPXt+aNnlynuZ22XWjAVI9Nviurqebf4m9sje/73E4rS4sr5veCd7YqfNQUpeWMcRnQkpgVQKJ0cWX0GciPnYYB8aNnjCfcB7Z+O4/vMxLX0Rj71eNOqaSejbVxFfk+mQPE2jx1yMk58rq6TwQRWQJ0d7SWJw1hcYSy3h3vFit+IS7RUtCer82eodaaMUOfOTZTjCE3bHugwFEgmUvIfWqT7QZ0pkPPqulCIgv8sH9QMpxWmexQ22mE9bpo1ivlL2hety42uZJCcquPzohtY4xXOKg6fb+bWxQRKcf2Cg== Received: from BN0PR04CA0100.namprd04.prod.outlook.com (2603:10b6:408:ec::15) by MN2PR12MB3519.namprd12.prod.outlook.com (2603:10b6:208:107::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.18; Wed, 18 May 2022 09:42:46 +0000 Received: from BN8NAM11FT022.eop-nam11.prod.protection.outlook.com (2603:10b6:408:ec:cafe::a3) by BN0PR04CA0100.outlook.office365.com (2603:10b6:408:ec::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.13 via Frontend Transport; Wed, 18 May 2022 09:42:46 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 12.22.5.238) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 12.22.5.238 as permitted sender) receiver=protection.outlook.com; client-ip=12.22.5.238; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (12.22.5.238) by BN8NAM11FT022.mail.protection.outlook.com (10.13.176.112) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.5273.14 via Frontend Transport; Wed, 18 May 2022 09:42:46 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by DRHQMAIL105.nvidia.com (10.27.9.14) with Microsoft SMTP Server (TLS) id 15.0.1497.32; Wed, 18 May 2022 09:42:45 +0000 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Wed, 18 May 2022 02:42:44 -0700 From: Raja Zidane To: CC: , , Dmitry Kozlyuk Subject: [PATCH] net/mlx5: fix Tx recovery Date: Wed, 18 May 2022 12:42:32 +0300 Message-ID: <20220518094232.24197-1-rzidane@nvidia.com> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1dc1e1de-30a1-4a04-0235-08da38b2c3d9 X-MS-TrafficTypeDiagnostic: MN2PR12MB3519:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2nl0CkWM3vOYI+QN2H17wy+YSJJD+qStKcdyD+X7xdu+7NmA5v6ur7nlT5tMqI/TmReOUhblGaEN2GTdf1kony8/0GJLSLWusv6N21QSspFJo2ooCy4Mndpx0/SOZ7ApOLZ0eT3/ABYDqLM97DcMUuXR33J6AQGk9F+ly4EcvkIn81llDoyw/0OuzZpy/OsBsmZfWjYDOqSahsoVuEnn2ZIg+vI6FJmz7xbLZl+6ZUGih9BlGRKLTlRF5qWHr7pw7xRC+RZHA/gXNO0twvX6TNx4ZxfkZ2PTosNd0yLBWp1uoJ/aasz0udaW41GkisS0Jekk32xqCgOOWYyOh/V+JOYTjc0wEdRya1bZXILsIR4CG3PwwrrzKwhy9m+nBVP6J2rcDI6TddECSenOLax0UoJ/mUQCSTUnfMBeemtVGxbDfE++P9Uedhtu0/9yOjv2bZir73MG1xHhPUonYP2B7IcMINLEx2LyUJSf7CIyVHtBDO5hcxCxwZgYr/JGk0AMhUqnFOI8dSZYtOzkOWqWt58M/nYHYUdi3SAGkhhIvgF08RoHB23SAt3ttsdA1R+wptmQs3m9iqeh1i4/aDLA1EpoBflASc+c9Efro4Ak8F+Q7JP6Tep1v+uLtIUWhoRgE1mhMYRtsrqnaCMFh/zkzSAgCac6rj/+Wb2QbEbfHa7O1dm8t8JwZR3nanow7Qzb/rk3hC53p5is5ImUPiByAQ== X-Forefront-Antispam-Report: CIP:12.22.5.238; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:InfoNoRecords; CAT:NONE; SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(2906002)(16526019)(186003)(107886003)(4326008)(1076003)(40460700003)(8676002)(70206006)(70586007)(5660300002)(36860700001)(6286002)(55016003)(86362001)(8936002)(82310400005)(508600001)(83380400001)(81166007)(7696005)(54906003)(6916009)(6666004)(36756003)(2616005)(356005)(316002)(47076005)(336012)(450100002)(426003)(26005)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2022 09:42:46.5584 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1dc1e1de-30a1-4a04-0235-08da38b2c3d9 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[12.22.5.238]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT022.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB3519 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org When an error occurs in Tx, and it is moved to ERROR state, it is not recoverable, during recovery it's state cannot be modified to INIT. to modify state from RESET to INIT, the port must be passed in modify attributes, and in case of ERROR to READY modification path, it was not provided. Provide port number when changing state from RESET to INIT. Fixes: 3a87b964edd3 ("net/mlx5: create Tx queues with DevX") Cc: stable@dpdk.org Signed-off-by: Raja Zidane Acked-by: Matan Azrad Acked-by: Dmitry Kozlyuk --- drivers/net/mlx5/linux/mlx5_verbs.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/mlx5/linux/mlx5_verbs.c b/drivers/net/mlx5/linux/mlx5_verbs.c index b6ba21c216..67a7bec22b 100644 --- a/drivers/net/mlx5/linux/mlx5_verbs.c +++ b/drivers/net/mlx5/linux/mlx5_verbs.c @@ -94,7 +94,6 @@ mlx5_ibv_modify_qp(struct mlx5_txq_obj *obj, enum mlx5_txq_modify_type type, .qp_state = IBV_QPS_RESET, .port_num = dev_port, }; - int attr_mask = (IBV_QP_STATE | IBV_QP_PORT); int ret; if (type != MLX5_TXQ_MOD_RST2RDY) { @@ -108,10 +107,8 @@ mlx5_ibv_modify_qp(struct mlx5_txq_obj *obj, enum mlx5_txq_modify_type type, if (type == MLX5_TXQ_MOD_RDY2RST) return 0; } - if (type == MLX5_TXQ_MOD_ERR2RDY) - attr_mask = IBV_QP_STATE; mod.qp_state = IBV_QPS_INIT; - ret = mlx5_glue->modify_qp(obj->qp, &mod, attr_mask); + ret = mlx5_glue->modify_qp(obj->qp, &mod, IBV_QP_STATE | IBV_QP_PORT); if (ret) { DRV_LOG(ERR, "Cannot change Tx QP state to INIT %s", strerror(errno)); -- 2.21.0