DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH 0/3] ixgbe: Fix SFP hotplug detection/removal
@ 2022-05-19 17:43 Jeff Daly
  2022-05-19 17:43 ` [PATCH 1/3] ixgbe: make link update thread periodic Jeff Daly
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Jeff Daly @ 2022-05-19 17:43 UTC (permalink / raw)
  To: dev; +Cc: stable

Currently the ixgbe driver does not ID any SFP except for the first one
plugged in. This can lead to no-link, or incorrect speed conditions.

For example:

* If link is initially established with a 1G SFP, and later a 1G/10G
multispeed part is later installed, then the MAC link setup functions are
never called to change from 1000BASE-X to 10GBASE-R mode, and the link
stays running at the slower rate.

* If link is initially established with a 1G SFP, and later a 10G only
module is later installed, no link is established, since we are still
trasnsmitting in 1000BASE-X mode to a 10GBASE-R only partner.

Refactor the SFP ID/setup, and link setup code, to more closely match the
flow of the mainline kernel driver which does not have these issues.  In
that driver a service task runs periodically to handle these operations
based on bit flags that have been set (usually via interrupt or userspace
request), and then get cleared once the requested subtask has been
completed.

Fixes: af75078fece ("first public release")
Cc: stable@dpdk.org



^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH 0/3] ixgbe: Fix SFP hotplug detection
@ 2022-05-19 18:02 Jeff Daly
  2022-05-19 18:02 ` [PATCH 3/3] ixgbe: make hotplug detection aware of changed SFPs Jeff Daly
  0 siblings, 1 reply; 6+ messages in thread
From: Jeff Daly @ 2022-05-19 18:02 UTC (permalink / raw)
  To: dev; +Cc: stable

Currently the ixgbe driver does not ID any SFP except for the first one
plugged in. This can lead to no-link, or incorrect speed conditions.

For example:

* If link is initially established with a 1G SFP, and later a 1G/10G
multispeed part is later installed, then the MAC link setup functions are
never called to change from 1000BASE-X to 10GBASE-R mode, and the link
stays running at the slower rate.

* If link is initially established with a 1G SFP, and later a 10G only
module is later installed, no link is established, since we are still
trasnsmitting in 1000BASE-X mode to a 10GBASE-R only partner.

Refactor the SFP ID/setup, and link setup code, to more closely match the
flow of the mainline kernel driver which does not have these issues.  In
that driver a service task runs periodically to handle these operations
based on bit flags that have been set (usually via interrupt or userspace
request), and then get cleared once the requested subtask has been
completed.

Fixes: af75078fece ("first public release")
Cc: stable@dpdk.org



^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH 0/3] ixgbe: fix SFP hotplug detection
@ 2022-05-19 19:25 Jeff Daly
  2022-05-19 19:25 ` [PATCH 3/3] ixgbe: make hotplug detection aware of changed SFPs Jeff Daly
  0 siblings, 1 reply; 6+ messages in thread
From: Jeff Daly @ 2022-05-19 19:25 UTC (permalink / raw)
  To: dev; +Cc: stable

Currently the ixgbe driver does not ID any SFP except for the first one
plugged in. This can lead to no-link, or incorrect speed conditions.

For example:

* If link is initially established with a 1G SFP, and later a 1G/10G
multispeed part is later installed, then the MAC link setup functions are
never called to change from 1000BASE-X to 10GBASE-R mode, and the link
stays running at the slower rate.

* If link is initially established with a 1G SFP, and later a 10G only
module is later installed, no link is established, since we are still
trasnsmitting in 1000BASE-X mode to a 10GBASE-R only partner.

Refactor the SFP ID/setup, and link setup code, to more closely match the
flow of the mainline kernel driver which does not have these issues.  In
that driver a service task runs periodically to handle these operations
based on bit flags that have been set (usually via interrupt or userspace
request), and then get cleared once the requested subtask has been
completed.

Fixes: af75078fece ("first public release")
Cc: stable@dpdk.org

Jeff Daly (3):
  ixgbe: make link update thread periodic
  ixgbe: move periodic link service work into separate function
  ixgbe: make hotplug detection aware of changed SFPs

 drivers/net/ixgbe/base/ixgbe_common.c |   4 +-
 drivers/net/ixgbe/ixgbe_ethdev.c      | 471 ++++++++++++++++++++------
 drivers/net/ixgbe/ixgbe_ethdev.h      |   9 +
 3 files changed, 374 insertions(+), 110 deletions(-)

-- 
2.25.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2022-05-19 19:25 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-19 17:43 [PATCH 0/3] ixgbe: Fix SFP hotplug detection/removal Jeff Daly
2022-05-19 17:43 ` [PATCH 1/3] ixgbe: make link update thread periodic Jeff Daly
2022-05-19 17:43 ` [PATCH 2/3] ixgbe: move periodic link service work into separate function Jeff Daly
2022-05-19 17:43 ` [PATCH 3/3] ixgbe: make hotplug detection aware of changed SFPs Jeff Daly
2022-05-19 18:02 [PATCH 0/3] ixgbe: Fix SFP hotplug detection Jeff Daly
2022-05-19 18:02 ` [PATCH 3/3] ixgbe: make hotplug detection aware of changed SFPs Jeff Daly
2022-05-19 19:25 [PATCH 0/3] ixgbe: fix SFP hotplug detection Jeff Daly
2022-05-19 19:25 ` [PATCH 3/3] ixgbe: make hotplug detection aware of changed SFPs Jeff Daly

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).