From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BBCDFA0503; Thu, 19 May 2022 23:38:14 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 74B3D42B78; Thu, 19 May 2022 23:38:01 +0200 (CEST) Received: from mail-qk1-f180.google.com (mail-qk1-f180.google.com [209.85.222.180]) by mails.dpdk.org (Postfix) with ESMTP id B84294281F for ; Thu, 19 May 2022 23:37:58 +0200 (CEST) Received: by mail-qk1-f180.google.com with SMTP id a22so5724698qkl.5 for ; Thu, 19 May 2022 14:37:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=atomicrules-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/aJTnDZAY4+IPBAwQbrCOBzdOumcpw82eW4HTnwLw+4=; b=sCGEyJGnGX8Dy1pchXMizXBBrs2tsz3kcgl0XEKhLcyutZE9A+FAWTPyA9ivY2fR3f niWNwx4nnzaSMvoMYh11k9GfoeRXA9soQVrzN9pfUnKAX98svJqT8xI8VIfdc8/2bACb Rtx5uM/FGVhOu+YLuQzV+MidBicl3hDRKWr1cFbsFDnmEDfiyxfibp4ieft2iGAlvqfc eSDyl3VMc+7s5ezd+ZYZVycmorl5i8DZCcSVKLa9FuKpATDFHKRgCFo+WVJa96D4hDXb j3jhEAQP5vwtpLPfEsDI7RkUiZGpffu2WepvCckHmGP3GBLEhcCjrYF1F8KzZ+PN2Vv2 6iVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/aJTnDZAY4+IPBAwQbrCOBzdOumcpw82eW4HTnwLw+4=; b=pRVigKGmbYQ2lDJd/2Ibe0jDJHETx3amYKO1oQXVYCY6OUPvSYnJD8PVZ4PWkJ+QoK 7GBs0yHrtyRkhrrGhXrkeY0lWotkiDKLKcrxANl8V8YKwXRs8IFa1wEy2nnslZZESd5X q6pRlGeK+BWq9/KpqyermbD3qccwgGAYrrLqLoKzozgE1SNLtIsl4e9Tj5zYDMx3ZohR 6d0BJ+AmWmoVP5cBlthDZVuacUAmMlguxno1D9C+rxXTwgeYYVoPZWE2IAaMXjc1vDyl jQJfForIDlCw8ZLcshDYkbfiy0VIN+WSmldIYgwBam8FzslIDTOdt8AWuZSRUuAVuTY7 7YZw== X-Gm-Message-State: AOAM530VTjSJUd9UGLcCQoopJcdhWCE8adFLhpGBifi0kHaj86WGB3uC AWynnbEf6Mu4EWSFfB6jld6/wXaEqmfGBXKZ X-Google-Smtp-Source: ABdhPJwtC+ogQcRMSG5Av40GWDm0ARa87msH5PefAwq3P8GkHs6blqC149ZHm12w/LdUMvCe0FXzCg== X-Received: by 2002:a05:620a:4489:b0:6a0:4614:6a09 with SMTP id x9-20020a05620a448900b006a046146a09mr4503335qkp.119.1652996278071; Thu, 19 May 2022 14:37:58 -0700 (PDT) Received: from z390.czeck.local (pool-173-48-102-189.bstnma.fios.verizon.net. [173.48.102.189]) by smtp.gmail.com with ESMTPSA id ca22-20020a05622a1f1600b002f39b99f6bcsm1889607qtb.86.2022.05.19.14.37.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 May 2022 14:37:57 -0700 (PDT) From: Ed Czeck To: dev@dpdk.org Cc: ferruh.yigit@xilinx.com, ktraynor@redhat.com, bluca@debian.org, Shepard Siegel , John Miller Subject: [PATCH v2 5/7] net/ark: report additional errors from firmware Date: Thu, 19 May 2022 17:36:40 -0400 Message-Id: <20220519213642.2647946-5-ed.czeck@atomicrules.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220519213642.2647946-1-ed.czeck@atomicrules.com> References: <20220502212232.1283-1-ed.czeck@atomicrules.com> <20220519213642.2647946-1-ed.czeck@atomicrules.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org detect and report completion errors from firmware Signed-off-by: Ed Czeck --- drivers/net/ark/ark_rqp.c | 6 ++++-- drivers/net/ark/ark_rqp.h | 3 ++- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/net/ark/ark_rqp.c b/drivers/net/ark/ark_rqp.c index ef9ccd0706..efb9730fe6 100644 --- a/drivers/net/ark/ark_rqp.c +++ b/drivers/net/ark/ark_rqp.c @@ -22,14 +22,16 @@ ark_rqp_stats_reset(struct ark_rqpace_t *rqp) void ark_rqp_dump(struct ark_rqpace_t *rqp) { - if (rqp->err_count_other != 0) + if (rqp->err_count_other || rqp->cmpl_errors) ARK_PMD_LOG(ERR, "RQP Errors noted: ctrl: %d cplh_hmax %d cpld_max %d" ARK_SU32 + ARK_SU32 ARK_SU32 "\n", rqp->ctrl, rqp->cplh_max, rqp->cpld_max, "Error Count", rqp->err_cnt, - "Error General", rqp->err_count_other); + "Error General", rqp->err_count_other, + "Cmpl Errors", rqp->cmpl_errors); ARK_PMD_LOG(INFO, "RQP Dump: ctrl: %d cplh_hmax %d cpld_max %d" ARK_SU32 diff --git a/drivers/net/ark/ark_rqp.h b/drivers/net/ark/ark_rqp.h index 6c8046062b..d09f242e1e 100644 --- a/drivers/net/ark/ark_rqp.h +++ b/drivers/net/ark/ark_rqp.h @@ -48,7 +48,8 @@ struct ark_rqpace_t { volatile uint32_t cpld_pending_max; volatile uint32_t err_count_other; char eval[4]; - volatile int lasped; + volatile int32_t lasped; + volatile uint32_t cmpl_errors; }; void ark_rqp_dump(struct ark_rqpace_t *rqp); -- 2.25.1