From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 618B6A0503; Fri, 20 May 2022 16:16:02 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3245C42B72; Fri, 20 May 2022 16:15:44 +0200 (CEST) Received: from mail-qt1-f177.google.com (mail-qt1-f177.google.com [209.85.160.177]) by mails.dpdk.org (Postfix) with ESMTP id 5057C40156 for ; Fri, 20 May 2022 16:15:41 +0200 (CEST) Received: by mail-qt1-f177.google.com with SMTP id 11so4723759qtp.9 for ; Fri, 20 May 2022 07:15:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=atomicrules-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/aJTnDZAY4+IPBAwQbrCOBzdOumcpw82eW4HTnwLw+4=; b=rlsl4FbUhyEmGxzEXPs4TlGIq4VA++o0QbfvDHuoPmC+75Wn4DFjuPnkWByReih5Hh 9y18YbForz51dYq3KnBltcoCVVRR2lTpGtQHuQvpUgXHCLvRnVK6I1Mb3zvJuyJi4k/a Sj+ZYEo3YH8/Zb2GMXxPPTptyIHae1D+5hGWNWpKskT5sO4m5LJGM7UVlzFGUz/Cla28 TrtUUUUOvqgFl7XRVQTWyufMRoxoDwA0u0cGTRmWC4GyEGav63NPTERjB/oN1wgLefNi kCBMl3qj5rP8rGEvbuVApguZcA+UAuOgq9y4/s8SDekGPW3taHc75OyWwz5hQDb+H95J gviw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/aJTnDZAY4+IPBAwQbrCOBzdOumcpw82eW4HTnwLw+4=; b=ygEIiAKhEJCqULNAw5Bo73baMBNO8BMQ7vdy/63T6kP1Sh9BdP2cWiPUe+64F5SkIJ Nk0gpUFSM7CHhGh6n84/Kyfz5eAxhPxiz4YuhgDs8fSEERhj2sgwhcgx71dhcUBiRoL7 57nnWddCICmpnPBGPrh/Ng01XnK5mZbz3Yq2tLGzWmKLkyqceyT9ApIfv2HpIpYPnt/8 KUNxmUSmvY6/mXtGKPmsM62eIgnn8XbRneRq5JTyaLSfWpavV2PX+Y8joM9ffY57be9B oShev+Xf3kcy+QCardm6hSA2h4U/OCZzP9NrDtYw2iKl2UHuSrRTppQSUCEZs1xdDmuS enGg== X-Gm-Message-State: AOAM5309dsdSKH0YuEAoo+1JZaS4w7vRu5zNMQ3sSlhm0YSVFaMqIXea gZsGQZZDz/Y5lWFyIVk0FB18pPftjxUVm1jf X-Google-Smtp-Source: ABdhPJw4l1pSjODhXMwb9hjIq8LevhbF8S8kX64aPVYcm24WWNexy8GycSZPdp7qdr77SeFG4TC+8A== X-Received: by 2002:a05:622a:40a:b0:2f3:f165:abab with SMTP id n10-20020a05622a040a00b002f3f165ababmr7831160qtx.642.1653056140418; Fri, 20 May 2022 07:15:40 -0700 (PDT) Received: from z390.czeck.local (pool-173-48-102-189.bstnma.fios.verizon.net. [173.48.102.189]) by smtp.gmail.com with ESMTPSA id n71-20020a37404a000000b0069fc13ce202sm3029655qka.51.2022.05.20.07.15.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 May 2022 07:15:39 -0700 (PDT) From: Ed Czeck To: dev@dpdk.org Cc: ferruh.yigit@xilinx.com, ktraynor@redhat.com, bluca@debian.org, Shepard Siegel , John Miller Subject: [PATCH v2 5/7] net/ark: report additional errors from firmware Date: Fri, 20 May 2022 10:15:10 -0400 Message-Id: <20220520141512.2713384-5-ed.czeck@atomicrules.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220520141512.2713384-1-ed.czeck@atomicrules.com> References: <20220502212232.1283-1-ed.czeck@atomicrules.com> <20220520141512.2713384-1-ed.czeck@atomicrules.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org detect and report completion errors from firmware Signed-off-by: Ed Czeck --- drivers/net/ark/ark_rqp.c | 6 ++++-- drivers/net/ark/ark_rqp.h | 3 ++- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/net/ark/ark_rqp.c b/drivers/net/ark/ark_rqp.c index ef9ccd0706..efb9730fe6 100644 --- a/drivers/net/ark/ark_rqp.c +++ b/drivers/net/ark/ark_rqp.c @@ -22,14 +22,16 @@ ark_rqp_stats_reset(struct ark_rqpace_t *rqp) void ark_rqp_dump(struct ark_rqpace_t *rqp) { - if (rqp->err_count_other != 0) + if (rqp->err_count_other || rqp->cmpl_errors) ARK_PMD_LOG(ERR, "RQP Errors noted: ctrl: %d cplh_hmax %d cpld_max %d" ARK_SU32 + ARK_SU32 ARK_SU32 "\n", rqp->ctrl, rqp->cplh_max, rqp->cpld_max, "Error Count", rqp->err_cnt, - "Error General", rqp->err_count_other); + "Error General", rqp->err_count_other, + "Cmpl Errors", rqp->cmpl_errors); ARK_PMD_LOG(INFO, "RQP Dump: ctrl: %d cplh_hmax %d cpld_max %d" ARK_SU32 diff --git a/drivers/net/ark/ark_rqp.h b/drivers/net/ark/ark_rqp.h index 6c8046062b..d09f242e1e 100644 --- a/drivers/net/ark/ark_rqp.h +++ b/drivers/net/ark/ark_rqp.h @@ -48,7 +48,8 @@ struct ark_rqpace_t { volatile uint32_t cpld_pending_max; volatile uint32_t err_count_other; char eval[4]; - volatile int lasped; + volatile int32_t lasped; + volatile uint32_t cmpl_errors; }; void ark_rqp_dump(struct ark_rqpace_t *rqp); -- 2.25.1