From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 08615A04FD; Mon, 23 May 2022 09:10:42 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AEBE84014F; Mon, 23 May 2022 09:10:41 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id A650040041 for ; Mon, 23 May 2022 09:10:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1653289839; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PKiMuiFbPaIViK9FIw4iS16gaZTNghgIkI7rZoiJ2vU=; b=VXwOMTn6cnjax2lVARmVbhCAW7JGZrlgzflJtToB7zA9pYi31be1z1VZmjedKNgPtuIpyK ZoDNmbYjSp6zO7/niN6gzy/Ot22+bxnC9gs6rAfV0Y9H2RQbvNwCh/mi4bQCxRqaCNPH7e PL+qNGiSOd2XZlkvjNXnwLXBFJ1wiLk= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-643-iaT7JvSKPr6lvG0IJ2vOEQ-1; Mon, 23 May 2022 03:10:37 -0400 X-MC-Unique: iaT7JvSKPr6lvG0IJ2vOEQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 516FB3810789; Mon, 23 May 2022 07:10:37 +0000 (UTC) Received: from fchome.home (unknown [10.40.192.68]) by smtp.corp.redhat.com (Postfix) with ESMTP id F30161410DD5; Mon, 23 May 2022 07:10:35 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: thomas@monjalon.net, andrew.rybchenko@oktetlabs.ru, ferruh.yigit@xilinx.com Subject: [PATCH 0/6] Split driver specific commands out of testpmd Date: Mon, 23 May 2022 09:10:25 +0200 Message-Id: <20220523071031.1868862-1-david.marchand@redhat.com> In-Reply-To: <20220513075718.18674-1-david.marchand@redhat.com> References: <20220513075718.18674-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david.marchand@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello, Following TB decision [1] and recent discussions on the driver specific commands in testpmd, here is a proposal on how the split could be done. For now, this series simply moves the testpmd code in the driver directory. The driver specific testpmd code is still compiled as part of testpmd compilation via a global meson testpmd_driver_sources list. Notes: - ixgbe bypass commands in testpmd were "dead" code since switch to meson, as the RTE_LIBRTE_IXGBE_BYPASS define is not set while compiling testpmd. No one complained about issue for the last two years, so those commands are dropped. 1: https://mails.dpdk.org/archives/dev/2022-April/239191.html -- David Marchand Changes since RFC v2: - extended cleanup patch 1, - fixed command registration (again..), - dropped ixgbe bypass commands, - fixed some indent, - updated documentation, Changes since RFC v1: - added a cleanup as patch 1, to make all parser symbols static, - fixed registering issue in patch 1, - moved more i40e specific commands, fixed checkpatch warnings, David Marchand (6): app/testpmd: mark most cmdline symbols as static app/testpmd: register driver specific commands net/bonding: move testpmd commands net/i40e: move testpmd commands app/testpmd: drop ixgbe bypass commands net/ixgbe: move testpmd commands app/test-pmd/bpf_cmd.c | 20 +- app/test-pmd/cmdline.c | 15404 ++++++---------- app/test-pmd/cmdline_flow.c | 8 +- app/test-pmd/cmdline_mtr.c | 219 +- app/test-pmd/cmdline_tm.c | 442 +- app/test-pmd/config.c | 43 - app/test-pmd/meson.build | 8 +- app/test-pmd/testpmd.c | 18 +- app/test-pmd/testpmd.h | 30 +- doc/guides/nics/i40e.rst | 184 +- doc/guides/nics/ixgbe.rst | 51 + .../link_bonding_poll_mode_drv_lib.rst | 143 + doc/guides/testpmd_app_ug/testpmd_funcs.rst | 433 +- drivers/meson.build | 5 + drivers/net/bonding/bonding_testpmd.c | 1029 ++ drivers/net/bonding/meson.build | 1 + drivers/net/i40e/i40e_testpmd.c | 2634 +++ drivers/net/i40e/meson.build | 2 + drivers/net/ixgbe/ixgbe_testpmd.c | 657 + drivers/net/ixgbe/meson.build | 2 + meson.build | 2 + 21 files changed, 10437 insertions(+), 10898 deletions(-) create mode 100644 drivers/net/bonding/bonding_testpmd.c create mode 100644 drivers/net/i40e/i40e_testpmd.c create mode 100644 drivers/net/ixgbe/ixgbe_testpmd.c -- 2.36.1