From: Pankaj Gupta <pagupta@vmware.com>
To: jbehrens@vmware.com
Cc: dev@dpdk.org, pagupta@vmware.com,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Subject: [PATCH v6 4/9] net/vmxnet3: fix ethdev callbacks init order
Date: Tue, 24 May 2022 17:40:23 -0700 [thread overview]
Message-ID: <20220525004028.24938-5-pagupta@vmware.com> (raw)
In-Reply-To: <20220525004028.24938-1-pagupta@vmware.com>
Driver callbacks initialization should follow callbacks order in the
structure definition.
Do not reorder callbacks implementation to avoid extra noise in
the code.
Signed-off-by: Pankaj Gupta <pagupta@vmware.com>
Signed-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
---
drivers/net/vmxnet3/vmxnet3_ethdev.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c
index cd32c1b4ee..e84d304378 100644
--- a/drivers/net/vmxnet3/vmxnet3_ethdev.c
+++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c
@@ -124,27 +124,27 @@ static const struct eth_dev_ops vmxnet3_eth_dev_ops = {
.dev_stop = vmxnet3_dev_stop,
.dev_close = vmxnet3_dev_close,
.dev_reset = vmxnet3_dev_reset,
+ .link_update = vmxnet3_dev_link_update,
.promiscuous_enable = vmxnet3_dev_promiscuous_enable,
.promiscuous_disable = vmxnet3_dev_promiscuous_disable,
.allmulticast_enable = vmxnet3_dev_allmulticast_enable,
.allmulticast_disable = vmxnet3_dev_allmulticast_disable,
- .link_update = vmxnet3_dev_link_update,
+ .mac_addr_set = vmxnet3_mac_addr_set,
+ .mtu_set = vmxnet3_dev_mtu_set,
.stats_get = vmxnet3_dev_stats_get,
- .xstats_get_names = vmxnet3_dev_xstats_get_names,
- .xstats_get = vmxnet3_dev_xstats_get,
.stats_reset = vmxnet3_dev_stats_reset,
- .mac_addr_set = vmxnet3_mac_addr_set,
+ .xstats_get = vmxnet3_dev_xstats_get,
+ .xstats_get_names = vmxnet3_dev_xstats_get_names,
.dev_infos_get = vmxnet3_dev_info_get,
.dev_supported_ptypes_get = vmxnet3_dev_supported_ptypes_get,
- .mtu_set = vmxnet3_dev_mtu_set,
.vlan_filter_set = vmxnet3_dev_vlan_filter_set,
.vlan_offload_set = vmxnet3_dev_vlan_offload_set,
.rx_queue_setup = vmxnet3_dev_rx_queue_setup,
.rx_queue_release = vmxnet3_dev_rx_queue_release,
- .tx_queue_setup = vmxnet3_dev_tx_queue_setup,
- .tx_queue_release = vmxnet3_dev_tx_queue_release,
.rx_queue_intr_enable = vmxnet3_dev_rx_queue_intr_enable,
.rx_queue_intr_disable = vmxnet3_dev_rx_queue_intr_disable,
+ .tx_queue_setup = vmxnet3_dev_tx_queue_setup,
+ .tx_queue_release = vmxnet3_dev_tx_queue_release,
.reta_update = vmxnet3_rss_reta_update,
.reta_query = vmxnet3_rss_reta_query,
};
--
2.17.1
next prev parent reply other threads:[~2022-05-25 0:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-25 0:40 [PATCH v6 0/9] net/vmxnet3: support versions 5 and 6 Pankaj Gupta
2022-05-25 0:40 ` [PATCH v6 1/9] net/vmxnet3: add version 5 support Pankaj Gupta
2022-05-25 0:40 ` [PATCH v6 2/9] net/vmxnet3: implement RETA query and RETA update Pankaj Gupta
2022-05-25 0:40 ` [PATCH v6 3/9] net/vmxnet3: add Rx queue usage count utility Pankaj Gupta
2022-05-25 0:40 ` Pankaj Gupta [this message]
2022-05-25 0:40 ` [PATCH v6 5/9] net/vmxnet3: report HW version on FW version get Pankaj Gupta
2022-05-25 0:40 ` [PATCH v6 6/9] net/vmxnet3: add version 6 support Pankaj Gupta
2022-05-25 8:45 ` Andrew Rybchenko
2022-05-25 17:13 ` Pankaj Gupta
2022-05-31 12:54 ` Andrew Rybchenko
2022-05-25 0:40 ` [PATCH v6 7/9] net/vmxnet3: advertise RETA size in device info Pankaj Gupta
2022-05-25 0:40 ` [PATCH v6 8/9] net/vmxnet3: set packet type for fragmented packet Pankaj Gupta
2022-05-25 0:40 ` [PATCH v6 9/9] net/vmxnet3: fix merge error in Rx data ring initialization Pankaj Gupta
2022-05-31 13:40 ` [PATCH v6 0/9] net/vmxnet3: support versions 5 and 6 Andrew Rybchenko
2022-05-31 13:41 ` Andrew Rybchenko
-- strict thread matches above, loose matches on Subject: below --
2022-05-03 4:22 [PATCH 0/8] vmxnet3 version V5 and V6 Pankaj Gupta
2022-05-19 8:04 ` [PATCH v6 0/9] net/vmxnet3: support versions 5 and 6 Andrew Rybchenko
2022-05-19 8:04 ` [PATCH v6 4/9] net/vmxnet3: fix ethdev callbacks init order Andrew Rybchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220525004028.24938-5-pagupta@vmware.com \
--to=pagupta@vmware.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=jbehrens@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).