From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BB92FA0545; Wed, 25 May 2022 02:41:03 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0B29942685; Wed, 25 May 2022 02:41:00 +0200 (CEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2046.outbound.protection.outlook.com [40.107.93.46]) by mails.dpdk.org (Postfix) with ESMTP id E8A66400D6 for ; Wed, 25 May 2022 02:40:52 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=doRJICRc4lG9FgjA1tCWS+ZA1mXpEe5UaigsLuaXZylpF52fgjfihzc5KSMRJU28Z95IL52Jfx/zbicktmPhgMYBaJ8KpKg5UqTx3rqMVgoYA8On5PqtWwYU3YYIlRtmzGrHo2FFgbA5b2wL5x8p931KsoERVGNOvOo6AEnb9TyFhCvbBflYDoCmu7Obuj9x1CscwfsOJKA0hZDb3VLKCz0oO5PNIq2jQImOStAQssNCLoetKHaOgmDHNasKwuM1J4og3H+VmOpNRPWc51QKwJCJZFva+dmVQxin1IlBVsf5zEezHZocjElapO/k7FeS+3xRT3QXJoYL3edXXJUIWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=g2kRpXLJN9uQc3gixa8sGQSHcdYNfeXHlbrjwGZpAso=; b=gxfbZ088ZgIahHoThvJNN88Uuo8Sw90GqDHQ/KjZwhicND2wgPmWLit4MAfYG9COtBDxy6uYAd1Sejfz0LOe4bUGlzkU88kKpPe31niam5rrP5DuTTUBZnetqu7l0NBAnPcRyLFtiAHnTn/T8DrXTKBqj4y/bjeQy9CMPYenV4yYnp50FSY61RjYDI4IaN7ETg0UzuFeYkvJ/e8yriLPK6D6ll4M4B/fshlR+sNkXmEmyKkfvD9AKq8XxW79l76PJjg7etYtHOJjFoKlhLUCRj5t+zKNSz88EdW2GzznWv7FccdKZWnT5PPr3LwoLo7LV1dCcnkHPr5cjWy9JhViaA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vmware.com; dmarc=pass action=none header.from=vmware.com; dkim=pass header.d=vmware.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vmware.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=g2kRpXLJN9uQc3gixa8sGQSHcdYNfeXHlbrjwGZpAso=; b=1byM7MYa41uzLZQh8uJR/N2abIAiPR8zFHdDvvFCRsyT2CdbdGzb0sfVMOCOpS4NJ1u85ySqcaEAtaJ+PwMaiauVwDaYHnx2dBucnwun29L+XmTZdzudUmytmObx0mVOkL+4teEtbyfbXwOk75zJrOjgwLcT6gv/gGabw0hjWlE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vmware.com; Received: from BYAPR05MB5624.namprd05.prod.outlook.com (2603:10b6:a03:1d::13) by MWHPR0501MB3753.namprd05.prod.outlook.com (2603:10b6:301:79::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Wed, 25 May 2022 00:40:50 +0000 Received: from BYAPR05MB5624.namprd05.prod.outlook.com ([fe80::49ad:2ac7:16c0:51c8]) by BYAPR05MB5624.namprd05.prod.outlook.com ([fe80::49ad:2ac7:16c0:51c8%6]) with mapi id 15.20.5293.013; Wed, 25 May 2022 00:40:49 +0000 From: Pankaj Gupta To: jbehrens@vmware.com Cc: dev@dpdk.org, pagupta@vmware.com, Andrew Rybchenko Subject: [PATCH v6 4/9] net/vmxnet3: fix ethdev callbacks init order Date: Tue, 24 May 2022 17:40:23 -0700 Message-Id: <20220525004028.24938-5-pagupta@vmware.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220525004028.24938-1-pagupta@vmware.com> References: <20220525004028.24938-1-pagupta@vmware.com> Content-Type: text/plain X-ClientProxiedBy: SJ0PR05CA0056.namprd05.prod.outlook.com (2603:10b6:a03:33f::31) To BYAPR05MB5624.namprd05.prod.outlook.com (2603:10b6:a03:1d::13) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cf2e692c-7438-478b-e9df-08da3de73673 X-MS-TrafficTypeDiagnostic: MWHPR0501MB3753:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DJ1oAQ8WuP68CsN6bYDzALUpmUuUvNPOM0NKLUOe7VgwTsajRQ7wkWj/MvTbQ+NfehcWOky/gJm5cD6OyFFrRRcLU65wAd0YcqpRzOEsfTAPmoBUiUeXckFs1OAe5EhFYZn8zgkfm60yQLwnANNn8FMWrPe2qNNeJ3w4ROrAcYP8loOFs3xsK5qCzpXS1UxG9F95hn96Zwbfs4BYkbpx5tUqfCOrIyRrtlfE9aFKsTL5enE7DuRIM20qaZa6kZqlGAUQOa0eCFsReg9y07+VmTBQypITfjEvSKK1/9GYtf1obS1ZfgonVvH8bonSNNfW41FcuTdEoJ+QfKpQY7jQOf9rExKslGsYcccFf8AcRvWxo9bvaCwrGQxF4qlY1ki25Yy516xya0dG0a8yQ5i21dHG7eiOgN9XWVUxmVdmy1vKA+dO+m4nAAvkN8SMaKfYyrdxVVW6GfHuvTZL981THOfeRhjPUNKEax19beloEUWikjAn1nPQxM5WzfgANCq8KwLfpWOvDhe+Uo1An+d22nCVonKPJ+d/30PvZYRJJTIAoavoD9qXoNm3RLgj4pI3jRaywQl0upQlnPFHcEuH0Y95wrSxW+6iaEp9n4IOWbHn7AvFEO4LUF/Jah0rtU1xDeOweI0tO3iAMla/KTLqKDbICr8FkLKf8/phHHMbT9GoOOCrPKZ3vesqqBB6qe4MqFejCsWGmr+itzWnmCplUA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR05MB5624.namprd05.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(186003)(52116002)(1076003)(2616005)(6666004)(8676002)(6506007)(316002)(66476007)(66556008)(66946007)(38100700002)(6512007)(34206002)(4326008)(508600001)(6486002)(6636002)(37006003)(36756003)(26005)(38350700002)(2906002)(5660300002)(83380400001)(86362001)(8936002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?HbycMsDPHfsHbwzFnzOA8Pt2aOpR6FMewHU3Z31ZL/rkKKHkdQ2Alv7z7Put?= =?us-ascii?Q?I4MLAhQ2xgJTRXvA9DUIGYBClN90SQXIxBMyotWdYmzJG4kEQ7OR2bn62VtN?= =?us-ascii?Q?ALKg4mnBKn6amOwu1uuEzzb75BQD3uK2AmnAbEdVAPpe1aA8Uo+HRuamn+ZB?= =?us-ascii?Q?LTZ6+n9YR7kjhGGwukPYPh1lhSY4Rn8f6PPNmGL/nnYs29GW9pkz6tWk+W/n?= =?us-ascii?Q?wWwlc4fwyiGngxUoDJcfCy26iXT6DogIiIcGSndG4pTeRLeY6eTGTogKzKEO?= =?us-ascii?Q?e6FP5c6n8s/TvNI/bvyzDBQOWR6FxcYjGLhdqZ6UnIL5mzKDsZ1hy/zNkfYl?= =?us-ascii?Q?ESNTVy/CJez+z4xYGDkHio7BSGlflIJqcaixJe4FpaCBvjpNLau0M9pWba0I?= =?us-ascii?Q?VAYCf0Dj1qx8JknLxxqNGT5mWEUXGLGsTQ5XyU2xiT9+f/VmHWxIjUBPz/6u?= =?us-ascii?Q?UAp7LAcAInl/aE2Iddyp6hU4t4idHhXgqEkRfnGKKV1m9Djj8rDIcpml3PvJ?= =?us-ascii?Q?OMKRPknl1QKCalf31TzW4VKDWXw+lcP24CNgI16Q1mxW75nP0k+zQMqQ+Unr?= =?us-ascii?Q?bI/2mw+28tLVIn3kd/oa6d4TzvlTZfgMBLP0Vcg5tzD1arA7WyWZlET1br+O?= =?us-ascii?Q?VN5eKiC2ivJ0NcA7EnZmkb7mcyTGv8P50VbEcGOoBQIXVDGdtZNiquqLl04+?= =?us-ascii?Q?liMRcnq0S6q7DYVPA3UzPcR1yd4SJJ8C4T6R+GAAJVDw/ofuCqDE5NO8Fm0+?= =?us-ascii?Q?CSm3ukU7d5oy57AVvz+PCfmZTGoowKR9jL4dh7VlxUpXKTneCUBkjPZQvFon?= =?us-ascii?Q?07B3F2DbKvBIJe5mTRp/tvr0ruAJAWEYroActUVpB7VAD/lM6981/QiXWjdh?= =?us-ascii?Q?eaw0huX5tfNerBPBy0fwd0lX+ZQ9iCOK496aqqmrASakShBdCk2SJTaPuREc?= =?us-ascii?Q?xXEj/dL1ny/TfqyFVzmcffz5pcXVHd6toR4M+2BN4P/WA4M/vX3zQ90niF6N?= =?us-ascii?Q?FootdIE5cUY0tBwL9TP1FxbqLNFzLOoSnVMi9sp5H144UO6qC5CWAkeGZQ+n?= =?us-ascii?Q?w62+ZuWLuveygOMCdqT6Z3tz5Rp/YHIf70SWxfLfOcMFnFC5gsbJkXn1u9MR?= =?us-ascii?Q?l13MPuoaHx7GLLQVsU+mXjHKCyFRBecIlrZ7AljrljD7OeY2CIO473Y6+IRY?= =?us-ascii?Q?BYhxJsdRJLw3S4F7+fpUG5ZRLNBqNXZEKmyiEt9RFNeDCUPxJtvomJ46BQdU?= =?us-ascii?Q?OxHYCEHVWyvi5+U9e6171SH7hUdsSZh6XwWDsQpMgR5LkvHJ0+JcZHpe0o5u?= =?us-ascii?Q?x88JdVJU+ZtETC3qYWkFTzUosYjUTTTNAwh1FdTYxCq+G9BC7hwcKHDBroH7?= =?us-ascii?Q?AJpjoURraMRYmK6uyojMjLFKbsgDL7dq8PjH7PpMjPYBp9M1SSKElR+yl0cX?= =?us-ascii?Q?8h2OyjZRAKW6Ji/ys2FyriAG7sxPM1XIbkSKsIsGWM38QZS38sMRloNNLTl4?= =?us-ascii?Q?C4ohSLuFBgwF9B9BLYzYHXKNfBEbBStHK62J/dxtbF7+Q3UFdLsyNFrEoapC?= =?us-ascii?Q?EGRupRhDEyc2BjFyRwqPdwEUxCankc2IvcNs8K7XbQEv0Sc9fh2gCz0PuYIC?= =?us-ascii?Q?dDRP4S3S0U3Wv2AIsXAp27kJhbFFgcDR22uaok1Pp5OhAEddRKF75rNedQ2/?= =?us-ascii?Q?2PLY9vZtjRvdg8X4BKgmGE+PnIh+WkAaNA5cb72O1aF5wP2Bq7lBuUP1MycS?= =?us-ascii?Q?Lm28u+fP2w=3D=3D?= X-OriginatorOrg: vmware.com X-MS-Exchange-CrossTenant-Network-Message-Id: cf2e692c-7438-478b-e9df-08da3de73673 X-MS-Exchange-CrossTenant-AuthSource: BYAPR05MB5624.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 May 2022 00:40:48.7589 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hoxzeILlKl0HabSr+AzrmvhMK3zofNhHXqrb0l1UBYGX9C7T6lfmWwB8y+9laqy+4CPMZVs1+LS/NPIH9UAehA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR0501MB3753 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Driver callbacks initialization should follow callbacks order in the structure definition. Do not reorder callbacks implementation to avoid extra noise in the code. Signed-off-by: Pankaj Gupta Signed-off-by: Andrew Rybchenko --- drivers/net/vmxnet3/vmxnet3_ethdev.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c index cd32c1b4ee..e84d304378 100644 --- a/drivers/net/vmxnet3/vmxnet3_ethdev.c +++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c @@ -124,27 +124,27 @@ static const struct eth_dev_ops vmxnet3_eth_dev_ops = { .dev_stop = vmxnet3_dev_stop, .dev_close = vmxnet3_dev_close, .dev_reset = vmxnet3_dev_reset, + .link_update = vmxnet3_dev_link_update, .promiscuous_enable = vmxnet3_dev_promiscuous_enable, .promiscuous_disable = vmxnet3_dev_promiscuous_disable, .allmulticast_enable = vmxnet3_dev_allmulticast_enable, .allmulticast_disable = vmxnet3_dev_allmulticast_disable, - .link_update = vmxnet3_dev_link_update, + .mac_addr_set = vmxnet3_mac_addr_set, + .mtu_set = vmxnet3_dev_mtu_set, .stats_get = vmxnet3_dev_stats_get, - .xstats_get_names = vmxnet3_dev_xstats_get_names, - .xstats_get = vmxnet3_dev_xstats_get, .stats_reset = vmxnet3_dev_stats_reset, - .mac_addr_set = vmxnet3_mac_addr_set, + .xstats_get = vmxnet3_dev_xstats_get, + .xstats_get_names = vmxnet3_dev_xstats_get_names, .dev_infos_get = vmxnet3_dev_info_get, .dev_supported_ptypes_get = vmxnet3_dev_supported_ptypes_get, - .mtu_set = vmxnet3_dev_mtu_set, .vlan_filter_set = vmxnet3_dev_vlan_filter_set, .vlan_offload_set = vmxnet3_dev_vlan_offload_set, .rx_queue_setup = vmxnet3_dev_rx_queue_setup, .rx_queue_release = vmxnet3_dev_rx_queue_release, - .tx_queue_setup = vmxnet3_dev_tx_queue_setup, - .tx_queue_release = vmxnet3_dev_tx_queue_release, .rx_queue_intr_enable = vmxnet3_dev_rx_queue_intr_enable, .rx_queue_intr_disable = vmxnet3_dev_rx_queue_intr_disable, + .tx_queue_setup = vmxnet3_dev_tx_queue_setup, + .tx_queue_release = vmxnet3_dev_tx_queue_release, .reta_update = vmxnet3_rss_reta_update, .reta_query = vmxnet3_rss_reta_query, }; -- 2.17.1