From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 11BD7A0544;
	Fri, 27 May 2022 17:36:09 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id E18DD410DC;
	Fri, 27 May 2022 17:36:08 +0200 (CEST)
Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com
 [209.85.210.179])
 by mails.dpdk.org (Postfix) with ESMTP id B31CF40E78
 for <dev@dpdk.org>; Fri, 27 May 2022 17:36:06 +0200 (CEST)
Received: by mail-pf1-f179.google.com with SMTP id y199so4614845pfb.9
 for <dev@dpdk.org>; Fri, 27 May 2022 08:36:06 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20210112.gappssmtp.com; s=20210112;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=AUx339OLJNnwyiXVs7m+KUlC5o8g5TXhvvrKQ2MinEY=;
 b=MIYXRqJzzk+f8kf2zUJVc673ISkOLf0xTCfWYpB4RMkQsxggAocYIvZN6nchQ8B2Q9
 BGhItA3c0U3PcaXg/6/n1gW7Ebm//WZpC9uKYeagEf8muONrvr8sVD20iuF7F19lF32M
 tpXN8QPTxg77ZADYb4JjD0wfzZQOWurzkrYWkJw0LsSmjKH6ayO+tZ8vn7QpToq0IjOm
 AEbWrW5ihdREmWP83n/0zvRcNyaBo5ssyKvR41kuCFgJBFDZJQBanP7mCwpTOfFn3eyq
 m7ez+7GGqyrKmTNuEQ9a14rLbpMUuH3SZDaFUmkecKFxqtfLPXG20tvsc33AtHqwfNOZ
 6WYw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=AUx339OLJNnwyiXVs7m+KUlC5o8g5TXhvvrKQ2MinEY=;
 b=rPe+EGun67LOrT7kf8jrGzp5oKZ7EYoGAU+e5U0xSVP0WtB2APBbDK9CSg42nRcVXU
 UsVkkG+pZW/A8xMC/5dkw6eh7liX9Fl0ONglkHJibcpEJdeWq3+Cf3Aw5wHKBgIb4x6J
 EFRaIGLcM8GfkfTEo0DmnxKssrvpC3uVnadj1wxNhf+UUGGmMbBfAJYJXiqEmLXnm8Vb
 /eJzm54NG2ldWSybrQmdgUPBj+L9L/LdtFQYP6Pqw3mbjuo0Msv4k5OkJzsgg095ynFa
 VH3iA3SPUXwsQDkH4Tiz1qXlDrP2ERTzqyL36HkpLPvJYl6muQ0yb+Z0l/CRsPP2/F4A
 UN6Q==
X-Gm-Message-State: AOAM5313z8BF9S4KUfkJ1+PvEw8eF5zAZZbPHb/NlH+rCpGu2MmsdWRN
 UY+vzOcUb7sXbksguvgsC33eNw==
X-Google-Smtp-Source: ABdhPJxhOe/JFJkUJYdixmAalC+5yr/+JfTb/BXi3CsJZ2yvaPgIFoh7gHLbqdRdQ0MXjf7RtpIhiQ==
X-Received: by 2002:a63:5:0:b0:3c6:dcb2:428 with SMTP id
 5-20020a630005000000b003c6dcb20428mr37728818pga.73.1653665765794; 
 Fri, 27 May 2022 08:36:05 -0700 (PDT)
Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199])
 by smtp.gmail.com with ESMTPSA id
 gt9-20020a17090af2c900b001cda0b69a30sm1756685pjb.52.2022.05.27.08.36.05
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 27 May 2022 08:36:05 -0700 (PDT)
Date: Fri, 27 May 2022 08:36:03 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: "Min Hu (Connor)" <humin29@huawei.com>
Cc: <dev@dpdk.org>, Yisen Zhuang <yisen.zhuang@huawei.com>, Lijun Ou
 <oulijun@huawei.com>
Subject: Re: [PATCH 3/4] net/hns3: support Rx/Tx bd dump
Message-ID: <20220527083603.367c5490@hermes.local>
In-Reply-To: <20220527023351.40577-4-humin29@huawei.com>
References: <20220527023351.40577-1-humin29@huawei.com>
 <20220527023351.40577-4-humin29@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Fri, 27 May 2022 10:33:50 +0800
"Min Hu (Connor)" <humin29@huawei.com> wrote:

> +	for (i = 0; i < HNS3_BD_DW_NUM; i++) {
> +		/*
> +		 * For the sake of security, first 8 bytes of BD which stands
> +		 * for physical address of packet should not be shown.
> +		 */
> +		if (i < HNS3_BD_ADDRESS_LAST_DW) {
> +			fprintf(file, "TX BD WORD[%d]:0x%08x\n", i, 0);
> +			continue;
> +		}
> +
> +		fprintf(file, "Tx BD WORD[%d]:0x%08x\n", i, *(bd_data + i));

Use hex dump that exists?
Also this is not the kernel so leaking physical address values is not a real
security concern.