DPDK patches and discussions
 help / color / mirror / Atom feed
From: Arek Kusztal <arkadiuszx.kusztal@intel.com>
To: dev@dpdk.org
Cc: gakhil@marvell.com, roy.fan.zhang@intel.com,
	Arek Kusztal <arkadiuszx.kusztal@intel.com>
Subject: [PATCH v4 09/12] cryptodev: clarify usage of rsa padding hash
Date: Tue, 31 May 2022 05:04:36 +0100	[thread overview]
Message-ID: <20220531040439.15862-10-arkadiuszx.kusztal@intel.com> (raw)
In-Reply-To: <20220531040439.15862-1-arkadiuszx.kusztal@intel.com>

- Clarified usage of RSA padding hash.
It was not specified how to use hash for PKCS1_5
padding. This could lead to incorrect implementation.

Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
---
 lib/cryptodev/rte_crypto_asym.h | 25 ++++++++++++++++++++++---
 1 file changed, 22 insertions(+), 3 deletions(-)

diff --git a/lib/cryptodev/rte_crypto_asym.h b/lib/cryptodev/rte_crypto_asym.h
index a215f4499d..363fbf87c7 100644
--- a/lib/cryptodev/rte_crypto_asym.h
+++ b/lib/cryptodev/rte_crypto_asym.h
@@ -395,10 +395,29 @@ struct rte_crypto_rsa_op_param {
 	/**< RSA padding scheme to be used for transform */
 
 	enum rte_crypto_auth_algorithm md;
-	/**< Hash algorithm to be used for data hash if padding
-	 * scheme is either OAEP or PSS. Valid hash algorithms
-	 * are:
+	/**<
+	 * RSA padding hash algorithm
+	 * Valid hash algorithms are:
 	 * MD5, SHA1, SHA224, SHA256, SHA384, SHA512
+	 *
+	 * When a specific padding type is selected, the following rule apply:
+	 * - RTE_CRYPTO_RSA_PADDING_NONE:
+	 * This field is ignored by the PMD
+	 *
+	 * - RTE_CRYPTO_RSA_PADDING_PKCS1_5:
+	 * For sign operation, this field is used to determine value
+	 * of the DigestInfo structure, therefore specifying which algorithm
+	 * was used to create the message digest.
+	 * For encryption/decryption, this field is ignored for this
+	 * padding type.
+	 *
+	 * - RTE_CRYPTO_RSA_PADDING_OAEP
+	 * This field shall be set with the hash algorithm used
+	 * in the padding scheme
+	 *
+	 * - RTE_CRYPTO_RSA_PADDING_PSS
+	 * This field shall be set with the hash algorithm used
+	 * in the padding scheme (and to create the input message digest)
 	 */
 
 	enum rte_crypto_auth_algorithm mgf1md;
-- 
2.13.6


  parent reply	other threads:[~2022-05-31  5:13 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-31  4:04 [PATCH v4 00/12] cryptodev: rsa, dh, ecdh changes Arek Kusztal
2022-05-31  4:04 ` [PATCH v4 01/12] cryptodev: redefine ec group enum Arek Kusztal
2022-05-31  7:32   ` Zhang, Roy Fan
2022-05-31 12:29   ` [EXT] " Akhil Goyal
2022-05-31  4:04 ` [PATCH v4 02/12] cryptodev: separate key exchange operation enum Arek Kusztal
2022-05-31  7:34   ` Zhang, Roy Fan
2022-05-31 11:47   ` [EXT] " Akhil Goyal
2022-05-31 13:50     ` Kusztal, ArkadiuszX
2022-05-31 14:08       ` Kusztal, ArkadiuszX
2022-05-31 14:34       ` Akhil Goyal
2022-05-31  4:04 ` [PATCH v4 03/12] cryptodev: remove comment about using ephemeral key in dsa Arek Kusztal
2022-05-31  7:35   ` Zhang, Roy Fan
2022-05-31  4:04 ` [PATCH v4 04/12] cryptodev: clarify usage of private key in dh Arek Kusztal
2022-05-31  7:35   ` Zhang, Roy Fan
2022-05-31  4:04 ` [PATCH v4 05/12] cryptodev: move dh type from xform to dh op Arek Kusztal
2022-05-31  7:36   ` Zhang, Roy Fan
2022-05-31  4:04 ` [PATCH v4 06/12] cryptodev: add elliptic curve diffie hellman Arek Kusztal
2022-05-31  7:36   ` Zhang, Roy Fan
2022-05-31  8:29   ` Ray Kinsella
2022-05-31  4:04 ` [PATCH v4 07/12] cryptodev: add public key verify option Arek Kusztal
2022-05-31  7:37   ` Zhang, Roy Fan
2022-05-31  4:04 ` [PATCH v4 08/12] cryptodev: add asym op flags Arek Kusztal
2022-05-31  7:37   ` Zhang, Roy Fan
2022-05-31 11:39   ` [EXT] " Akhil Goyal
2022-05-31  4:04 ` Arek Kusztal [this message]
2022-05-31  7:42   ` [PATCH v4 09/12] cryptodev: clarify usage of rsa padding hash Zhang, Roy Fan
2022-05-31  4:04 ` [PATCH v4 10/12] cryptodev: move RSA padding into separate struct Arek Kusztal
2022-05-31  7:46   ` Zhang, Roy Fan
2022-05-31  4:04 ` [PATCH v4 11/12] cryptodev: clarify rsa verify with none padding Arek Kusztal
2022-05-31  7:47   ` Zhang, Roy Fan
2022-05-31  4:04 ` [PATCH v4 12/12] cryptodev: add salt length and optional label Arek Kusztal
2022-05-31  7:48   ` Zhang, Roy Fan
2022-05-31  7:49 ` [PATCH v4 00/12] cryptodev: rsa, dh, ecdh changes Zhang, Roy Fan
2022-05-31 11:52 ` [EXT] " Akhil Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220531040439.15862-10-arkadiuszx.kusztal@intel.com \
    --to=arkadiuszx.kusztal@intel.com \
    --cc=dev@dpdk.org \
    --cc=gakhil@marvell.com \
    --cc=roy.fan.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).