From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0FECCA054F; Wed, 1 Jun 2022 08:41:16 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 45207410EA; Wed, 1 Jun 2022 08:41:12 +0200 (CEST) Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by mails.dpdk.org (Postfix) with ESMTP id 5AD9640694 for ; Wed, 1 Jun 2022 08:41:10 +0200 (CEST) Received: from kwepemi500012.china.huawei.com (unknown [172.30.72.55]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4LCfbY3Y4GzRhYl for ; Wed, 1 Jun 2022 14:38:01 +0800 (CST) Received: from localhost.localdomain (10.69.192.56) by kwepemi500012.china.huawei.com (7.221.188.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 1 Jun 2022 14:41:07 +0800 From: "Min Hu (Connor)" To: Subject: [PATCH v4 0/2] ethdev: fix MAC addrs list Date: Wed, 1 Jun 2022 14:39:47 +0800 Message-ID: <20220601063949.43202-1-humin29@huawei.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20220514020049.57294-1-humin29@huawei.com> References: <20220514020049.57294-1-humin29@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.69.192.56] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To kwepemi500012.china.huawei.com (7.221.188.12) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The index zero of rte_eth_dev_data::mac_addrs array is as the default MAC index, and other indexes can't be the same as the address corresponding to index 0. If we break it, may cause following problems: 1) waste of MAC address spaces. 2) a fake MAC address in the MAC list, isn't in hardware MAC entries. 3) a MAC address is assigned to diffent pool. Huisong Li (2): ethdev: fix one address occupies two indexes in MAC addrs ethdev: document default and non-default MAC address --- v4: - fix broken in the patchwork v3: - first explicitly remove the non-default MAC, then set default one. - document default and non-default MAC address v2: - fixed commit log. lib/ethdev/ethdev_driver.h | 7 ++++++- lib/ethdev/rte_ethdev.c | 39 ++++++++++++++++++++++++++++++++++++-- 2 files changed, 43 insertions(+), 3 deletions(-) -- 2.33.0