From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A1CA7A0548; Tue, 7 Jun 2022 22:34:36 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 44F4740689; Tue, 7 Jun 2022 22:34:36 +0200 (CEST) Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) by mails.dpdk.org (Postfix) with ESMTP id 2BA2E4021D for ; Tue, 7 Jun 2022 22:34:35 +0200 (CEST) Received: by mail-pg1-f169.google.com with SMTP id d129so16940864pgc.9 for ; Tue, 07 Jun 2022 13:34:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xnBFQegBDCE4XDgttO/FfC+1EoyK/POW8drZp7O/lH0=; b=2AJ01T6XY0Zqhe6wspV4qOLeaqp3RGqPAc8EvJ/D2A399b5jix0va/3LiuUi+3ZyYg 6/pfTWecPtfczCiNCNAafJLQfqoefzyZyETLJp3TE8Ao6rkaCLcF5yHr53ZGoJSiVxZ9 DfoaPez3i7hK5phVsUSPlkJxNgTyOHdVg+nRY3sEO1I91+ATVOKZ+GgetQHVUVkuaNu6 T5eaX0BJVpnN2Bcjm7ZvRDKqBsPH5jJrSq1bfRn776GSa0k7zFpUV9QId0kEetxDGuRq LvByUqsK24g+6g+VRN1Cb9LTxw0Ez/KZHbhYZjbQge+B3n46SKs2G69zSRK8HZCwicGT xnyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xnBFQegBDCE4XDgttO/FfC+1EoyK/POW8drZp7O/lH0=; b=YO2jn1XyF9WIPjBJIhtYn92IVEyrs4ECufWdih0do8qyK/0F3n5qQUyJJMvVJv8lCP /mfC2FJYsv8kXdUm3+iKqc1YMRtTEDl+MSitcV3KMWhlUQ3BuvWd5I+QB/Eb0R0vMMZo WNAZZwCfLoUMpsc6tncfOTaNhzLzhj+UOyMhlflRzX3FLh47XY1nqinKwZ86to9F1GYx eJy3h97G832I0qwiTubpPxi1ceEy0WHfXdX/EP4xj8eknjgwAM5GwFZ4Yld8mEBdWykP lSwKLuqNlQzmk6JlJ+hZx9087TpNZotJrvyWSF/lcf6ugvJakThUhDds2bm+BP8qm50U 0J/w== X-Gm-Message-State: AOAM53176rHU7pbPpVv85NmhJdtbAiNT4NZ7xJqL/zqZSHC02RYAUSS3 79xKBwN9rNs2atouTLb7dJGhxw== X-Google-Smtp-Source: ABdhPJysaL2JP+nLm+2jt17dKBOCxCPVbtxSYjveVFMELvK3B/rXfT8v4oL3bW16pb1EWaxIyXIv+w== X-Received: by 2002:a65:6713:0:b0:3fd:af26:a799 with SMTP id u19-20020a656713000000b003fdaf26a799mr11435728pgf.68.1654634074186; Tue, 07 Jun 2022 13:34:34 -0700 (PDT) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id p20-20020a170902a41400b00163f7935772sm12909938plq.46.2022.06.07.13.34.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jun 2022 13:34:33 -0700 (PDT) Date: Tue, 7 Jun 2022 13:34:30 -0700 From: Stephen Hemminger To: David Marchand Cc: dev@dpdk.org, Thomas Monjalon , Ruifeng Wang , Jan Viktorin , Honnappa Nagarahalli , Joyce Kong , David Christensen , Bruce Richardson , Konstantin Ananyev Subject: Re: [PATCH] eal: remove unused arch specific headers for locks Message-ID: <20220607133430.1737b4c4@hermes.local> In-Reply-To: <20220607190308.1926702-1-david.marchand@redhat.com> References: <20220607190308.1926702-1-david.marchand@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 7 Jun 2022 21:03:08 +0200 David Marchand wrote: > MCS lock, PF lock and Ticket lock have no arch specific implementation, > there is no need for the extra redirection in headers. > > Signed-off-by: David Marchand > --- > Note: this was mentionned during the seqlock patch review, and I spotted > it again, while reviewing the RISC-V port, and I see the same for a next > architecture too. So better clean this up as we don't need the > redirection. > > --- > MAINTAINERS | 4 ++-- > lib/eal/arm/include/meson.build | 3 --- > lib/eal/arm/include/rte_mcslock.h | 22 ------------------- > lib/eal/arm/include/rte_pflock.h | 18 --------------- > lib/eal/arm/include/rte_ticketlock.h | 22 ------------------- > lib/eal/include/meson.build | 6 ++--- > lib/eal/include/{generic => }/rte_mcslock.h | 8 +++++++ > lib/eal/include/{generic => }/rte_pflock.h | 0 > .../include/{generic => }/rte_ticketlock.h | 0 > lib/eal/ppc/include/meson.build | 3 --- > lib/eal/ppc/include/rte_mcslock.h | 18 --------------- > lib/eal/ppc/include/rte_pflock.h | 17 -------------- > lib/eal/ppc/include/rte_ticketlock.h | 18 --------------- > lib/eal/x86/include/meson.build | 3 --- > lib/eal/x86/include/rte_mcslock.h | 18 --------------- > lib/eal/x86/include/rte_pflock.h | 18 --------------- > lib/eal/x86/include/rte_ticketlock.h | 18 --------------- > 17 files changed, 13 insertions(+), 183 deletions(-) > delete mode 100644 lib/eal/arm/include/rte_mcslock.h > delete mode 100644 lib/eal/arm/include/rte_pflock.h > delete mode 100644 lib/eal/arm/include/rte_ticketlock.h > rename lib/eal/include/{generic => }/rte_mcslock.h (98%) > rename lib/eal/include/{generic => }/rte_pflock.h (100%) > rename lib/eal/include/{generic => }/rte_ticketlock.h (100%) > delete mode 100644 lib/eal/ppc/include/rte_mcslock.h > delete mode 100644 lib/eal/ppc/include/rte_pflock.h > delete mode 100644 lib/eal/ppc/include/rte_ticketlock.h > delete mode 100644 lib/eal/x86/include/rte_mcslock.h > delete mode 100644 lib/eal/x86/include/rte_pflock.h > delete mode 100644 lib/eal/x86/include/rte_ticketlock.h > Looks great will make future work easier. Acked-by: Stephen Hemminger