From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5D0EBA054D; Tue, 7 Jun 2022 17:49:58 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 67D5042905; Tue, 7 Jun 2022 17:49:41 +0200 (CEST) Received: from mail-qk1-f175.google.com (mail-qk1-f175.google.com [209.85.222.175]) by mails.dpdk.org (Postfix) with ESMTP id BA31B427F6 for ; Tue, 7 Jun 2022 17:49:39 +0200 (CEST) Received: by mail-qk1-f175.google.com with SMTP id d128so5658156qkg.8 for ; Tue, 07 Jun 2022 08:49:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=atomicrules-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/aJTnDZAY4+IPBAwQbrCOBzdOumcpw82eW4HTnwLw+4=; b=xq6nftaxmPjnjYUlwzFbLx+pkDqsmcCJtVAw1brU+5d0a4eC5tS7DXoXyRNhlg4KGj YcyILEEmdgyxqajUcS2Gpy7C30+GLeXFCG1eHX1Ine7puJe3E8CKOH6gSmacUh0oQCn2 eg/j7qm1BFysMYw2vA+IBoDs/XzyGlTqrUcNs34VpAaE7NiZQQf9s9Zwf9epKikK4E9I 1tShyJvt27AioSobb+PvGIrLkshDYy8i43EJucE2u0xdAM5Q3lT2XmCN8SphBGuXIFVF +Vs/GbqH4pbSKZnfPe8V/V7zQajnRLrHgQ1UJ+4nWmHES69uE8aVbiwiybm2844pN5a9 2TCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/aJTnDZAY4+IPBAwQbrCOBzdOumcpw82eW4HTnwLw+4=; b=jnud8fta463bMQtEnU6/gUscAkLWxtyMhNUlr2vkH/slEPghecJWSI11f7FTwSmBhY VpLJ337njggRnrWhNJ/8kEgeWdhaXL6Cgn8rf+qUyDGU6ASXnfEfh7Int89mIz55nuh/ goFtN95BZ3oOvyYLS2n0XmDLdHwUeXyIr8ARMlZQ6cvtDPkpcEeNK5V7ypIXl9DSKpPL nrxW6EDA0SrqFozVYxtYx5dC+qaDeLQXGlKTi4hVrtgXglcNe82PN72Yz9T7NOcxyHfM 6Dehd1LJkpjCdbPvidztRUgmXN84WWrmkhzGCrrfNgVfEW5HtGFRwR6oJ9+FJEgchH96 AmBQ== X-Gm-Message-State: AOAM5304BahUHsmtJQWosQ8mDigqIUkICNJNTEeC4H0+KbqJElUDcZsx qaINKLNKqlF9WjhRqiTjftOsTSDFTkBSrQ== X-Google-Smtp-Source: ABdhPJx0OUxeUeaSmt4W2QC8vu8SBaGQoVDPAcmqPOlol3GWOgdZZfvXcHyGrNQyNLJXgQaLbP27wQ== X-Received: by 2002:a05:620a:d94:b0:6a6:6c9c:c7ec with SMTP id q20-20020a05620a0d9400b006a66c9cc7ecmr20052298qkl.221.1654616978884; Tue, 07 Jun 2022 08:49:38 -0700 (PDT) Received: from z390.czeck.local (pool-173-48-102-189.bstnma.fios.verizon.net. [173.48.102.189]) by smtp.gmail.com with ESMTPSA id e185-20020a3769c2000000b006a5d4f32e5dsm14030266qkc.128.2022.06.07.08.49.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jun 2022 08:49:38 -0700 (PDT) From: Ed Czeck To: dev@dpdk.org Cc: ferruh.yigit@xilinx.com, ktraynor@redhat.com, bluca@debian.org, Shepard Siegel , John Miller Subject: [PATCH v3 5/7] net/ark: report additional errors from firmware Date: Tue, 7 Jun 2022 11:49:15 -0400 Message-Id: <20220607154917.1871118-5-ed.czeck@atomicrules.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220607154917.1871118-1-ed.czeck@atomicrules.com> References: <20220502212232.1283-1-ed.czeck@atomicrules.com> <20220607154917.1871118-1-ed.czeck@atomicrules.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org detect and report completion errors from firmware Signed-off-by: Ed Czeck --- drivers/net/ark/ark_rqp.c | 6 ++++-- drivers/net/ark/ark_rqp.h | 3 ++- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/net/ark/ark_rqp.c b/drivers/net/ark/ark_rqp.c index ef9ccd0706..efb9730fe6 100644 --- a/drivers/net/ark/ark_rqp.c +++ b/drivers/net/ark/ark_rqp.c @@ -22,14 +22,16 @@ ark_rqp_stats_reset(struct ark_rqpace_t *rqp) void ark_rqp_dump(struct ark_rqpace_t *rqp) { - if (rqp->err_count_other != 0) + if (rqp->err_count_other || rqp->cmpl_errors) ARK_PMD_LOG(ERR, "RQP Errors noted: ctrl: %d cplh_hmax %d cpld_max %d" ARK_SU32 + ARK_SU32 ARK_SU32 "\n", rqp->ctrl, rqp->cplh_max, rqp->cpld_max, "Error Count", rqp->err_cnt, - "Error General", rqp->err_count_other); + "Error General", rqp->err_count_other, + "Cmpl Errors", rqp->cmpl_errors); ARK_PMD_LOG(INFO, "RQP Dump: ctrl: %d cplh_hmax %d cpld_max %d" ARK_SU32 diff --git a/drivers/net/ark/ark_rqp.h b/drivers/net/ark/ark_rqp.h index 6c8046062b..d09f242e1e 100644 --- a/drivers/net/ark/ark_rqp.h +++ b/drivers/net/ark/ark_rqp.h @@ -48,7 +48,8 @@ struct ark_rqpace_t { volatile uint32_t cpld_pending_max; volatile uint32_t err_count_other; char eval[4]; - volatile int lasped; + volatile int32_t lasped; + volatile uint32_t cmpl_errors; }; void ark_rqp_dump(struct ark_rqpace_t *rqp); -- 2.25.1