From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A369AA0548; Tue, 7 Jun 2022 23:32:25 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3F34242847; Tue, 7 Jun 2022 23:32:06 +0200 (CEST) Received: from mail-qv1-f45.google.com (mail-qv1-f45.google.com [209.85.219.45]) by mails.dpdk.org (Postfix) with ESMTP id 9F2404281B for ; Tue, 7 Jun 2022 23:32:05 +0200 (CEST) Received: by mail-qv1-f45.google.com with SMTP id i19so13219318qvu.13 for ; Tue, 07 Jun 2022 14:32:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=atomicrules-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/aJTnDZAY4+IPBAwQbrCOBzdOumcpw82eW4HTnwLw+4=; b=hia7QID9T9XiER9VoxXAkV2OtUtxG3TWDidFXFty+AS10qvWmNJskKrhTKN6fx05ez cOGjArkHBj6ao8jPTA1wNC61tsPcU4J2+9CM3u0RYzz2E5UlyKaquUn/jRjLtx9yiuGC bwN6CO2GdeUrFzb6YyA0Ns6UEojnrXqeB+pJd5DHC36OP10kLvrHWDrIZ5ekJ1HGtcdX /d4qMTiz2Lv1IcjGTHztF1kuJNwgaZyNEBPv1HflIYG9Fm9AStx95C02faq2SXXUZUeA YimYhVlFOIHdGU6o/wA7iYW8DIN1WYrPU/p52LpczpOQwvTxFabX1fMd80OYaMJMeJst DeSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/aJTnDZAY4+IPBAwQbrCOBzdOumcpw82eW4HTnwLw+4=; b=hvUADdyiyeQf9h5hDMHKPzO+WzdEb0sXVarP0TwCoB520eZ9b9qmrYJ40rrOKyGlLC bRpGFj8if92Zg0tO7r7SQcUx+MRT5Dv+b4/SqHwJCS6E5kU/+J0axoxGeZAKoNTVbERu CAPsMpIEcatg7zHXfDN1Sq6gZmlnQSivapPFyWccPrJ3iDkLkZOxmmgaJUjJwsTLuJMi bp0w3cI5mqcEVj2wJP+W+7Ic6LE3gK97/RnJYdhXrk5rc0dRcy23y1DGcJYb0cItn7jP lOcbKi7pUnSfdxy4NUrUPVLkXJUmqZ5cR4CHQj1lIUF4WUbQ8b5BPl3g/DVXntTbrzZ0 lJzg== X-Gm-Message-State: AOAM532sz9mDgO08L5R6b7Qpm/fwCEsDjMLgUst6hy5K52lPB1ftYOsB 00yX5bsIqR9oYa+a215V5KInY6YUapZWNQ== X-Google-Smtp-Source: ABdhPJw3ohndThZqawwAJ1Im5p2Xol4NMG8ibu+m7NKORZdJtDo32pPuXbrC1VEToDF4OBgQThcIzQ== X-Received: by 2002:a05:6214:1150:b0:464:4bd3:e931 with SMTP id b16-20020a056214115000b004644bd3e931mr23480527qvt.32.1654637523771; Tue, 07 Jun 2022 14:32:03 -0700 (PDT) Received: from z390.czeck.local (pool-173-48-102-189.bstnma.fios.verizon.net. [173.48.102.189]) by smtp.gmail.com with ESMTPSA id x6-20020ae9f806000000b006a6cdc79229sm3774711qkh.55.2022.06.07.14.32.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jun 2022 14:32:03 -0700 (PDT) From: Ed Czeck To: dev@dpdk.org Cc: ferruh.yigit@xilinx.com, ktraynor@redhat.com, bluca@debian.org, Shepard Siegel , John Miller Subject: [PATCH v4 5/7] net/ark: report additional errors from firmware Date: Tue, 7 Jun 2022 17:31:47 -0400 Message-Id: <20220607213149.1980193-5-ed.czeck@atomicrules.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220607213149.1980193-1-ed.czeck@atomicrules.com> References: <20220502212232.1283-1-ed.czeck@atomicrules.com> <20220607213149.1980193-1-ed.czeck@atomicrules.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org detect and report completion errors from firmware Signed-off-by: Ed Czeck --- drivers/net/ark/ark_rqp.c | 6 ++++-- drivers/net/ark/ark_rqp.h | 3 ++- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/net/ark/ark_rqp.c b/drivers/net/ark/ark_rqp.c index ef9ccd0706..efb9730fe6 100644 --- a/drivers/net/ark/ark_rqp.c +++ b/drivers/net/ark/ark_rqp.c @@ -22,14 +22,16 @@ ark_rqp_stats_reset(struct ark_rqpace_t *rqp) void ark_rqp_dump(struct ark_rqpace_t *rqp) { - if (rqp->err_count_other != 0) + if (rqp->err_count_other || rqp->cmpl_errors) ARK_PMD_LOG(ERR, "RQP Errors noted: ctrl: %d cplh_hmax %d cpld_max %d" ARK_SU32 + ARK_SU32 ARK_SU32 "\n", rqp->ctrl, rqp->cplh_max, rqp->cpld_max, "Error Count", rqp->err_cnt, - "Error General", rqp->err_count_other); + "Error General", rqp->err_count_other, + "Cmpl Errors", rqp->cmpl_errors); ARK_PMD_LOG(INFO, "RQP Dump: ctrl: %d cplh_hmax %d cpld_max %d" ARK_SU32 diff --git a/drivers/net/ark/ark_rqp.h b/drivers/net/ark/ark_rqp.h index 6c8046062b..d09f242e1e 100644 --- a/drivers/net/ark/ark_rqp.h +++ b/drivers/net/ark/ark_rqp.h @@ -48,7 +48,8 @@ struct ark_rqpace_t { volatile uint32_t cpld_pending_max; volatile uint32_t err_count_other; char eval[4]; - volatile int lasped; + volatile int32_t lasped; + volatile uint32_t cmpl_errors; }; void ark_rqp_dump(struct ark_rqpace_t *rqp); -- 2.25.1