From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 96ECCA0555; Thu, 9 Jun 2022 11:28:22 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3CC0140689; Thu, 9 Jun 2022 11:28:22 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 7585D40220 for ; Thu, 9 Jun 2022 11:28:21 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 2598BokM026271; Thu, 9 Jun 2022 02:28:20 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding : content-type; s=pfpt0220; bh=gqXswXgeRulfto/K6s1hwwq+zDLiNED0GiSbIFZov8k=; b=bdLdqn+HSccup46i8vzQPpkvu9ofnaYPYVv4YrOug3RoOjAesSEa6b+3WO5WFXqTfT1T kB43XDfiH46CXI9j3Zz1UvjrGnZdPC03pGR4LpTaWXJYrEMpqKUyy3OPrO6XkL3nyGfH Dx7pZh9WsqrxZoCWfUZkfiO+FV75k9Zkt544QTWF87artuWSdm1BefVwCw3OtfFcVa9d nf1R8GoeBYKjNofLqeBh4Q6GLebDHtAwbKbhYWyo/tzgQ2s5WKENSOAAzz1DouBSE9GT 6nRs6qQzMDgzwjfjvVd39cZ+yzT5nZAr7yBK48F1GcQW+sWTSc4+FPVMUuc4RuThnLPn Yg== Received: from dc5-exch02.marvell.com ([199.233.59.182]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3gjb7pgfu0-3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Thu, 09 Jun 2022 02:28:20 -0700 Received: from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Thu, 9 Jun 2022 02:28:19 -0700 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 9 Jun 2022 02:28:19 -0700 Received: from localhost.localdomain (unknown [10.28.34.39]) by maili.marvell.com (Postfix) with ESMTP id 92A8B3F70A0; Thu, 9 Jun 2022 02:28:15 -0700 (PDT) From: Volodymyr Fialko To: , Ankur Dwivedi , Anoob Joseph , Tejasree Kondoj , "Abhinandan Gujjar" , Akhil Goyal , Volodymyr Fialko , Fan Zhang CC: Subject: [PATCH] crypto/cnxk: fix condition check Date: Thu, 9 Jun 2022 11:27:31 +0200 Message-ID: <20220609092731.131856-1-vfialko@marvell.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Proofpoint-GUID: -c2eJ_E2hSGcCZgHp1m8Lh5Ts35Ytk_x X-Proofpoint-ORIG-GUID: -c2eJ_E2hSGcCZgHp1m8Lh5Ts35Ytk_x X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.874,Hydra:6.0.517,FMLib:17.11.64.514 definitions=2022-06-09_08,2022-06-07_02,2022-02-23_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The value of ec_mdata cannot be NULL, instead check that value of private_data_offset was set. Fixes: c3a498c01121 ("crypto/cnxk: add event metadata set operation") Coverity issue: 378861 Coverity issue: 378865 Signed-off-by: Volodymyr Fialko --- drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 4 ++-- drivers/crypto/cnxk/cn9k_cryptodev_ops.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/cnxk/cn10k_cryptodev_ops.c b/drivers/crypto/cnxk/cn10k_cryptodev_ops.c index c811504f93..f4aaa273c1 100644 --- a/drivers/crypto/cnxk/cn10k_cryptodev_ops.c +++ b/drivers/crypto/cnxk/cn10k_cryptodev_ops.c @@ -363,10 +363,10 @@ cn10k_ca_meta_info_extract(struct rte_crypto_op *op, uint8_t cdev_id; uint16_t qp_id; + if (unlikely(op->private_data_offset == 0)) + return -EINVAL; ec_mdata = (union rte_event_crypto_metadata *) ((uint8_t *)op + op->private_data_offset); - if (!ec_mdata) - return -EINVAL; rsp_info = &ec_mdata->response_info; cdev_id = ec_mdata->request_info.cdev_id; qp_id = ec_mdata->request_info.queue_pair_id; diff --git a/drivers/crypto/cnxk/cn9k_cryptodev_ops.c b/drivers/crypto/cnxk/cn9k_cryptodev_ops.c index 10e7bb6e52..d9d41f9dab 100644 --- a/drivers/crypto/cnxk/cn9k_cryptodev_ops.c +++ b/drivers/crypto/cnxk/cn9k_cryptodev_ops.c @@ -419,10 +419,10 @@ cn9k_ca_meta_info_extract(struct rte_crypto_op *op, uint8_t cdev_id; uint16_t qp_id; + if (unlikely(op->private_data_offset == 0)) + return -EINVAL; ec_mdata = (union rte_event_crypto_metadata *) ((uint8_t *)op + op->private_data_offset); - if (!ec_mdata) - return -EINVAL; rsp_info = &ec_mdata->response_info; cdev_id = ec_mdata->request_info.cdev_id; qp_id = ec_mdata->request_info.queue_pair_id; -- 2.25.1