From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9F233A054F; Sat, 11 Jun 2022 01:38:11 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5C86940222; Sat, 11 Jun 2022 01:38:11 +0200 (CEST) Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) by mails.dpdk.org (Postfix) with ESMTP id 2B89840041 for ; Sat, 11 Jun 2022 01:38:10 +0200 (CEST) Received: by mail-pf1-f176.google.com with SMTP id i64so734244pfc.8 for ; Fri, 10 Jun 2022 16:38:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=TlUNZugYE+KRKhGszl9VHxUde1xN8M/E2VKb6GDzSnc=; b=EQSmGT4/nNASlzmNUfhQdqYZm9MKknBTz2g3BoVgCIcS4eEwJlwiGZZbKbBkTWw3Lm gx9dghD2Jq6cRByOdFGdoSiK9VTdp2xlNr09khbR24mVCvve9hQWtbA7xqSXrSt37vwt XvoWG4hDFC7tFJSvYyzLm8LQUuOqfaoQxrF9p6IlnNaeMqFDs1JeFBZ/OGmOzWsJIdqw GcXLz/xklAApjvqeIC6OPbIdehaz82ebUTzTYxW8E+TwPLJGn1kXDxUPh7WztQjcEHnU CToTvngAm6lrpTLW+cNfmW8qETFqmpdUn+8s6mmf9Afa0W4Y6MNv0gz2O94TW1mGGdXu 1FBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=TlUNZugYE+KRKhGszl9VHxUde1xN8M/E2VKb6GDzSnc=; b=7QBEIwDjqTiXMoTQdSa6PTmhUGWl5W0wmi3yCHG3vZQPBdburTKwAXEZgw0IuinCG8 Ufw4qyQJ3+d6LfdwAFiNDpX+JwDJyZM0ccTsT7GqjHDddGlqDv169sbK/fuPPJ6MfxTC 1lPAEgS2SCi6sHDjm4cOYkK6M6n+15dqzlNoOU9dpuI0iIuHr7qZYoK5m5WrRvbsQfJG WMzVYC0BaMwiQV9CGvVnIXDK4EevmH/QFyfKwnbnyiD1QRN75qnbUqPKPjiKH10nF+5S mnK7dQmyTwCMK7fjwykNbyVdvDF5FPLW4uguiLkhlTzHvrJWB8IACeIWTjFSS1/Ifmrb xc6w== X-Gm-Message-State: AOAM531rr1u8qfCEdPzvPpdH15QuTyAkAZD58HcQMxtGp2LMDoXjLaXk Cgow4F862yrLxEYmCOHs1G5tkBj88x2Xxuuq X-Google-Smtp-Source: ABdhPJxhD1smkGm4hD33WJJH4twEwOaY9QXFWibxsq4NkG3I8B7F4zB7WovgAfygiqcVne+2DirY9w== X-Received: by 2002:a63:475d:0:b0:3fc:b414:f2aa with SMTP id w29-20020a63475d000000b003fcb414f2aamr41482917pgk.17.1654904289081; Fri, 10 Jun 2022 16:38:09 -0700 (PDT) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id s12-20020a170903214c00b00161955fe0d5sm247875ple.274.2022.06.10.16.38.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jun 2022 16:38:08 -0700 (PDT) Date: Fri, 10 Jun 2022 16:38:06 -0700 From: Stephen Hemminger To: Tyler Retzlaff Cc: dev@dpdk.org, anatoly.burakov@intel.com Subject: Re: [PATCH] doc/eal: add signal safety warning Message-ID: <20220610163806.1477cb02@hermes.local> In-Reply-To: <20220610225334.GB14494@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <20220610152343.38455-1-stephen@networkplumber.org> <20220610225334.GB14494@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 10 Jun 2022 15:53:34 -0700 Tyler Retzlaff wrote: > On Fri, Jun 10, 2022 at 08:23:43AM -0700, Stephen Hemminger wrote: > > The DPDK is not designed to be used from a signal handler. > > Add a notice in the documentation describing this limitation, > > similar to Linux signal-safety manual page. > > > > Bugzilla ID: 1030 > > Signed-off-by: Stephen Hemminger > > --- > > doc/guides/prog_guide/env_abstraction_layer.rst | 13 +++++++++++++ > > 1 file changed, 13 insertions(+) > > > > diff --git a/doc/guides/prog_guide/env_abstraction_layer.rst b/doc/guides/prog_guide/env_abstraction_layer.rst > > index 5f0748fba1c0..36ab4b5ba9b6 100644 > > --- a/doc/guides/prog_guide/env_abstraction_layer.rst > > +++ b/doc/guides/prog_guide/env_abstraction_layer.rst > > @@ -732,6 +732,19 @@ controlled with tools like taskset (Linux) or cpuset (FreeBSD), > > - with affinity restricted to 2-3, the Control Threads will end up on > > CPU 2 (main lcore, which is the default when no CPU is available). > > > > +Signal Safety > > +~~~~~~~~~~~~~ > > + > > +The DPDK functions in general can not be safely called from a signal handler. > > +Most functions are not async-signal-safe because they can acquire locks > > +and other resources that make them nonrentrant. > > + > > +To avoid problems with unsafe functions, can be avoided if required > ^^^^^^^^^^^^^^^^^^^^^^^^^ > > above doesn't quite read right for me, maybe a missing word / needs > re-wording? Yes, will reword that