DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Tyler Retzlaff <roretzla@linux.microsoft.com>
Cc: dev@dpdk.org, anatoly.burakov@intel.com
Subject: Re: [PATCH] doc/eal: add caveat about spinlocks from non-pinned threads
Date: Fri, 10 Jun 2022 17:00:11 -0700	[thread overview]
Message-ID: <20220610170011.65272cf7@hermes.local> (raw)
In-Reply-To: <20220610234815.GE14494@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>

On Fri, 10 Jun 2022 16:48:15 -0700
Tyler Retzlaff <roretzla@linux.microsoft.com> wrote:

> >  
> > ++ locking
> > +
> > +  If a pthread, that is not pinned to an lcore acquires a lock such as a  
> 
> nit: suggest not using term pthread but instead just say thread as not
> to imply a specific platform/implementation.
> 
> > +  DPDK based lock (rte_spinlock, rte_rwlock, rte_ticketlock, rte_mcslock)
> > +  then there is a possibility of large application delays.
> > +  The problem is that if a thread is scheduled off the CPU while it holds
> > +  a lock, then other threads will waste time spinning on the lock until  
> 
> 'until the lock holder' -> 'until the thread holding the lock'
> 
> but i'm not really fussed, just a suggestion.

Sure, that wording was from existing pthread_spin_init() man page

  reply	other threads:[~2022-06-11  0:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-10 15:28 Stephen Hemminger
2022-06-10 23:45 ` Tyler Retzlaff
2022-06-10 23:48 ` Tyler Retzlaff
2022-06-11  0:00   ` Stephen Hemminger [this message]
2022-06-11  1:55 ` fengchengwen
2022-06-11  3:33   ` Stephen Hemminger
2022-06-11 16:41 ` Mattias Rönnblom

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220610170011.65272cf7@hermes.local \
    --to=stephen@networkplumber.org \
    --cc=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=roretzla@linux.microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).