* [PATCH 1/1] doc: add author name on cc to git fixline alias
@ 2022-06-12 11:40 Heinrich Schuchardt
2022-06-13 7:47 ` Ferruh Yigit
0 siblings, 1 reply; 2+ messages in thread
From: Heinrich Schuchardt @ 2022-06-12 11:40 UTC (permalink / raw)
To: dev
Cc: Adrien Mazarguil, Harry van Haaren, Thomas Monjalon,
John McNamara, Heinrich Schuchardt
We should add both the author name and the author email address to
the Cc: line of a blamed patch.
Fixes: f9ef083c6cfe ("doc: add author on cc to git fixline alias")
Cc: Harry van Haaren <harry.van.haaren@intel.com>
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
---
doc/guides/contributing/patches.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/guides/contributing/patches.rst b/doc/guides/contributing/patches.rst
index bebcaf3925..aad2429e58 100644
--- a/doc/guides/contributing/patches.rst
+++ b/doc/guides/contributing/patches.rst
@@ -260,7 +260,7 @@ Here are some guidelines for the body of a commit message:
You can generate the required lines using the following git alias, which prints
the commit SHA and the author of the original code::
- git config alias.fixline "log -1 --abbrev=12 --format='Fixes: %h (\"%s\")%nCc: %ae'"
+ git config alias.fixline "log -1 --abbrev=12 --format='Fixes: %h (\"%s\")%nCc: %an <%ae>'"
The output of ``git fixline <SHA>`` must then be added to the commit message::
--
2.36.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] doc: add author name on cc to git fixline alias
2022-06-12 11:40 [PATCH 1/1] doc: add author name on cc to git fixline alias Heinrich Schuchardt
@ 2022-06-13 7:47 ` Ferruh Yigit
0 siblings, 0 replies; 2+ messages in thread
From: Ferruh Yigit @ 2022-06-13 7:47 UTC (permalink / raw)
To: Heinrich Schuchardt, dev
Cc: Adrien Mazarguil, Harry van Haaren, Thomas Monjalon,
John McNamara, David Marchand
On 6/12/2022 12:40 PM, Heinrich Schuchardt wrote:
> We should add both the author name and the author email address to
> the Cc: line of a blamed patch.
>
> Fixes: f9ef083c6cfe ("doc: add author on cc to git fixline alias")
> Cc: Harry van Haaren <harry.van.haaren@intel.com>
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> ---
> doc/guides/contributing/patches.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/doc/guides/contributing/patches.rst b/doc/guides/contributing/patches.rst
> index bebcaf3925..aad2429e58 100644
> --- a/doc/guides/contributing/patches.rst
> +++ b/doc/guides/contributing/patches.rst
> @@ -260,7 +260,7 @@ Here are some guidelines for the body of a commit message:
> You can generate the required lines using the following git alias, which prints
> the commit SHA and the author of the original code::
>
> - git config alias.fixline "log -1 --abbrev=12 --format='Fixes: %h (\"%s\")%nCc: %ae'"
> + git config alias.fixline "log -1 --abbrev=12 --format='Fixes: %h (\"%s\")%nCc: %an <%ae>'"
>
Hi Heinrich,
We don't keep the 'Cc: ' lines in commit lines when pushing to repo,
it is mainly added to be sure author of the original change is cc'ed
since 'git send-email' picks emails from commit log.
So although it doesn't hurt, it is also not needed to have full name &
email since it will be stripped explicitly.
Thanks,
ferruh
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-06-13 7:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-12 11:40 [PATCH 1/1] doc: add author name on cc to git fixline alias Heinrich Schuchardt
2022-06-13 7:47 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).