From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 69D8EA034C; Wed, 22 Jun 2022 16:55:37 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0F86E40A84; Wed, 22 Jun 2022 16:55:37 +0200 (CEST) Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) by mails.dpdk.org (Postfix) with ESMTP id 7EFEF4069F for ; Wed, 22 Jun 2022 16:55:35 +0200 (CEST) Received: by mail-pg1-f181.google.com with SMTP id g186so16331891pgc.1 for ; Wed, 22 Jun 2022 07:55:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=e+8tE+EZ/1JwjZqcGzV6nIYaCyzwda74r1Vc/SLSYCc=; b=0VGVQYV5cJCtJ9hLDfVZ5/yBamakpi/Pcvil5KMvTqOScLxxJyphvruzne0/TR43iP wX6/+TtoJrXXiIMBE3Mx4z6LFetZQGoGusPePM7RhVqqMsZSh9twFMtwztS3nCG+/iqE fe+CHoG8tRNI1o+Kl7qLSbobsFwCiAR7LZQtjcrtelhMw2MSCEVvYijyffNJn/DW1v/5 z9CUej2l3SZYMRKVaEc66cSJDYfTFzEPpUxO8MvnSbr4U2513D0FBmF2BFKEJ/A/UZeu 8QY8ImoibqFMQMBB6PP+xgaivLMw+RhrPHHtD53AWt90s50UGOzzH5yG3tLQuJvbod7g 6Y8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=e+8tE+EZ/1JwjZqcGzV6nIYaCyzwda74r1Vc/SLSYCc=; b=kfY+H/XWVbAT9aisY2bYefaAnloCfBZa6rdfX4Eur4PXOswPfISrnCF+JarowkMlhY AkyUWXJdd0+5OgwLG1jEDN8j14wRO3KjzhDIYyvhj2yvbNWCgkC9tiapZ32bVaHTrkli TrkZzpoefqrXdF8ijPLLNYuUzXfsAJepfiYUVvagyYrmuld7Q0JYsucAlGwASgKUSxYj MvvHyDlHpdKzAp9u+GAEHoAdJwZiFd2LA+ODbskrz2zrENXCugOnw9VtfdLEMzuf97XG PUbk+GFdYBN3FvpezwBOeJ5Syr+L1rg8KUI3k9Ow/MvFYB3PFMuYHYrfEV4oN6+dTpqM PVpg== X-Gm-Message-State: AJIora+dasOscZlrwRvd89X+7x1xz8WXj19Cc3Moh07vqc9pTI9UVXVr p4XoMDcvixqAxs4O1uS7u6S/rQ== X-Google-Smtp-Source: AGRyM1sO4XX4XPRGM3qa64VFmutiFsNGYmf0nRGTvVsCiRkRaNDGgi0dNzO23NKG+sYayuwjT8z8Gw== X-Received: by 2002:a05:6a00:704:b0:525:1cd0:ca5f with SMTP id 4-20020a056a00070400b005251cd0ca5fmr18835535pfl.23.1655909734499; Wed, 22 Jun 2022 07:55:34 -0700 (PDT) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q3-20020a170902f78300b0016788487357sm12914989pln.132.2022.06.22.07.55.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Jun 2022 07:55:34 -0700 (PDT) Date: Wed, 22 Jun 2022 07:55:31 -0700 From: Stephen Hemminger To: Thomas Monjalon Cc: Bruce Richardson , dev@dpdk.org Subject: Re: [PATCH v3 4/8] lib: document existing free functions Message-ID: <20220622075531.57b45556@hermes.local> In-Reply-To: <4312383.U7HbjWM52l@thomas> References: <20220219234322.61309-1-stephen@networkplumber.org> <20220228090805.6730fcee@hermes.local> <4312383.U7HbjWM52l@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 22 Jun 2022 11:23:04 +0200 Thomas Monjalon wrote: > 28/02/2022 18:08, Stephen Hemminger: > > On Mon, 28 Feb 2022 09:42:47 +0000 > > Bruce Richardson wrote: > > > > > On Sun, Feb 27, 2022 at 09:48:57PM +0100, Thomas Monjalon wrote: > > > > 20/02/2022 19:21, Stephen Hemminger: > > > > > + * If NULL then, the function does nothing. > > > > > > > > I'm not English native, but I thought it should be one of these 2 forms: > > > > - If NULL, the function does nothing. > > > > - If NULL then the function does nothing. > > > > > > > I would agree, and also would tend toward the first version. > > > > > > /Bruce > > > > Either one. I was just copy/pasting pre-existing grammar problem. > > Please do you want to respin? > > Sure.