From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0139AA0540; Mon, 4 Jul 2022 17:27:56 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2220742B73; Mon, 4 Jul 2022 17:27:42 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 6D3EC40E09; Mon, 4 Jul 2022 17:27:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1656948458; x=1688484458; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=tTzgjTPtKJyGFi85E66ohWVWqgfAUW5ECkd/53bJxlk=; b=ItGpVdIOeVXTvdLunXWPgHZ0erho4CQI4wBacWs5zVRP6I6NEaUCKs1Q vRhSfHnfqe0cQgywVuEFtQn3+MPDvq+1ErvMQ+p6E6ylrQPcSe+gzq3uu nJUubRTJjxIBszPn1SvHJ7Oo9Emd9VgEF5RkaVIW8s1Qq666Qb3FBZdnI jFqrtkESZlFux0BoeaqFSJ26N+S/6RQy0aeVk/Y/VnmUMTcW02k8kM/d7 SPP8w6GSPE9CVPO4o1nR5h8vUiHwD6lpWZJaFjcz+WTKdEmhyOFISvs70 IeANeHLMSmvBuOfGOfITSWy+YMCPO6FCC8gf1U2Z5H6utIbS1JdO2ruwB Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10398"; a="262946841" X-IronPort-AV: E=Sophos;i="5.92,243,1650956400"; d="scan'208";a="262946841" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jul 2022 08:27:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,243,1650956400"; d="scan'208";a="682231016" Received: from silpixa00401122.ir.intel.com ([10.237.213.29]) by FMSMGA003.fm.intel.com with ESMTP; 04 Jul 2022 08:27:11 -0700 From: Kevin Laatz To: dev@dpdk.org Cc: bruce.richardson@intel.com, Kevin Laatz , stable@dpdk.org Subject: [PATCH v3 3/3] dma/idxd: fix null pointer dereference during pci remove Date: Mon, 4 Jul 2022 16:27:51 +0100 Message-Id: <20220704152751.943965-4-kevin.laatz@intel.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20220704152751.943965-1-kevin.laatz@intel.com> References: <20220408141504.1319913-1-kevin.laatz@intel.com> <20220704152751.943965-1-kevin.laatz@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The 'info' struct was being declared as a NULL pointer. If a NULL pointer is passed to 'rte_dma_info_get', EINVAL is returned and the struct is not populated. This subsequently causes a segfault when dereferencing 'info'. This patch fixes the issue by simply declaring 'info' on the stack and passing its address to 'rte_dma_info_get'. Fixes: 9449330a8458 ("dma/idxd: create dmadev instances on PCI probe") Cc: stable@dpdk.org Signed-off-by: Kevin Laatz Acked-by: Bruce Richardson --- drivers/dma/idxd/idxd_pci.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/dma/idxd/idxd_pci.c b/drivers/dma/idxd/idxd_pci.c index 2c3b01cd2b..2f8ec06d9e 100644 --- a/drivers/dma/idxd/idxd_pci.c +++ b/drivers/dma/idxd/idxd_pci.c @@ -380,10 +380,10 @@ idxd_dmadev_remove_pci(struct rte_pci_device *dev) IDXD_PMD_INFO("Closing %s on NUMA node %d", name, dev->device.numa_node); RTE_DMA_FOREACH_DEV(i) { - struct rte_dma_info *info = {0}; - rte_dma_info_get(i, info); - if (strncmp(name, info->dev_name, strlen(name)) == 0) - idxd_dmadev_destroy(info->dev_name); + struct rte_dma_info info; + rte_dma_info_get(i, &info); + if (strncmp(name, info.dev_name, strlen(name)) == 0) + idxd_dmadev_destroy(info.dev_name); } return 0; -- 2.31.1