* [PATCH] net/iavf: fix gtpu extension flow error
@ 2022-07-05 10:09 wenxuanx.wu
2022-07-05 11:52 ` Zhang, Qi Z
2022-07-06 2:56 ` [PATCH v2] " wenxuanx.wu
0 siblings, 2 replies; 8+ messages in thread
From: wenxuanx.wu @ 2022-07-05 10:09 UTC (permalink / raw)
To: jingjing.wu, beilei.xing, dev
Cc: qiming.yang, yidingx.zhou, wenxuanx.wu, simei.su, stable
From: Wenxuan Wu <wenxuanx.wu@intel.com>
Due to the change of struct rte_gtp_psc_generic_hdr, firmware can
not handle gtp_psc properly, we induce a new structure to fix this
gap between firmware and struct rte_gtp_psc_generic_hdr.
Fixes: d5eb3e600d9e ("net/iavf: support flow director basic rule")
Cc: simei.su@intel.com
Cc: stable@dpdk.com
Signed-off-by: Wenxuan Wu <wenxuanx.wu@intel.com>
---
drivers/net/iavf/iavf_fdir.c | 18 ++++++++++++++++--
1 file changed, 16 insertions(+), 2 deletions(-)
diff --git a/drivers/net/iavf/iavf_fdir.c b/drivers/net/iavf/iavf_fdir.c
index f236260502..5ac4e88728 100644
--- a/drivers/net/iavf/iavf_fdir.c
+++ b/drivers/net/iavf/iavf_fdir.c
@@ -1300,8 +1300,22 @@ iavf_fdir_parse_pattern(__rte_unused struct iavf_adapter *ad,
GTPU_DWN, QFI);
}
- rte_memcpy(hdr->buffer, gtp_psc_spec,
- sizeof(*gtp_psc_spec));
+ /*
+ * New structure to fix gap between firmware and
+ * rte_gtp_psc_generic_hdr.
+ */
+ struct iavf_gtp_psc_spec_hdr {
+ uint8_t len;
+ uint8_t qfi:6;
+ uint8_t type:4;
+ uint8_t next;
+ } psc;
+ psc.len = gtp_psc_spec->hdr.ext_hdr_len;
+ psc.qfi = gtp_psc_spec->hdr.qfi;
+ psc.type = gtp_psc_spec->hdr.type;
+ psc.next = 0;
+ rte_memcpy(hdr->buffer, &psc,
+ sizeof(struct iavf_gtp_psc_spec_hdr));
}
hdrs->count = ++layer;
--
2.25.1
^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH] net/iavf: fix gtpu extension flow error
2022-07-05 10:09 [PATCH] net/iavf: fix gtpu extension flow error wenxuanx.wu
@ 2022-07-05 11:52 ` Zhang, Qi Z
2022-07-06 2:56 ` [PATCH v2] " wenxuanx.wu
1 sibling, 0 replies; 8+ messages in thread
From: Zhang, Qi Z @ 2022-07-05 11:52 UTC (permalink / raw)
To: Wu, WenxuanX, Wu, Jingjing, Xing, Beilei, dev
Cc: Yang, Qiming, Zhou, YidingX, Wu, WenxuanX, Su, Simei, stable
> -----Original Message-----
> From: wenxuanx.wu@intel.com <wenxuanx.wu@intel.com>
> Sent: Tuesday, July 5, 2022 6:10 PM
> To: Wu, Jingjing <jingjing.wu@intel.com>; Xing, Beilei <beilei.xing@intel.com>;
> dev@dpdk.org
> Cc: Yang, Qiming <qiming.yang@intel.com>; Zhou, YidingX
> <yidingx.zhou@intel.com>; Wu, WenxuanX <wenxuanx.wu@intel.com>; Su,
> Simei <simei.su@intel.com>; stable@dpdk.com
> Subject: [PATCH] net/iavf: fix gtpu extension flow error
>
> From: Wenxuan Wu <wenxuanx.wu@intel.com>
>
> Due to the change of struct rte_gtp_psc_generic_hdr, firmware can not handle
> gtp_psc properly, we induce a new structure to fix this gap between firmware
> and struct rte_gtp_psc_generic_hdr.
Why this is related firmware? iavf rte_flow is not related with firmware, it is about virtchnl between VF and PF
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2] net/iavf: fix gtpu extension flow error
2022-07-05 10:09 [PATCH] net/iavf: fix gtpu extension flow error wenxuanx.wu
2022-07-05 11:52 ` Zhang, Qi Z
@ 2022-07-06 2:56 ` wenxuanx.wu
2022-07-07 6:11 ` Huang, ZhiminX
2022-07-07 6:57 ` Yang, Qiming
1 sibling, 2 replies; 8+ messages in thread
From: wenxuanx.wu @ 2022-07-06 2:56 UTC (permalink / raw)
To: qiz.zhang, beilei.xing, dev
Cc: qiming.yang, yidingx.zhou, wenxuanx.wu, simei.su, stable
From: Wenxuan Wu <wenxuanx.wu@intel.com>
Due to the change of struct rte_gtp_psc_generic_hdr, kernel driver can
not handle gtp_psc properly, we introduce a new structure to fix this
gap between kernel driver and struct rte_gtp_psc_generic_hdr.
Fixes: d5eb3e600d9e ("net/iavf: support flow director basic rule")
Cc: simei.su@intel.com
Cc: stable@dpdk.com
Signed-off-by: Wenxuan Wu <wenxuanx.wu@intel.com>
---
v2: refine commit log and doc.
---
drivers/net/iavf/iavf_fdir.c | 18 ++++++++++++++++--
1 file changed, 16 insertions(+), 2 deletions(-)
diff --git a/drivers/net/iavf/iavf_fdir.c b/drivers/net/iavf/iavf_fdir.c
index f236260502..4789d46ab2 100644
--- a/drivers/net/iavf/iavf_fdir.c
+++ b/drivers/net/iavf/iavf_fdir.c
@@ -1300,8 +1300,22 @@ iavf_fdir_parse_pattern(__rte_unused struct iavf_adapter *ad,
GTPU_DWN, QFI);
}
- rte_memcpy(hdr->buffer, gtp_psc_spec,
- sizeof(*gtp_psc_spec));
+ /*
+ * New structure to fix gap between kernel driver and
+ * rte_gtp_psc_generic_hdr.
+ */
+ struct iavf_gtp_psc_spec_hdr {
+ uint8_t len;
+ uint8_t qfi:6;
+ uint8_t type:4;
+ uint8_t next;
+ } psc;
+ psc.len = gtp_psc_spec->hdr.ext_hdr_len;
+ psc.qfi = gtp_psc_spec->hdr.qfi;
+ psc.type = gtp_psc_spec->hdr.type;
+ psc.next = 0;
+ rte_memcpy(hdr->buffer, &psc,
+ sizeof(struct iavf_gtp_psc_spec_hdr));
}
hdrs->count = ++layer;
--
2.25.1
^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH v2] net/iavf: fix gtpu extension flow error
2022-07-06 2:56 ` [PATCH v2] " wenxuanx.wu
@ 2022-07-07 6:11 ` Huang, ZhiminX
2022-07-07 6:57 ` Yang, Qiming
1 sibling, 0 replies; 8+ messages in thread
From: Huang, ZhiminX @ 2022-07-07 6:11 UTC (permalink / raw)
To: Wu, WenxuanX, qiz.zhang, Xing, Beilei, dev
Cc: Yang, Qiming, Zhou, YidingX, Wu, WenxuanX, Su, Simei, stable
> -----Original Message-----
> From: wenxuanx.wu@intel.com <wenxuanx.wu@intel.com>
> Sent: Wednesday, July 6, 2022 10:56 AM
> To: qiz.zhang@intel.com; Xing, Beilei <beilei.xing@intel.com>; dev@dpdk.org
> Cc: Yang, Qiming <qiming.yang@intel.com>; Zhou, YidingX
> <yidingx.zhou@intel.com>; Wu, WenxuanX <wenxuanx.wu@intel.com>; Su,
> Simei <simei.su@intel.com>; stable@dpdk.com
> Subject: [PATCH v2] net/iavf: fix gtpu extension flow error
>
> From: Wenxuan Wu <wenxuanx.wu@intel.com>
>
> Due to the change of struct rte_gtp_psc_generic_hdr, kernel driver can not
> handle gtp_psc properly, we introduce a new structure to fix this gap between
> kernel driver and struct rte_gtp_psc_generic_hdr.
>
> Fixes: d5eb3e600d9e ("net/iavf: support flow director basic rule")
> Cc: simei.su@intel.com
> Cc: stable@dpdk.com
>
> Signed-off-by: Wenxuan Wu <wenxuanx.wu@intel.com>
>
Tested-by: Zhimin Huang <zhiminx.huang@intel.com >
^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH v2] net/iavf: fix gtpu extension flow error
2022-07-06 2:56 ` [PATCH v2] " wenxuanx.wu
2022-07-07 6:11 ` Huang, ZhiminX
@ 2022-07-07 6:57 ` Yang, Qiming
2022-07-07 7:13 ` Zhang, Qi Z
1 sibling, 1 reply; 8+ messages in thread
From: Yang, Qiming @ 2022-07-07 6:57 UTC (permalink / raw)
To: Wu, WenxuanX, qiz.zhang, Xing, Beilei, dev
Cc: Zhou, YidingX, Su, Simei, stable
Hi,
> -----Original Message-----
> From: Wu, WenxuanX <wenxuanx.wu@intel.com>
> Sent: Wednesday, July 6, 2022 10:56
> To: qiz.zhang@intel.com; Xing, Beilei <beilei.xing@intel.com>; dev@dpdk.org
> Cc: Yang, Qiming <qiming.yang@intel.com>; Zhou, YidingX
> <yidingx.zhou@intel.com>; Wu, WenxuanX <wenxuanx.wu@intel.com>; Su,
> Simei <simei.su@intel.com>; stable@dpdk.com
> Subject: [PATCH v2] net/iavf: fix gtpu extension flow error
>
> From: Wenxuan Wu <wenxuanx.wu@intel.com>
>
> Due to the change of struct rte_gtp_psc_generic_hdr, kernel driver can not
> handle gtp_psc properly, we introduce a new structure to fix this gap between
> kernel driver and struct rte_gtp_psc_generic_hdr.
>
> Fixes: d5eb3e600d9e ("net/iavf: support flow director basic rule")
> Cc: simei.su@intel.com
This line should be delete before patch sent.
> Cc: stable@dpdk.com
>
> Signed-off-by: Wenxuan Wu <wenxuanx.wu@intel.com>
>
> ---
> v2: refine commit log and doc.
> ---
> drivers/net/iavf/iavf_fdir.c | 18 ++++++++++++++++--
> 1 file changed, 16 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/iavf/iavf_fdir.c b/drivers/net/iavf/iavf_fdir.c index
> f236260502..4789d46ab2 100644
> --- a/drivers/net/iavf/iavf_fdir.c
> +++ b/drivers/net/iavf/iavf_fdir.c
> @@ -1300,8 +1300,22 @@ iavf_fdir_parse_pattern(__rte_unused struct
> iavf_adapter *ad,
>
> GTPU_DWN, QFI);
> }
>
> - rte_memcpy(hdr->buffer, gtp_psc_spec,
> - sizeof(*gtp_psc_spec));
> + /*
> + * New structure to fix gap between kernel
> driver and
> + * rte_gtp_psc_generic_hdr.
> + */
> + struct iavf_gtp_psc_spec_hdr {
> + uint8_t len;
> + uint8_t qfi:6;
> + uint8_t type:4;
> + uint8_t next;
> + } psc;
> + psc.len = gtp_psc_spec->hdr.ext_hdr_len;
> + psc.qfi = gtp_psc_spec->hdr.qfi;
> + psc.type = gtp_psc_spec->hdr.type;
> + psc.next = 0;
> + rte_memcpy(hdr->buffer, &psc,
> + sizeof(struct iavf_gtp_psc_spec_hdr));
> }
>
> hdrs->count = ++layer;
> --
> 2.25.1
Acked-by: Qiming Yang <Qiming.yang@intel.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH v2] net/iavf: fix gtpu extension flow error
2022-07-07 6:57 ` Yang, Qiming
@ 2022-07-07 7:13 ` Zhang, Qi Z
2022-07-11 15:18 ` Thomas Monjalon
0 siblings, 1 reply; 8+ messages in thread
From: Zhang, Qi Z @ 2022-07-07 7:13 UTC (permalink / raw)
To: Yang, Qiming, Wu, WenxuanX, qiz.zhang, Xing, Beilei, dev
Cc: Zhou, YidingX, Su, Simei, stable
> -----Original Message-----
> From: Yang, Qiming <qiming.yang@intel.com>
> Sent: Thursday, July 7, 2022 2:58 PM
> To: Wu, WenxuanX <wenxuanx.wu@intel.com>; qiz.zhang@intel.com; Xing,
> Beilei <beilei.xing@intel.com>; dev@dpdk.org
> Cc: Zhou, YidingX <yidingx.zhou@intel.com>; Su, Simei <simei.su@intel.com>;
> stable@dpdk.com
> Subject: RE: [PATCH v2] net/iavf: fix gtpu extension flow error
>
> Hi,
>
> > -----Original Message-----
> > From: Wu, WenxuanX <wenxuanx.wu@intel.com>
> > Sent: Wednesday, July 6, 2022 10:56
> > To: qiz.zhang@intel.com; Xing, Beilei <beilei.xing@intel.com>;
> > dev@dpdk.org
> > Cc: Yang, Qiming <qiming.yang@intel.com>; Zhou, YidingX
> > <yidingx.zhou@intel.com>; Wu, WenxuanX <wenxuanx.wu@intel.com>; Su,
> > Simei <simei.su@intel.com>; stable@dpdk.com
> > Subject: [PATCH v2] net/iavf: fix gtpu extension flow error
> >
> > From: Wenxuan Wu <wenxuanx.wu@intel.com>
> >
> > Due to the change of struct rte_gtp_psc_generic_hdr, kernel driver can
> > not handle gtp_psc properly, we introduce a new structure to fix this
> > gap between kernel driver and struct rte_gtp_psc_generic_hdr.
> >
> > Fixes: d5eb3e600d9e ("net/iavf: support flow director basic rule")
> > Cc: simei.su@intel.com
>
> This line should be delete before patch sent.
>
> > Cc: stable@dpdk.com
> >
> > Signed-off-by: Wenxuan Wu <wenxuanx.wu@intel.com>
> >
> > ---
> > v2: refine commit log and doc.
> > ---
> > drivers/net/iavf/iavf_fdir.c | 18 ++++++++++++++++--
> > 1 file changed, 16 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/net/iavf/iavf_fdir.c
> > b/drivers/net/iavf/iavf_fdir.c index
> > f236260502..4789d46ab2 100644
> > --- a/drivers/net/iavf/iavf_fdir.c
> > +++ b/drivers/net/iavf/iavf_fdir.c
> > @@ -1300,8 +1300,22 @@ iavf_fdir_parse_pattern(__rte_unused struct
> > iavf_adapter *ad,
> >
> > GTPU_DWN, QFI);
> > }
> >
> > - rte_memcpy(hdr->buffer, gtp_psc_spec,
> > - sizeof(*gtp_psc_spec));
> > + /*
> > + * New structure to fix gap between kernel
> > driver and
> > + * rte_gtp_psc_generic_hdr.
> > + */
> > + struct iavf_gtp_psc_spec_hdr {
> > + uint8_t len;
> > + uint8_t qfi:6;
> > + uint8_t type:4;
> > + uint8_t next;
> > + } psc;
> > + psc.len = gtp_psc_spec->hdr.ext_hdr_len;
> > + psc.qfi = gtp_psc_spec->hdr.qfi;
> > + psc.type = gtp_psc_spec->hdr.type;
> > + psc.next = 0;
> > + rte_memcpy(hdr->buffer, &psc,
> > + sizeof(struct iavf_gtp_psc_spec_hdr));
> > }
> >
> > hdrs->count = ++layer;
> > --
> > 2.25.1
>
> Acked-by: Qiming Yang <Qiming.yang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] net/iavf: fix gtpu extension flow error
2022-07-07 7:13 ` Zhang, Qi Z
@ 2022-07-11 15:18 ` Thomas Monjalon
0 siblings, 0 replies; 8+ messages in thread
From: Thomas Monjalon @ 2022-07-11 15:18 UTC (permalink / raw)
To: Yang, Qiming, Wu, WenxuanX, qiz.zhang, Xing, Beilei, dev
Cc: Zhou, YidingX, Su, Simei, stable, Zhang, Qi Z
07/07/2022 09:13, Zhang, Qi Z:
> From: Yang, Qiming <qiming.yang@intel.com>
> > From: Wu, WenxuanX <wenxuanx.wu@intel.com>
> > > From: Wenxuan Wu <wenxuanx.wu@intel.com>
> > >
> > > Due to the change of struct rte_gtp_psc_generic_hdr, kernel driver can
> > > not handle gtp_psc properly, we introduce a new structure to fix this
> > > gap between kernel driver and struct rte_gtp_psc_generic_hdr.
> > >
> > > Fixes: d5eb3e600d9e ("net/iavf: support flow director basic rule")
> > > Cc: simei.su@intel.com
> >
> > This line should be delete before patch sent.
> >
> > > Cc: stable@dpdk.com
it is dpdk.org!
> > >
> > > Signed-off-by: Wenxuan Wu <wenxuanx.wu@intel.com>
> >
> > Acked-by: Qiming Yang <Qiming.yang@intel.com>
no uppercase or double space in emails please
>
> Applied to dpdk-next-net-intel.
>
> Thanks
> Qi
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2] net/iavf: fix gtpu extension flow error
@ 2022-07-06 2:45 wenxuanx.wu
0 siblings, 0 replies; 8+ messages in thread
From: wenxuanx.wu @ 2022-07-06 2:45 UTC (permalink / raw)
To: qiz.zhang, beilei.xing, dev
Cc: qiming.yang, yidingx.zhou, wenxuanx.wu, simei.su, stable
From: Wenxuan Wu <wenxuanx.wu@intel.com>
Due to the change of struct rte_gtp_psc_generic_hdr, kernel driver can
not handle gtp_psc properly, we introduce a new structure to fix this
gap between kernel driver and struct rte_gtp_psc_generic_hdr.
Fixes: d5eb3e600d9e ("net/iavf: support flow director basic rule")
Cc: simei.su@intel.com
Cc: stable@dpdk.com
Signed-off-by: Wenxuan Wu <wenxuanx.wu@intel.com>
---
v2: refine doc.
---
drivers/net/iavf/iavf_fdir.c | 18 ++++++++++++++++--
1 file changed, 16 insertions(+), 2 deletions(-)
diff --git a/drivers/net/iavf/iavf_fdir.c b/drivers/net/iavf/iavf_fdir.c
index f236260502..4789d46ab2 100644
--- a/drivers/net/iavf/iavf_fdir.c
+++ b/drivers/net/iavf/iavf_fdir.c
@@ -1300,8 +1300,22 @@ iavf_fdir_parse_pattern(__rte_unused struct iavf_adapter *ad,
GTPU_DWN, QFI);
}
- rte_memcpy(hdr->buffer, gtp_psc_spec,
- sizeof(*gtp_psc_spec));
+ /*
+ * New structure to fix gap between kernel driver and
+ * rte_gtp_psc_generic_hdr.
+ */
+ struct iavf_gtp_psc_spec_hdr {
+ uint8_t len;
+ uint8_t qfi:6;
+ uint8_t type:4;
+ uint8_t next;
+ } psc;
+ psc.len = gtp_psc_spec->hdr.ext_hdr_len;
+ psc.qfi = gtp_psc_spec->hdr.qfi;
+ psc.type = gtp_psc_spec->hdr.type;
+ psc.next = 0;
+ rte_memcpy(hdr->buffer, &psc,
+ sizeof(struct iavf_gtp_psc_spec_hdr));
}
hdrs->count = ++layer;
--
2.25.1
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-07-11 15:18 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-05 10:09 [PATCH] net/iavf: fix gtpu extension flow error wenxuanx.wu
2022-07-05 11:52 ` Zhang, Qi Z
2022-07-06 2:56 ` [PATCH v2] " wenxuanx.wu
2022-07-07 6:11 ` Huang, ZhiminX
2022-07-07 6:57 ` Yang, Qiming
2022-07-07 7:13 ` Zhang, Qi Z
2022-07-11 15:18 ` Thomas Monjalon
2022-07-06 2:45 wenxuanx.wu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).