From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A1077A0543; Thu, 7 Jul 2022 23:44:55 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4924540A7B; Thu, 7 Jul 2022 23:44:52 +0200 (CEST) Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) by mails.dpdk.org (Postfix) with ESMTP id CAB0B41147 for ; Thu, 7 Jul 2022 23:44:50 +0200 (CEST) Received: by mail-pf1-f177.google.com with SMTP id w185so18192735pfb.4 for ; Thu, 07 Jul 2022 14:44:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=BAigf8C/CVZbo4HkX/NFJCDx0F90Y5sSg2rqXQYXXMI=; b=nkqF3JpRMC2cxGs4dws/svEvllTvP0ih/lVqVgyaPrixrLfMkVM+b6Is3i/jn3STX2 UXpeqylA1OLIxCJUuOYPfiMbc4UQ9ZjRwb3qSVudK9k6jJKyRbZMejf/pdVBAQbwDKT8 dymdzM08SG7cth8vY999oeiq336/Ec2zFroPILRhSPH+lGKnRfpbeXUPuVayUrIJIYCs Fj0K5VkFbuGxE6EMha7wTyjkQUxI6odhiYTzcJDhwVn//L38YZASCellk1JQjtFSzqFo xLQgs0bFYGTob4FwQmZ+ZkqM5uX6TQ759wtffNWRAetGtSLjBSWqHjOamB/aG2CugoAW p5wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=BAigf8C/CVZbo4HkX/NFJCDx0F90Y5sSg2rqXQYXXMI=; b=7MVSnZWgsQPooHlK4UciJEsbmDZKC8e8ioPLSt7nITXzCGKd0LyND2Kt6TJT1jHrG8 Br+dddkvbuNELkpYXoGaMGHuwY24KDSTy1dby4vKXBhR1lCGFV8KXaJAdOr18uSCmRdN /E9s6iy9QqLrMOqUNPz+0PNzvA9y2A654zm2bqToxXmff/AC8tlcR1e/Pg6YXpsnVYiE okJWRVIoiZDrFpMi1pnCOrB7CIdP2MA+4bPQ/GoS8sc4PX+QPCwx3p6QBH3qVC9XDuEp GAOVdVf6FnPxQJSK4kVu0ewk5RVw/dD0LrFipgLQVusvNS5T0ydPD6DPpHPfMGBuMvR/ 6JMw== X-Gm-Message-State: AJIora8VfgqYlIX5vV/zw3tZON6dU0BSuTVmrKRp7tLZuzPwUzQNGrSk iHETOY/r6TNJvv7WrZs5eDagtg== X-Google-Smtp-Source: AGRyM1uMlpi6twRF2XncwYx2nE0WC9+lmuVNjBp3TxsVJG6w/e2JM0uBKdQZAVcpFcyU3IlnVC7aBg== X-Received: by 2002:a05:6a00:811:b0:525:50c2:4c2f with SMTP id m17-20020a056a00081100b0052550c24c2fmr298557pfk.62.1657230289965; Thu, 07 Jul 2022 14:44:49 -0700 (PDT) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id i10-20020a056a00224a00b00528baea5dacsm1993852pfu.201.2022.07.07.14.44.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Jul 2022 14:44:49 -0700 (PDT) Date: Thu, 7 Jul 2022 14:44:47 -0700 From: Stephen Hemminger To: longli@linuxonhyperv.com Cc: longli@microsoft.com, Ferruh Yigit , dev@dpdk.org, Ajay Sharma , Stephen Hemminger Subject: Re: [Patch v3 01/17] net/mana: add basic driver, build environment and doc Message-ID: <20220707144447.4bfd02e4@hermes.local> In-Reply-To: <1657225822-3512-2-git-send-email-longli@linuxonhyperv.com> References: <1657225822-3512-1-git-send-email-longli@linuxonhyperv.com> <1657225822-3512-2-git-send-email-longli@linuxonhyperv.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 7 Jul 2022 13:30:06 -0700 longli@linuxonhyperv.com wrote: > + file = fopen(path, "rb"); Minor nit, if you make any later changes. "rb" is same as "r" on Linux. b means binary, and this is actually a text file.