From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 21786A0543; Thu, 7 Jul 2022 23:50:58 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 029904069D; Thu, 7 Jul 2022 23:50:58 +0200 (CEST) Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) by mails.dpdk.org (Postfix) with ESMTP id 6024940041 for ; Thu, 7 Jul 2022 23:50:56 +0200 (CEST) Received: by mail-pg1-f177.google.com with SMTP id z14so20838519pgh.0 for ; Thu, 07 Jul 2022 14:50:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8YkcJA4W13Xkf9EmArwDVRdvZr8tFAb7GFDhyzyDC9A=; b=YCNTkbcdLJ2RWQhGFmbFmsZlGtm5ikEyLvnK/ucpJZeFGcugmSAuvOqnXMEcDD64AQ N3bEfKwkA8zWo6jE9Be2c92/Uiae3j1zOTN5BBe5DXUQSuavqX9zI2x2zK+n2D3jHbRV /RVAO5GMg7xRqufdmUl2j+RloMybNoDaiJjqS1AhJd4Po72caO5fMlqAnafkKtv1NONb urCiY4k82+kzRoeY12sS9UI8+OgFr/WIYLFY1JN/tf6mtbQjVRXBMpnGF6Cyddb5RT/S rf04hwgcNmoA1iHQsGorrUzuenHA61tUaadyRyykvcwoIFmRMw/jBBsVR1p+gMW/txzj /bmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8YkcJA4W13Xkf9EmArwDVRdvZr8tFAb7GFDhyzyDC9A=; b=7WUc9A4BX5mcwMLC+ABVdkPujXlJ3kHkWy1lMwpN3YX/ThoBO1hKsK/XpqcaNeDgax BwHpKxwayLYx0lvwVY7kl+dVsFZyzzs8jsvmms8n/tg8b/qxowVuQIoIkVZ5MWaDzJVV 2RKeNhWUeWPgIdVgsb+k4kbKyjccb+5dn/TMkXrcVDvc469tvNBR4WBfbHmsGksA5W76 CmEzkhPcNdsWnb0e7uxf3PN0FLiJIKnlTsojrZ60i6Xj9QVV5tG5rgTx+9t3WPugSeAb TNfVSKVaaV5szf/s8hLl4HaZ1kxRjLi6g0zzryUGZi5tcy8pEQpuNHHCHBNqciJb246B MG8Q== X-Gm-Message-State: AJIora/WgQwX3yQM65qs+a2cWabmtB66fPg5krSs+qwjSDyt26qlJjQn mEbExa1I4ebxw/RbbiGAqzI6lA== X-Google-Smtp-Source: AGRyM1sJTjFm8GMYLDnQJXwskUQDqzDfyVZqWCysaCknJmrtXP6yVLYoi5fxLYrCoYq401RfOLhPbA== X-Received: by 2002:a65:498b:0:b0:412:8e4:2842 with SMTP id r11-20020a65498b000000b0041208e42842mr182821pgs.71.1657230655582; Thu, 07 Jul 2022 14:50:55 -0700 (PDT) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id h13-20020a17090a130d00b001efa9e83927sm28688pja.51.2022.07.07.14.50.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Jul 2022 14:50:55 -0700 (PDT) Date: Thu, 7 Jul 2022 14:50:52 -0700 From: Stephen Hemminger To: longli@linuxonhyperv.com Cc: longli@microsoft.com, Ferruh Yigit , dev@dpdk.org, Ajay Sharma , Stephen Hemminger Subject: Re: [Patch v3 10/17] net/mana: implement memory registration Message-ID: <20220707145052.3917144a@hermes.local> In-Reply-To: <1657225822-3512-11-git-send-email-longli@linuxonhyperv.com> References: <1657225822-3512-1-git-send-email-longli@linuxonhyperv.com> <1657225822-3512-11-git-send-email-longli@linuxonhyperv.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 7 Jul 2022 13:30:15 -0700 longli@linuxonhyperv.com wrote: > +int mana_new_pmd_mr(struct mana_mr_btree *local_tree, struct mana_priv *priv, > + struct rte_mempool *pool) > +{ > + struct ibv_mr *ibv_mr; > + struct mana_range ranges[pool->nb_mem_chunks]; > + uint32_t i; > + struct mana_mr_cache *mr; > + int ret; > + > + rte_mempool_mem_iter(pool, mana_mempool_chunk_cb, ranges); > + > + for (i = 0; i < pool->nb_mem_chunks; i++) { > + if (ranges[i].len > priv->max_mr_size) { > + DRV_LOG(ERR, "memory chunk size %u exceeding max MR\n", > + ranges[i].len); > + return -ENOMEM; Did a quick search for extra newlines. Looks like this message will end up double spaced in log. DRV_LOG already adds a newline.