From: Stephen Hemminger <stephen@networkplumber.org>
To: Huichao Cai <chcchc88@163.com>
Cc: dev@dpdk.org, konstantin.v.ananyev@yandex.ru
Subject: Re: [PATCH v6] ip_frag: add IPv4 fragment copy packet API
Date: Mon, 25 Jul 2022 08:42:06 -0700 [thread overview]
Message-ID: <20220725084206.37cdbcac@hermes.local> (raw)
In-Reply-To: <1658650203-7831-1-git-send-email-chcchc88@163.com>
On Sun, 24 Jul 2022 16:10:03 +0800
Huichao Cai <chcchc88@163.com> wrote:
> +
> + /*
> + * Formal parameter checking.
> + */
> + if (unlikely(pkt_in == NULL) || unlikely(pkts_out == NULL) ||
> + unlikely(nb_pkts_out == 0) || unlikely(pool_direct == NULL) ||
> + unlikely(mtu_size < RTE_ETHER_MIN_MTU))
> + return -EINVAL;
> +
> + in_hdr = rte_pktmbuf_mtod(pkt_in, struct rte_ipv4_hdr *);
> + header_len = (in_hdr->version_ihl & RTE_IPV4_HDR_IHL_MASK) *
> + RTE_IPV4_IHL_MULTIPLIER;
> +
> + /* Check IP header length */
> + if (unlikely(pkt_in->data_len < header_len) ||
> + unlikely(mtu_size < header_len))
> + return -EINVAL;
> +
My suspicions are all this input parameter checking probably costs more
than any performance gain of having a non-segmented fast path.
next prev parent reply other threads:[~2022-07-25 15:42 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-09 2:39 [PATCH v1] " Huichao Cai
2022-06-09 14:19 ` [PATCH v2] " Huichao Cai
2022-07-10 23:35 ` Konstantin Ananyev
2022-07-11 9:14 ` Konstantin Ananyev
2022-07-15 8:05 ` Huichao Cai
2022-07-19 8:19 ` Konstantin Ananyev
2022-07-22 13:01 ` [PATCH v3] " Huichao Cai
2022-07-22 14:42 ` Morten Brørup
2022-07-22 14:49 ` Stephen Hemminger
2022-07-22 15:52 ` Morten Brørup
2022-07-22 15:58 ` Huichao Cai
2022-07-22 16:14 ` Morten Brørup
2022-07-22 22:35 ` Konstantin Ananyev
2022-07-23 8:24 ` Morten Brørup
2022-07-23 18:25 ` Konstantin Ananyev
2022-07-23 22:27 ` Morten Brørup
2022-07-22 14:49 ` [PATCH v4] " Huichao Cai
2022-07-24 4:50 ` [PATCH v5] " Huichao Cai
2022-07-24 8:10 ` [PATCH v6] " Huichao Cai
2022-07-25 15:42 ` Stephen Hemminger [this message]
2022-07-26 1:22 ` Huichao Cai
2022-08-07 11:49 ` Konstantin Ananyev
2022-08-07 11:45 ` Konstantin Ananyev
2022-08-08 1:48 ` [PATCH v7] " Huichao Cai
2022-08-08 22:29 ` Konstantin Ananyev
2022-08-29 14:22 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220725084206.37cdbcac@hermes.local \
--to=stephen@networkplumber.org \
--cc=chcchc88@163.com \
--cc=dev@dpdk.org \
--cc=konstantin.v.ananyev@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).