From: Stephen Hemminger <stephen@networkplumber.org>
To: Gerry Gribbon <ggribbon@nvidia.com>
Cc: <dev@dpdk.org>, Ori Kam <orika@nvidia.com>
Subject: Re: [RFC] regexdev: add maximum number of mbuf segments field
Date: Tue, 26 Jul 2022 08:16:41 -0700 [thread overview]
Message-ID: <20220726081641.0a83cc77@hermes.local> (raw)
In-Reply-To: <20220726104707.639878-1-ggribbon@nvidia.com>
On Tue, 26 Jul 2022 10:47:07 +0000
Gerry Gribbon <ggribbon@nvidia.com> wrote:
> diff --git a/lib/regexdev/rte_regexdev.h b/lib/regexdev/rte_regexdev.h
> index 3bce8090f6..7d2e1ee1d0 100644
> --- a/lib/regexdev/rte_regexdev.h
> +++ b/lib/regexdev/rte_regexdev.h
> @@ -622,6 +622,8 @@ struct rte_regexdev_info {
> /**< Supported compiler rule flags.
> * @see RTE_REGEX_PCRE_RULE_*, struct rte_regexdev_rule::rule_flags
> */
> + uint16_t max_num_mbuf_segs;
> + /**< Maximum number of mbuf segments that can be chained together. */
> };
>
> /**
Did you notice that that struct is sparse and there is already
an existing hole that could be reused. This is going to be an API/ABI
breakage already so reusing the hole will be ok.
Also, please update the release notes for this.
prev parent reply other threads:[~2022-07-26 15:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-26 10:47 Gerry Gribbon
2022-07-26 15:16 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220726081641.0a83cc77@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=ggribbon@nvidia.com \
--cc=orika@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).