From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 38D03A00C4; Fri, 29 Jul 2022 17:58:56 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BAE294069C; Fri, 29 Jul 2022 17:58:55 +0200 (CEST) Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) by mails.dpdk.org (Postfix) with ESMTP id 3F3A840151 for ; Fri, 29 Jul 2022 17:58:55 +0200 (CEST) Received: by mail-pf1-f182.google.com with SMTP id g12so5002220pfb.3 for ; Fri, 29 Jul 2022 08:58:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=eDwYgT0SPg/B0ZnCKoiEhuFCOmVnkDKD1GczAMtyw4g=; b=70d5rdF/Xzkz1xwC2imTa3BynNPcrDd4SSusCRnwYH+IqNLpHJwLwPU/47BKXvL/B0 S1QrJzNxvyITe52TOg89IwTNXi208U09s5q9ckAjb2YKi48SAs7V7nCu9pq+Ezfn2YG/ pcl5qwFgCUuC08UawbLxOloNFaQgmXVfqeReONpfZpfTgqDsLwOsi9TgMw94LzH5KcJc wkxnrJzOzH1lEJYw5rVdrZfCnfxi5UMTuq6jYiUej6VqM3kO3zlkoS6y2TEHxToYgmci dKHVV2baGNtRhobsZZzJctZZOdXLAAlCelBhNpTF68kwlq4kvWaH25fnHtAQ60y69G6h KQkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=eDwYgT0SPg/B0ZnCKoiEhuFCOmVnkDKD1GczAMtyw4g=; b=fhQTtg+FyOIA9i8sv9XsaYTegHDy5rJdTUPTqnyyh6Wq4TXTX1rhhi8lbsooKg0PYC PGnGkMIcpEXjkHPwMpJDaOZzsh9ZSFb3ZJLosYmBatw1nRUBFTELAFsUUugxWGgSle2Y u5A9G8NJdKMR9mZK/JGCOyBX2t22PW/joUXqxDX8DKVUmR5OlFvkNO3TBPPjpq3GtpjB TWa/S9HW3EiJasBLj56EbjQk6C6KOrTvmQqMCm8q00pmRhIh/Ct+09sfDu4xD42MHrSb LGT7SVYzX5VIZeN2nQn3J94ahWcog6ewxmTrAHy2/sUTDtjmLd3cm+PvgA1iTgQfO+iA pRAg== X-Gm-Message-State: AJIora82mgLt5I5AdNZ5sqMqjBOY4sfGc82AdcYrVZph/LunNH51rVN2 ffBabZqBuTqbyJHGfvPWvlYzxQ== X-Google-Smtp-Source: AGRyM1ufc3VLNbhJLtjU7DTGGxMlmVmDHCbhWDhx0ItcXBJ8+iRWBSNyeAwg40mvbBNmmq4muFZaqg== X-Received: by 2002:a65:6bc8:0:b0:412:9b2c:1700 with SMTP id e8-20020a656bc8000000b004129b2c1700mr3477124pgw.8.1659110334256; Fri, 29 Jul 2022 08:58:54 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id f3-20020a170902ce8300b0016e2309bcf1sm1025846plg.13.2022.07.29.08.58.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Jul 2022 08:58:53 -0700 (PDT) Date: Fri, 29 Jul 2022 08:58:50 -0700 From: Stephen Hemminger To: =?UTF-8?B?TcOhcmlv?= Kuka Cc: dev@dpdk.org, mdr@ashroe.eu, reshma.pattan@intel.com Subject: Re: [PATCH v2 0/2] pcapng: fix some issues with writing packets. Message-ID: <20220729085850.170d1e03@hermes.local> In-Reply-To: <20220729071841.18198-1-kuka@cesnet.cz> References: <20220725152811.409447-1-kuka@cesnet.cz> <20220729071841.18198-1-kuka@cesnet.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 29 Jul 2022 09:18:39 +0200 M=C3=A1rio Kuka wrote: > This patchset contains fixes for some issues that occur when writing a=20 > large burst of packets at once, such as writing more packets than the > IOV_MAX limit and the problem of partial writing of a packet to a file=20 > if the writev() system call performs a partial write. >=20 > The typical use of pcapng in our cases is to copy the packets into a=20 > separate buffer and the process of writing to the file is done in some > slow path, for example by writing in a separate thread or at the end of > the application, where we don't mind the limitation of the typically=20 > slow speed of the storage medium. >=20 > M=C3=A1rio Kuka (2): > pcapng: fix write more packets than IOV_MAX limit > pcapng: check if writev() returns a partial write >=20 > app/test/test_pcapng.c | 42 +++++++++++++++++- > lib/pcapng/rte_pcapng.c | 96 +++++++++++++++++++++++++++++++++-------- > 2 files changed, 120 insertions(+), 18 deletions(-) >=20 You ignored my feedback from earlier patch. It seems you are adding a lot more here that is necessary.