From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D55D8A0545; Wed, 10 Aug 2022 15:50:03 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 875FE4068E; Wed, 10 Aug 2022 15:50:03 +0200 (CEST) Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) by mails.dpdk.org (Postfix) with ESMTP id C86A84067C for ; Wed, 10 Aug 2022 15:50:02 +0200 (CEST) Received: by mail-pf1-f169.google.com with SMTP id f30so13393506pfq.4 for ; Wed, 10 Aug 2022 06:50:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc; bh=tSGsoN47DkRWm2bPoD34edrMmf6aib2OrgQR4SaSuyI=; b=i43CelQYM2htYBN9pNf/UisTZws3Ue/i4BA3qjtQBzBP8Fval3W956vFfuxgGFyvF1 JlVFsDciwdGEuJjvAWNiyA4ZDWhhZmnAHItIRcLON9uaAxRqK1hAZTVNtBQGFSyaYCFv TNFR1yGsy9BbKbjg+aRVsyQFr03HZUQxTa44ZXkOVsVj+/y5q4YUUugWjqSxRZjF9M/9 DZImqtsdZYIKk6cH+Z5qiWUBpZU0P+s40A4Ojeo8gbkEGa02FW1kYSXlrbkpXDpIk3d/ VBpfnesU0a/L870+o/EPUkDBHzV93Ls+9UxrSJPIHvQMEVwCZfxVKXWLAwUYZdUZFNLi Drxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=tSGsoN47DkRWm2bPoD34edrMmf6aib2OrgQR4SaSuyI=; b=PSuokpipV8RKXaZl1q6do4pWqX852SBesXZxOZyYug6lHSgEUMPrlfkgfMinj6yvGe stnlqhGlpW+YKyUdwPJKW/H5Z2LvoygvfVcF/f2JcXvA1MxB5j18OlSEl5NuMR8VpC9c WQ5ed+9GmGoJu19tsM1NhGjaMeAH//wrr5TqyatiXtqVqoI50Yv6qpP6lSYbLkBhMVeI 2gqxfKC+HAaDDlNoh5rFwj7XUvtIPM3x3UTK+H+BS69iDHjLDOJJVM6g6iftH4yrr8OW jT/+53Hrw2FKEQ1NbSUPiJyuUmkyST+2qKa8nDqqNmvs9MgtutfzAUa+zsG5dF/Wj8uR zQ+Q== X-Gm-Message-State: ACgBeo1RAPp1+mWtfiY04dCjOLe62Ajn2YKdYTi3AgEkEMjyE5e0PrcF 2sbZWnhfRhfV+dluy6KdBUeixg== X-Google-Smtp-Source: AA6agR6i4pNrOT1oY64Z5wBru1fZCYMYAsIQgFzsTbXi4uqVhVtN0CqHz1QKDtfvV3f+dmVcR/mpuQ== X-Received: by 2002:a65:6d98:0:b0:41d:d9:a338 with SMTP id bc24-20020a656d98000000b0041d00d9a338mr20209635pgb.421.1660139401824; Wed, 10 Aug 2022 06:50:01 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id d6-20020a170902654600b0016a3f9e4865sm12951619pln.148.2022.08.10.06.50.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Aug 2022 06:50:01 -0700 (PDT) Date: Wed, 10 Aug 2022 06:49:59 -0700 From: Stephen Hemminger To: Krzysztof Kozlowski Cc: "lihuisong (C)" , dev@dpdk.org, andrew.rybchenko@oktetlabs.ru, thomas@monjalon.net, ferruh.yigit@xilinx.com, huangdaode@huawei.com, liudongdong3@huawei.com Subject: Re: [PATCH] usertools: fix bind failure from dpdk to kernel Message-ID: <20220810064959.008fdb01@hermes.local> In-Reply-To: References: <20220805031022.9795-1-lihuisong@huawei.com> <20220805083529.5ca3233e@hermes.local> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 10 Aug 2022 08:59:15 +0300 Krzysztof Kozlowski wrote: > On 09/08/2022 14:44, lihuisong (C) wrote: > >=20 > > =E5=9C=A8 2022/8/5 23:35, Stephen Hemminger =E5=86=99=E9=81=93: =20 > >> On Fri, 5 Aug 2022 11:10:22 +0800 > >> Huisong Li wrote: > >> =20 > >>> Currently, the steps for binding device from dpdk driver to kernel > >>> driver is as follows: > >>> echo $BDF > /sys/bus/pci/drivers/vfio-pci/unbind > >>> echo $BDF > /sys/bus/pci/drivers/$kernel_driver/bind > >>> > >>> This steps cannot bind device from dpdk driver to kernel driver on > >>> platform with kernel 5.19. The 'driver_override' must be specify > >>> kernel driver before binding device to kernel driver. > >>> > >>> Fixes: 720b7a058260 ("usertools: fix device binding with kernel tools= ") > >>> Cc: stable@dpdk.org > >>> > >>> Signed-off-by: Huisong Li =20 > >> Not sure exactly what you did and why. > >> The patch seems to just remove the check that the driver > >> is in the set of dpdk_drivers. > >> . =20 > > Currently, the end of the operation binding device from kernel driver to > > dpdk driver write '\00' to driver_override file so as to this device can > > be bound to any other driver. =20 >=20 > This could have work but this was not the way to use the > driver_override. The kernel ABI document clearly states: > "and may be cleared with an empty string (echo > driver_override)." > Documentation/ABI/testing/sysfs-bus-pci >=20 > Please use the kernel ABI how it is described. Using it in wrong way > might sometimes work, sometimes not. No, the kernel ABI is what ever worked before. The documentation is not the definitive standard.