From: Stephen Hemminger <stephen@networkplumber.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: "lihuisong (C)" <lihuisong@huawei.com>,
dev@dpdk.org, andrew.rybchenko@oktetlabs.ru, thomas@monjalon.net,
ferruh.yigit@xilinx.com, huangdaode@huawei.com,
liudongdong3@huawei.com
Subject: Re: [PATCH] usertools: fix bind failure from dpdk to kernel
Date: Wed, 10 Aug 2022 06:50:30 -0700 [thread overview]
Message-ID: <20220810065030.687e0e31@hermes.local> (raw)
In-Reply-To: <d4583c17-1b31-b27e-8537-aa30759f3c4a@linaro.org>
On Wed, 10 Aug 2022 09:02:57 +0300
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
> On 09/08/2022 20:58, Stephen Hemminger wrote:
> >>
> >> However, due to the patch[1] merged into 5.19 kernel, 'driver_override'
> >> in the pci_dev is no longer NULL by writing '\00' to driver_override file.
> >> This causes PCI match device failure and the device will never be bound to
> >> their kernel driver.
> >
> >
> > Linux kernel does not look favorably on API changes and that looks like
> > the kernel changed behavior. That should be reported and fixed there.
>
> To clarify around this issue:
>
> There were no API changes. Linux kernel follows the API exactly how it
> is described in the API document since 2014:
> Documentation/ABI/testing/sysfs-bus-pci
>
> There was no change in kernel API.
>
> There was a change in undocumented, unsupported and wrong usage of
> driver_override API.
>
> Best regards,
> Krzysztof
Linux documentation is not the standard, the code is.
next prev parent reply other threads:[~2022-08-10 13:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-05 3:10 Huisong Li
2022-08-05 15:35 ` Stephen Hemminger
2022-08-09 11:44 ` lihuisong (C)
2022-08-09 17:58 ` Stephen Hemminger
2022-08-10 6:02 ` Krzysztof Kozlowski
2022-08-10 13:50 ` Stephen Hemminger [this message]
2022-08-10 5:59 ` Krzysztof Kozlowski
2022-08-10 13:49 ` Stephen Hemminger
2022-08-11 2:10 ` lihuisong (C)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220810065030.687e0e31@hermes.local \
--to=stephen@networkplumber.org \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@xilinx.com \
--cc=huangdaode@huawei.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lihuisong@huawei.com \
--cc=liudongdong3@huawei.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).