From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A5DA8A00C2; Mon, 22 Aug 2022 10:32:57 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 09AB942B8A; Mon, 22 Aug 2022 10:32:39 +0200 (CEST) Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) by mails.dpdk.org (Postfix) with ESMTP id 2D58F410FA for ; Mon, 22 Aug 2022 00:12:23 +0200 (CEST) Received: by mail-pf1-f178.google.com with SMTP id y141so8709614pfb.7 for ; Sun, 21 Aug 2022 15:12:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alkira-net.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc; bh=62V9H5/vwngnmuyDkLvkrDSaRGkTc++Cw/6w2qt596A=; b=aJVRHvvEBtJO6r1wGCcKy1eAYoEyx+tOk1BEJzmg+tI3VqYiNxYiFNwCydcXUSzGRq ZaUJW7vMpOKAYuy1LU10rwCt9Ltt3Ca3OuwVaXZC2UzxlgHv4LM0Q8pTFgw94bLAl9G2 vD9C6hP4gTDTjYeEPiM59M/NxJIleAiJUpqYJq3YFABz99/nLRLa4DNfcV4jiKqxOPGK bpyked3dhHsCzIOpCy/TG6JErjbXFtai3tgEnWX7KweO6f27vl2pB2gZQHOK/o2rb0+8 jdDokNjv1+ALA1E/T3AcK+8rwiSB0hz0yTJqp8Ig1R/Bt/9vDHH+iNaCqFt6NuVB0dzu CbcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc; bh=62V9H5/vwngnmuyDkLvkrDSaRGkTc++Cw/6w2qt596A=; b=W3gZ93/POv2f4hJv4kCjHR/czmdqQPf0ZkD7WW2JXObGqJEiSdVjVJrqG5J1vYnPv1 8kNU9HJXl7NuWmxzsLQztmyH4brVHQPN+GuhhLpBDVtyZVwDvd2pXbX1JYDDdgweLGWI uVO2VEi3qMwiESPEg1hC2PhTkjjWTJrR+Wm5FfopHINu6vYDAIeunO3iTR1WbWdUuJ90 OBOoSf4NwneD/czwM0cSbE0hSeBJnLE9VCyM+uR9I0a0A6CatzSFGconB9PXD62Hq6wF fYTbwuJko4rAhEzABcgmkiIQgipDn95+Z9A0klzTK8eS4Bnr916sy8dZP+8Wir/J0vxB Js0A== X-Gm-Message-State: ACgBeo19G2FODylEQ5waGYzdCVFv5leB7GnbP2R+cGDC5J/ziZaQ29Y8 jZ9qwzv5DCX8eKAxGHcmZzFYiktIGDtoLXYM X-Google-Smtp-Source: AA6agR55Zq33HWey2PstliJ7RBHN2B2/DpRHi9vbNGDDqvy4FEk2j5ZgGCBUv8qSzqxtjeBAb9hJ8A== X-Received: by 2002:a63:205e:0:b0:42a:98c6:182a with SMTP id r30-20020a63205e000000b0042a98c6182amr4164758pgm.482.1661119942079; Sun, 21 Aug 2022 15:12:22 -0700 (PDT) Received: from ip-10-30-0-101.us-west-2.compute.internal (ec2-35-160-186-240.us-west-2.compute.amazonaws.com. [35.160.186.240]) by smtp.gmail.com with ESMTPSA id n4-20020a170903110400b001714e7608fdsm6921100plh.256.2022.08.21.15.12.21 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Aug 2022 15:12:21 -0700 (PDT) From: Shinae Woo To: dev@dpdk.org Subject: [PATCH] linux/igb_uio: make module parameters visible in sysfs Date: Sun, 21 Aug 2022 15:12:13 -0700 Message-Id: <20220821221213.9591-1-shinae@alkira.net> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Mailman-Approved-At: Mon, 22 Aug 2022 10:32:34 +0200 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org - explicitly set default value for intr_mode - give read permission on wc_activate - applying patch gives below visibility ``` $ more /sys/module/igb_uio/parameters/* | cat :::::::::::::: /sys/module/igb_uio/parameters/intr_mode :::::::::::::: msix :::::::::::::: /sys/module/igb_uio/parameters/wc_activate :::::::::::::: 0 ``` Signed-off-by: Shinae Woo --- linux/igb_uio/igb_uio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/linux/igb_uio/igb_uio.c b/linux/igb_uio/igb_uio.c index 33e0e02..c927ae6 100644 --- a/linux/igb_uio/igb_uio.c +++ b/linux/igb_uio/igb_uio.c @@ -44,7 +44,7 @@ struct rte_uio_pci_dev { }; static int wc_activate; -static char *intr_mode; +static char *intr_mode = RTE_INTR_MODE_MSIX_NAME; static enum rte_intr_mode igbuio_intr_mode_preferred = RTE_INTR_MODE_MSIX; /* sriov sysfs */ static ssize_t @@ -663,7 +663,7 @@ MODULE_PARM_DESC(intr_mode, " " RTE_INTR_MODE_LEGACY_NAME " Use Legacy interrupt\n" "\n"); -module_param(wc_activate, int, 0); +module_param(wc_activate, int, S_IRUGO); MODULE_PARM_DESC(wc_activate, "Activate support for write combining (WC) (default=0)\n" " 0 - disable\n" -- 2.20.1