From: Fidaullah Noonari <fidaullah.noonari@emumba.com>
To: stephen@networkplumber.org
Cc: dev@dpdk.org, Fidaullah Noonari <fidaullah.noonari@emumba.com>
Subject: [PATCH v2] app/proc-info: add rte_eal_cleanup() to avoid memory leak
Date: Sun, 4 Sep 2022 17:28:45 +0500 [thread overview]
Message-ID: <20220904122845.141893-1-fidaullah.noonari@emumba.com> (raw)
when app is launched with -m proc-info exit without
rte_eal_cleanup() causing memory leakage. This commit resolves the
memory leakage issue and closes app properly.
Bugzilla id: 898
Signed-off-by: Fidaullah Noonari <fidaullah.noonari@emumba.com>
---
app/proc-info/main.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/app/proc-info/main.c b/app/proc-info/main.c
index 1bfba5f60d..9cfcce31ab 100644
--- a/app/proc-info/main.c
+++ b/app/proc-info/main.c
@@ -1523,7 +1523,7 @@ main(int argc, char **argv)
if (mem_info) {
meminfo_display();
- return 0;
+ goto cleanup;
}
nb_ports = rte_eth_dev_count_avail();
@@ -1593,6 +1593,7 @@ main(int argc, char **argv)
RTE_ETH_FOREACH_DEV(i)
rte_eth_dev_close(i);
+cleanup:
ret = rte_eal_cleanup();
if (ret)
printf("Error from rte_eal_cleanup(), %d\n", ret);
--
2.25.1
next reply other threads:[~2022-09-04 12:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-04 12:28 Fidaullah Noonari [this message]
2023-07-16 17:46 ` Stephen Hemminger
2024-10-04 2:48 ` [PATCH v3] " Stephen Hemminger
2024-10-09 1:22 ` fengchengwen
2024-11-19 20:51 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220904122845.141893-1-fidaullah.noonari@emumba.com \
--to=fidaullah.noonari@emumba.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).