From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C2CC5A0548; Thu, 8 Sep 2022 14:42:37 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6752B4021F; Thu, 8 Sep 2022 14:42:37 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2062.outbound.protection.outlook.com [40.107.220.62]) by mails.dpdk.org (Postfix) with ESMTP id B864340143; Thu, 8 Sep 2022 14:42:35 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TMxxfDUY4rIOvCvgc+MArQWZlUQc67F3SNaYvh6mDDAV101A0YdG/jNa7wxPrrSCpkTxLrpMajk0pJy7vPIXQOHuBCNsuvtNuDj3Jtbnl0urWhXb0EarLUiaZb4sgzk06NNkGWuGQBP3em/X5gWNcFnz6exKwxejHMRpg3cAGA8qAv4LZWH7c1J9ZalIC9hNrLGzoq824m/WCP4PKAYxHKygQoKuZcdKGvLMsw5d80MII0C8ggTf4byFIW2xTb49yMiID1fUCGv1DSPXCip+pfOftT6wGiceQY8KehHGWoyIki2hUgw0Xks/3ZkhLY6f3/ffg2mwnYeP2/jnGBqhAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1NP3MsmG5oUTW0dyi9/iGB/lSWHddF3w82m+ZzwW/vs=; b=DcMl5Za5nTU8AkpbEiNRx0/aooXrY7V+TGKBK3MGGCktCG9heJ4nHpxrY13sEssM5psJbo0dJ2TDhWnIMAD9CrzkByNP5/hj3uWMmsfN3BrtkWmhQIEP7v+A/QjR3sgSgOX5sQwosg5bHGqcv8Ci3u1amcKSor2ebPJnM/4xNJTPC/uM/q7IY+D75f04kNPj8t+gIbVrvNSLODo5UHeVGnlQmoxju5NMiruEsRRXRzSayT/q5PWWcX6Y1r0lLlgDz1pt02HoYt6YXybbRa5dF4E1NjThuMu24YtpdH/TIbgx70YqfMeqnjAcu3NiFNWY+NRldXT/1F3xwOYmxCd4fQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=dpdk.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1NP3MsmG5oUTW0dyi9/iGB/lSWHddF3w82m+ZzwW/vs=; b=K0nRYzVpHPGsWWd9/+w9epgNdgLeThDNtBuwKZDHmchL05O58Kt5T+K3D/XSio/D24pCOu0gI98snFCI+4VcLgSEry8PridMiWg/dOVwLD8I/QN86tSQyGPfYUBUYsfAPDfLKlA1Bh+mWxN+KWoN2YJiBNsO19N12dSGzkzRJKM= Received: from DM6PR07CA0066.namprd07.prod.outlook.com (2603:10b6:5:74::43) by SA0PR12MB4365.namprd12.prod.outlook.com (2603:10b6:806:96::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14; Thu, 8 Sep 2022 12:42:33 +0000 Received: from DM6NAM11FT072.eop-nam11.prod.protection.outlook.com (2603:10b6:5:74:cafe::72) by DM6PR07CA0066.outlook.office365.com (2603:10b6:5:74::43) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14 via Frontend Transport; Thu, 8 Sep 2022 12:42:33 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT072.mail.protection.outlook.com (10.13.173.181) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5612.13 via Frontend Transport; Thu, 8 Sep 2022 12:42:33 +0000 Received: from cae-Selwin.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Thu, 8 Sep 2022 07:42:30 -0500 From: Bhagyada Modali To: , CC: , , Bhagyada Modali Subject: [PATCH] net/axgbe: remove freeing buffer in scattered rx Date: Thu, 8 Sep 2022 08:42:15 -0400 Message-ID: <20220908124215.2976-1-bhagyada.modali@amd.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT072:EE_|SA0PR12MB4365:EE_ X-MS-Office365-Filtering-Correlation-Id: cd48b44c-00f9-4b66-507c-08da919799e5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ++1EDkr3jz8SJfrRvrhrYVHY15XwUMqc0HIaYyI7OzcyyUuA86tPmSDxI6pFev59SfaP/HxeKwbyUlxTJOtfY8PZ8aGTqEG0Sms20kkEnAcTAWGFoVD0+JKGDo0HISmdCWB3NbyisLRBzl4OOtcvi41mFoecYKOHXnVgcarHyfU5JSYWDq5fG4s0djcUgiMYbeDTA9J8HNNyiWcxoB36lMXTedaeuQZNYLDij8NFfxWG6DqqdpJTeuz5fRUmnRfFGo6tx2+2yJNDYOPUX0o6CwYIyQ0IIqNmCkAp1M6gsh/4OWZgx5vmBRoRsMBOU+ha2FM2k3No9rpcijb4B2DhUG7EZbTFyfMDxFXkKOLf/mIw4tOMMHgNm40qnqsg8hhlbmL0/Cl5NqxT59/UnpGNAY3vBjrkiHz/dE2QK5Coavm9rAoRA7gq8uZDKNzK1HAFMj9VWYlHcx0795+PI/BzwIotjXWUOqIZA/rHGXuj26aacVGB+jyqvqHvJki1PHyDw+vbvm6zQbhBK0vt+HnhCCVyS8NQswdJ8DPO66OYF9Hw9QmAkz/L5AKV5nx3WcW07t39cl1Mwmp+dR0wgFhZNB1N1ZsE6OWC+n81mt0MOB1GM46qv498D/1OeDD/RQiWfSJdr4cp+uRuREG0bSFUneBUVYEkqSVkmGDmG7qrqckwcOXdRSe3WebXIxa9O6a/ruRne6zFrTpEPlhPDxr52bT96cpYUF6jGOpPhc8kZUDAjMtH5r/XCFf5yfNDkkEx7KchkiMeM42AxNWr+m1nZrfvVIRRVamc+iSx5wVfC1enxQyaRsXBvhpV7ULBmxcHSJcUi9XudrOhls/Ny2hpoA== X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230016)(4636009)(136003)(346002)(39860400002)(376002)(396003)(36840700001)(40470700004)(46966006)(2616005)(82310400005)(6636002)(36756003)(54906003)(110136005)(36860700001)(186003)(1076003)(316002)(16526019)(82740400003)(40480700001)(336012)(356005)(81166007)(450100002)(478600001)(26005)(47076005)(70206006)(70586007)(8676002)(426003)(4326008)(2906002)(86362001)(40460700003)(7696005)(44832011)(5660300002)(41300700001)(8936002)(4744005)(6666004)(83380400001)(83323001)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2022 12:42:33.3440 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cd48b44c-00f9-4b66-507c-08da919799e5 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT072.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4365 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Removed freeing of mbuf in scattered Rx as it should not be freed in rx. Fixes: 965b3127d425 ("net/axgbe: support scattered Rx") Cc: stable@dpdk.org Signed-off-by: Bhagyada Modali --- drivers/net/axgbe/axgbe_rxtx.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/axgbe/axgbe_rxtx.c b/drivers/net/axgbe/axgbe_rxtx.c index 8b43e8160b..d4224992ee 100644 --- a/drivers/net/axgbe/axgbe_rxtx.c +++ b/drivers/net/axgbe/axgbe_rxtx.c @@ -458,14 +458,11 @@ uint16_t eth_axgbe_recv_scattered_pkts(void *rx_queue, memset((void *)(&desc->read.desc2), 0, 8); AXGMAC_SET_BITS_LE(desc->read.desc3, RX_NORMAL_DESC3, OWN, 1); - if (!eop) { - rte_pktmbuf_free(mbuf); + if (!eop) goto next_desc; - } first_seg->pkt_len = pkt_len; rxq->bytes += pkt_len; - mbuf->next = NULL; first_seg->port = rxq->port_id; if (rxq->pdata->rx_csum_enable) { -- 2.25.1