From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 03313A0032; Wed, 14 Sep 2022 09:59:23 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 13C4A4282E; Wed, 14 Sep 2022 09:59:12 +0200 (CEST) Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) by mails.dpdk.org (Postfix) with ESMTP id 1C0E642829 for ; Wed, 14 Sep 2022 09:59:10 +0200 (CEST) Received: by mail-lf1-f47.google.com with SMTP id o2so21713456lfc.10 for ; Wed, 14 Sep 2022 00:59:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=RuxSl4ko+LMwokKSR0wz2y+uCBrfw2IDsvbDUTA5CxI=; b=JbJRqP6ns6P7ZR5MonsNeC3x56lVMabmaP4QzKCiU56pjay+xAWgEAzNeDE+OcogT8 Kb+MhbT+5GPqYWI+FQgoq82Te+fB5Q69XS5fHBRNXbYW6BV6QbjwRyCwh6spetv2/6vN HV3f26RhsZ9vnyuPqpoA2lgE2RjwXQmLYz6gnZU1Zfr5Z5sfKrkkYUWw/D3w6Hfcq9Rg i4HRvdiJV4A8kDfPb84a9EHeF6V8Q/XoK5U4UrBXqPCAFPDmb7ZoxdliTGr/gn/Yq4jp nkrnCGOQXKrxBGXQamq2BK1K/ebjvmTNht4ZhB7O3sLH0clWaImc9wPnRhKMB6cc/i2M I0WA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=RuxSl4ko+LMwokKSR0wz2y+uCBrfw2IDsvbDUTA5CxI=; b=qKsAPCH8+He0T49sKQlD2MKxSFk/fPJb2OPd1wi5NaH6JrMRnYING+j6byzGrd7sh6 IWDft47xRazdBWLUKpKQyZQvxgo1eeVZwJYRwjb9nqpxP6ad9c4CT+HcRt7bxkzA3qtV 9tONIr80ojvQyuzRSdOpYMmSvOoL3o6vN8binP71AHwZ93y27nqBILFL/LaUFZ1HKEkx WYMK8UfRmPD1D+apGWxnyBSVK8Mp2Wl/B6Hhta8Fk8oYt0QX5blDE6RC4xuWr/UIXr5Y VRCyH3ysqLCXkiicB7DFeQbh5QM/6UpBHuYrs8ZNOCWMLQ2O1ITMyL7+w5MIeq9xAPFl S2Bw== X-Gm-Message-State: ACgBeo3p0kWrAm39wVr9DgaKOu8621SF7fLIMG0EWDlsrKYWPvZA/DXR xcW2Y5yEeWH+Hu76R1CD3OOoLw== X-Google-Smtp-Source: AA6agR4LwwCIFK/NPwXsGVRtbVhsiCyojm/zSfQ5twYdn6nM3psXqpxl0jvWVMbtHY0oQEak//KeSg== X-Received: by 2002:a05:6512:909:b0:48b:954c:8e23 with SMTP id e9-20020a056512090900b0048b954c8e23mr12983078lft.670.1663142349607; Wed, 14 Sep 2022 00:59:09 -0700 (PDT) Received: from toster (87-206-67-180.dynamic.chello.pl. [87.206.67.180]) by smtp.gmail.com with ESMTPSA id u19-20020ac258d3000000b00497ac6b2b15sm2256528lfo.157.2022.09.14.00.59.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Sep 2022 00:59:09 -0700 (PDT) Date: Wed, 14 Sep 2022 09:58:47 +0200 From: Stanislaw Kardach To: Bruce Richardson Cc: Honnappa Nagarahalli , Owen Hilyard , Juraj =?utf-8?Q?Linke=C5=A1?= , "thomas@monjalon.net" , David Marchand , "ronan.randles@intel.com" , "Tu, Lijuan" , dev , nd Subject: Re: [PATCH v4 4/9] dts: add ssh pexpect library Message-ID: <20220914075847.kw4r6ry5h7amnwzb@toster> References: <20220728100044.1318484-1-juraj.linkes@pantheon.tech> <20220729105550.1382664-1-juraj.linkes@pantheon.tech> <20220729105550.1382664-5-juraj.linkes@pantheon.tech> <20220913144149.xbtomt2pzwywnodn@toster> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Sep 14, 2022 at 08:42:07AM +0100, Bruce Richardson wrote: > > > > As far as customizing the prompts, I think that is doable via a > > configuration option. > > As far as different shells, I don't think we were planning to support > > anything besides either bash or posix-compatible shells. At the moment > > all of the community lab systems use bash, and for ease of test > > development it will be easier to mandate that everyone uses one shell. > > Otherwise DTS CI will need to run once for each shell to catch issues, > > which in my opinion are resources better spent on more in-depth testing > > of DTS and DPDK. > > > > [Honnappa] +1 for using just bash, we can document this as well. > > > > I would agree overall. Just supporting one shell is fine - certainly for > now. Also completely agree that we need to remove hard-coded passwords and > ideally non-root. However, I think for the initial versions the main thing > should be removing the passwords so I would be ok for keeping the "root" > login requirement, so long as we support using ssh keys for login rather > than hard-coded passwords. > > /Bruce The only reason I have mentioned different shells is to illustrate that prompt might be changed not only due to user modifying PS1 env variable. I agree with the rest (root-only, bash-only). -- Best Regards, Stanislaw Kardach