From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E6354A00C3; Tue, 20 Sep 2022 17:21:28 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 803A340DFB; Tue, 20 Sep 2022 17:21:28 +0200 (CEST) Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) by mails.dpdk.org (Postfix) with ESMTP id 9BE774069B for ; Tue, 20 Sep 2022 17:21:27 +0200 (CEST) Received: by mail-pg1-f180.google.com with SMTP id 78so2933974pgb.13 for ; Tue, 20 Sep 2022 08:21:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date; bh=1I8wvZqGgl2ULT4OBgp9FAbvNgaj9aMnEvVGWpm47zk=; b=acjAxXA1dNS0mZkJzoUjH67QXUOqzqx8b1O2DXqzax7z8PLCQ4csE5schv2hVEyL8D v4Rjw5oBWx6Sr0BvW9j4OKw6OHBLDsJjQWBp3pL1mXsF2bl2a/XeHanQDXk7P/H8lwJt f7XNb15eSqvTHGSrmzVpaO2XzImE4zWtLjkHlOLuRlipclFNnbY2WMAlc/D2pWfSMmDV 93h1afbusIaRSRuagToS7cNPApKkqqHMlXsio2iEopStnClMCu409KLwm5U9f4aizAVF 4ZDHC226EJUtMJJ7fMNUnMnQpa2jDnK7odprik/sf/KMN/gYg5Sx3V1RJ7oARcYMQd30 z3kA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date; bh=1I8wvZqGgl2ULT4OBgp9FAbvNgaj9aMnEvVGWpm47zk=; b=k1rXWD3XTe60Txr1XRygWD2LcDBXIUM6GBoaDTIECw5/gU5Hf0IkyYVtVn4o7msCdE G0bfiFSC1f6Mkg53bZsvVTgvtoYnlMfHl1B/aBYXPu4Fi5oksStSclbPoZM2iQClA/I0 Ypo/jGAcxTo8tCY7mrspFhX+9QUE7hrYKB/EQb92e3SDOXWabaHu2DhHr7bRfO3aq42N So+hwtYAl1AWwgrPqPQ08Cl2KG58fKWWa5FLkwd16g7MK1mKeQJ02M9UBK03eHXY7ZJN KpfaJn7k7PruvrqP658v3YE/ehwdqy/DH+5N9gcVfXa5We1nVknz7jGCjkS4k34o57sK yXfw== X-Gm-Message-State: ACrzQf1yIuDC/OygtSo4HMO1xx6kx3bHIF2tt7jcmqIhXbXZORcKTK0M jR31gy0U2BQ3VqrHMsF34h/Y8A== X-Google-Smtp-Source: AMsMyM6SvZtQV8Lftsm45qIpguZcazOX7/iWJQoXGbDruz3S8BH4ml2DFzftvlhLfrgCDqZbrokWug== X-Received: by 2002:aa7:95a2:0:b0:541:123f:bcac with SMTP id a2-20020aa795a2000000b00541123fbcacmr25011925pfk.52.1663687286730; Tue, 20 Sep 2022 08:21:26 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id jo18-20020a170903055200b00176a2d23d1asm39018plb.56.2022.09.20.08.21.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Sep 2022 08:21:26 -0700 (PDT) Date: Tue, 20 Sep 2022 08:21:24 -0700 From: Stephen Hemminger To: Dongdong Liu Cc: , , , , , "Min Hu (Connor)" , Maryam Tahhan Subject: Re: [PATCH v2 1/6] app/procinfo: add version dump Message-ID: <20220920082124.315fb772@hermes.local> In-Reply-To: <20220920105148.7664-2-liudongdong3@huawei.com> References: <20220722091236.15469-1-liudongdong3@huawei.com> <20220920105148.7664-1-liudongdong3@huawei.com> <20220920105148.7664-2-liudongdong3@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 20 Sep 2022 18:51:42 +0800 Dongdong Liu wrote: > From: "Min Hu (Connor)" > > This patch add support for dump dpdk version and ethdev firmware version. > > The command is like: > dpdk-proc-info -a xxxx:xx:xx.x --file-prefix=xxx -- --show-version > > Signed-off-by: Min Hu (Connor) > Signed-off-by: Dongdong Liu > --- Why mix DPDK and firmware version in one option? Why not use semi-standard convention of -V --version option for DPDK version and add --firmware-version option to show firmware.