From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D2166A00C3; Tue, 20 Sep 2022 17:22:33 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C52E240DFB; Tue, 20 Sep 2022 17:22:33 +0200 (CEST) Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by mails.dpdk.org (Postfix) with ESMTP id D98214069B for ; Tue, 20 Sep 2022 17:22:31 +0200 (CEST) Received: by mail-pl1-f171.google.com with SMTP id f23so2717766plr.6 for ; Tue, 20 Sep 2022 08:22:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date; bh=26HO9aj3UF0lW2hQBM41/51YRKeTaoL7D5FoQplzH/o=; b=mtg4wfZy4o/hqo11HxGZwIYapbgi+uZw8BJ1/308NSLWBW9A64c8P78lhjrbksHBNN 5k8aFOpgAuFR8znkVNxWoklDjGSVXtt7J8pxyuR6xYYnocWiuaWuc/JiPtFOmOIPU9sj frPnEiOYaLkLOnsR/zLsASYMslMwzIxO0fFyJ6yByUXzzQdaXQaCl0wl2uuyrQCOhdSo xCkTf+xCuEC0EwIXsL6nUur7saYiZTvRMO72tFx6T2IoXCszDyAya7arbcgJO19cCkh2 Ua71BEN6PlZNxj/07Ej/jnVWpuVc8zuA6kGKRVtxX9URvUZ8+HcPcWUIBadESmXmXlNZ z5mQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date; bh=26HO9aj3UF0lW2hQBM41/51YRKeTaoL7D5FoQplzH/o=; b=Bbe0gCmx8KJ7EtQYzVb2WTyVucIcucv5sz0vVXXlHYNzjRlFNw+9zd//0gDb0ERh8k VlOiOHx2p1bvmGgrBqxJAZoXlJ2QV2E+RLLfwkol/7WPk0QkktEjojHt1qQYf+hqkXFp vXlETXOVFXyebEDLQM9d1AJTuvxZ9HC8wrWpI/n3xM8cDdaxdyTt0ryxqKaPMr9ffSud smTfwwL7YWcqb6yUcLyyHQTmskfyc+llBAwZo1Vp7Ke1txz0p0EZ3wrdgBVfrSphRHBO E+giRJsGb4ReiT6/XrLA9CysZR9C83uHYwZeRO03/DXjyqJzK4Tu5NqS3VuntbGQDmOh BjtQ== X-Gm-Message-State: ACrzQf2SoY3fVP/Q78TL/80h3binPYiYYKimB8bot03dMTAzWuii441m e65PT5MTQ6O4iemiwBoqV7niDQ== X-Google-Smtp-Source: AMsMyM5btk/1YdRmmnuckxn7EE53noAWTzr+lyGyvqc66LihDEs1+NiG0jAk7qWaeN+kX3HRGVXGng== X-Received: by 2002:a17:90b:17c5:b0:202:596d:6e40 with SMTP id me5-20020a17090b17c500b00202596d6e40mr4543787pjb.53.1663687351111; Tue, 20 Sep 2022 08:22:31 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id 207-20020a6214d8000000b0053dfef91b0bsm1879377pfu.205.2022.09.20.08.22.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Sep 2022 08:22:30 -0700 (PDT) Date: Tue, 20 Sep 2022 08:22:29 -0700 From: Stephen Hemminger To: Dongdong Liu Cc: , , , , , "Min Hu (Connor)" , Maryam Tahhan Subject: Re: [PATCH v2 3/6] app/procinfo: add module info dump Message-ID: <20220920082229.17a642f4@hermes.local> In-Reply-To: <20220920105148.7664-4-liudongdong3@huawei.com> References: <20220722091236.15469-1-liudongdong3@huawei.com> <20220920105148.7664-1-liudongdong3@huawei.com> <20220920105148.7664-4-liudongdong3@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 20 Sep 2022 18:51:44 +0800 Dongdong Liu wrote: > + > + RTE_ETH_FOREACH_DEV(i) { > + /* Skip if port is not in mask */ > + if ((enabled_port_mask & (1ul << i)) == 0) > + continue; > + > + if (!rte_eth_dev_is_valid_port(i)) > + continue; There is no way RTE_ETH_FOREACH_DEV would iterate over an invalid port. If it did the macro would be seriously broken. That code is unnecessary.