From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 08ECBA00C3; Tue, 20 Sep 2022 17:24:10 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EF0B640DFB; Tue, 20 Sep 2022 17:24:09 +0200 (CEST) Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by mails.dpdk.org (Postfix) with ESMTP id B10E84069B for ; Tue, 20 Sep 2022 17:24:08 +0200 (CEST) Received: by mail-pl1-f178.google.com with SMTP id iw17so2771254plb.0 for ; Tue, 20 Sep 2022 08:24:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date; bh=1fHqS2NvPvd329QdOJIyO9DU+58MH37SehBKoZx0Aco=; b=kqKB40HCU05NlRB+x8yd/gnVd4E+9FgjV8Qteg43719hhIJVbLK/zJegb/nveAj1uH 9gC9Na8ZVApljav3371CsfmsybKQ56tIaTngVKn4CtdzIQOcZ8jBsbu1hfim/TixClps zFQjAd8WrkKMongopoACeDkkV3+yMLIKNFTQTzRo74XgEn8WSIiRbqTtfXg+tNE3di9p 10qVfGR35Ftr0U0Rhv8aK2x71Qb0OcnLL4lZPkrPhosejonZZIpkoiEtiDXZU2xdz0AS 3Op8R0t1WCykuNifsE4kUkXEvtc3YmEMXuVYdQ+MYrwE09lHP/ZUYvCRkKg6BxTgs/FM FiwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date; bh=1fHqS2NvPvd329QdOJIyO9DU+58MH37SehBKoZx0Aco=; b=tFgb4OJBBpRR+2z6LjuwKN/927BH6mzLqDUhYZwIGnsa2WPTBqgoZA9fYcjN2i0QqP WP5wMJdfqfj1VqSXMWyoGjVJ772wWvNwMP9P4hi7JTKHxxGODKw0u5opkOYlJ653z5Jp 8jbtvNgG+ArpJpXm0XRKaPmkEFnx9opz4RZRH/gLbTzcIheGQ6x3ZLRTwctNDcDluXnD Yhs1D8lGTdg7goDnTejoYIwtaYxV5yYKgtx904zApxKN6uePo/AvQidmGL34hlpJoGA1 JGoMMBgched3gQIbwqt5jpGMjsHb6Nlll9ydLpdlLAJXftMue/hkP3GteePAcRBvoMlV HHXw== X-Gm-Message-State: ACrzQf1xzQ51mBKVWFsN4NOmegtZ4gIefFdWrsgK+oh5V6b0gVvAj38L PvwNg0pR525tLiHFdCxCM75TMw== X-Google-Smtp-Source: AMsMyM7wKnMusSvoixqt2BFAEL0fUAaNtWsJ6TRTStTKIau+tPTDioj7V4We2+JhRVULKeGTX2X5Fw== X-Received: by 2002:a17:90a:8688:b0:202:91d7:6a53 with SMTP id p8-20020a17090a868800b0020291d76a53mr4508322pjn.153.1663687447856; Tue, 20 Sep 2022 08:24:07 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id g11-20020a63200b000000b00439f027789asm12485pgg.59.2022.09.20.08.24.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Sep 2022 08:24:07 -0700 (PDT) Date: Tue, 20 Sep 2022 08:24:05 -0700 From: Stephen Hemminger To: Dongdong Liu Cc: , , , , , "Min Hu (Connor)" , Maryam Tahhan Subject: Re: [PATCH v2 2/6] app/procinfo: add RSS RETA dump Message-ID: <20220920082405.781c58c1@hermes.local> In-Reply-To: <20220920105148.7664-3-liudongdong3@huawei.com> References: <20220722091236.15469-1-liudongdong3@huawei.com> <20220920105148.7664-1-liudongdong3@huawei.com> <20220920105148.7664-3-liudongdong3@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 20 Sep 2022 18:51:43 +0800 Dongdong Liu wrote: > + ret = rte_eth_dev_info_get(id, &dev_info); > + if (ret < 0) { > + printf("Error getting device info, ret = %d\n", ret); Proc-info should be showing all errors on stderr, not stdout. And in case of error should exit with non-zero status. But this maybe a generic problem in lots of places in the application.