From: Stephen Hemminger <stephen@networkplumber.org>
To: "Abdullah Ömer Yamaç" <omer.yamac@ceng.metu.edu.tr>
Cc: dev@dpdk.org, ferruh.yigit@xilinx.com,
David Marchand <david.marchand@redhat.com>
Subject: Re: [PATCH v2] lib/eal/linux: update lcore-worker name due to high number of cores
Date: Thu, 22 Sep 2022 08:18:43 -0700 [thread overview]
Message-ID: <20220922081843.50b6d22e@hermes.local> (raw)
In-Reply-To: <20220922103023.499233-1-omer.yamac@ceng.metu.edu.tr>
On Thu, 22 Sep 2022 13:30:23 +0300
Abdullah Ömer Yamaç <omer.yamac@ceng.metu.edu.tr> wrote:
> In this patch we suggest a new name for lcore-worker.
> In case of more than 99 logical cores, name is truncated
> (length is restricted to 16 characters, including the
> terminating null byte ('\0')) and it makes hard to follow threads.
>
> Signed-off-by: Abdullah Ömer Yamaç <omer.yamac@ceng.metu.edu.tr>
>
> ---
> Cc: David Marchand <david.marchand@redhat.com>
> ---
> lib/eal/linux/eal.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c
> index 46bf52cef0..9a168b7773 100644
> --- a/lib/eal/linux/eal.c
> +++ b/lib/eal/linux/eal.c
> @@ -1248,7 +1248,7 @@ rte_eal_init(int argc, char **argv)
>
> /* Set thread_name for aid in debugging. */
> snprintf(thread_name, sizeof(thread_name),
> - "lcore-worker-%d", i);
> + "rte-worker-%d", i);
> ret = rte_thread_setname(lcore_config[i].thread_id,
> thread_name);
> if (ret != 0)
BSD should be setting name as well.
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
next prev parent reply other threads:[~2022-09-22 15:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-22 10:18 [PATCH] Update " Abdullah Ömer Yamaç
2022-09-22 10:30 ` [PATCH v2] lib/eal/linux: update " Abdullah Ömer Yamaç
2022-09-22 15:18 ` Stephen Hemminger [this message]
2022-09-23 7:06 ` [PATCH v3] eal: " Abdullah Ömer Yamaç
2022-09-26 9:39 ` David Marchand
2022-09-26 9:56 ` [PATCH v4] eal: fix thread names for high order lcores Abdullah Ömer Yamaç
2022-09-26 10:03 ` [PATCH v5] " Abdullah Ömer Yamaç
2022-09-30 8:52 ` David Marchand
2022-09-26 10:44 ` [PATCH v3] eal: update lcore-worker name due to high number of cores Kevin Traynor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220922081843.50b6d22e@hermes.local \
--to=stephen@networkplumber.org \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@xilinx.com \
--cc=omer.yamac@ceng.metu.edu.tr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).