From: "Morten Brørup" <mb@smartsharesystems.com>
To: thomas@monjalon.net, david.marchand@redhat.com,
bruce.richardson@intel.com
Cc: dev@dpdk.org, "Morten Brørup" <mb@smartsharesystems.com>
Subject: [PATCH v3] eal: Pointer alignment check improvements
Date: Thu, 22 Sep 2022 15:27:30 +0200 [thread overview]
Message-ID: <20220922132730.5178-1-mb@smartsharesystems.com> (raw)
In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D8734D@smartserver.smartshare.dk>
Checking a const pointer for alignment would emit a warning about the
const qualifier being discarded.
No need to calculate the aligned pointer; just check the last bits of the
pointer.
v3:
- Make the uintptr_t const to avoid potential future warnings. (Bruce)
v2:
- Remove compiler attribute ((const)) from function;
it was a coding style issue.
Signed-off-by: Morten Brørup <mb@smartsharesystems.com>
---
lib/eal/include/rte_common.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/eal/include/rte_common.h b/lib/eal/include/rte_common.h
index 2e22c1b955..ed81e0db0a 100644
--- a/lib/eal/include/rte_common.h
+++ b/lib/eal/include/rte_common.h
@@ -404,9 +404,9 @@ static void __attribute__((destructor(RTE_PRIO(prio)), used)) func(void)
* True(1) where the pointer is correctly aligned, false(0) otherwise
*/
static inline int
-rte_is_aligned(void *ptr, unsigned align)
+rte_is_aligned(const void * const __rte_restrict ptr, const unsigned int align)
{
- return RTE_PTR_ALIGN(ptr, align) == ptr;
+ return ((const uintptr_t)ptr & (align - 1)) == 0;
}
/*********** Macros for compile type checks ********/
--
2.17.1
next prev parent reply other threads:[~2022-09-22 13:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-21 14:28 [PATCH] " Morten Brørup
2022-09-22 11:44 ` [PATCH v2] " Morten Brørup
2022-09-22 11:52 ` Bruce Richardson
2022-09-22 11:59 ` Bruce Richardson
2022-09-22 13:00 ` Morten Brørup
2022-09-22 13:27 ` Morten Brørup [this message]
2022-09-22 13:38 ` [PATCH v3] " Bruce Richardson
2022-09-22 20:54 ` Morten Brørup
2022-09-23 8:24 ` Bruce Richardson
2022-09-23 8:25 ` [PATCH v2] " Bruce Richardson
2022-09-30 8:38 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220922132730.5178-1-mb@smartsharesystems.com \
--to=mb@smartsharesystems.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).