From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6F25DA054D; Fri, 23 Sep 2022 20:57:34 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 066AA406A2; Fri, 23 Sep 2022 20:57:34 +0200 (CEST) Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) by mails.dpdk.org (Postfix) with ESMTP id 6C66240156 for ; Fri, 23 Sep 2022 20:57:33 +0200 (CEST) Received: by mail-pf1-f171.google.com with SMTP id e5so996280pfl.2 for ; Fri, 23 Sep 2022 11:57:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date; bh=vXUWDtChN8O/OvEJgEs0EaVvCcME8j6AVoKstWg5h80=; b=0oxZ+7xkx0y3MFFy42idFo+odRbX7VzB3aZ4vOiO05bA4x7ShJcfF7HfDykFX0Ardl N56oGpR7VjQfjTqfPJULrm3OU6O/fr+7kEdcIDNzhHUJWMWc5jAObV+kbRu5txpHG+w9 +NBmEyYzYyBFfByYT+5tEAax3Meg8ch/IVPJhs34d0QWyMjRMEfmy6nYK/vdsmOKUZWQ dvFwTgUWZkYzfRdGdpd/DxCI2F9sZ2DLYtN6fvAdhdUZdhb1PucVkOrMBt1la2PqCnvD QYP2+hwdGK+Qe6WoTUeBChLxeK0no6ztS9+iY/YA77w3pJiRV3rqUxN9cwsvAU4Qouvi CiQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date; bh=vXUWDtChN8O/OvEJgEs0EaVvCcME8j6AVoKstWg5h80=; b=X6eIwxM/WTPp+EIR35qcvTu9XPMZ62+ep4wi3wUa6PEiKBFTHVHhHDwmZWMhwvaaai VUhCNLw8NkgUZi6Lq3ZMoJsFv+wqiOE6GiUcw4ILyFype49x6fFvu7U2V2ki7gmlpKt1 qa1aRnhYyYCzR5YGQ4AK/nozZyEbL/Pl+yRA5P0BxiSsj+VVdId6anlFT41i3cNiTfYD g6MmafdAvVz4yUPDsIRsOkK6hFB/pQRqkIq9zYD3hWO5WT/9bFTPghrWSq5LjsNz+iql ZDqMfUJTahi1bLZL3Epk14Hmrpv2U7JM+tK0uccqZfcwlGHP9vx4jiROqWI+3kpKMmU2 +45g== X-Gm-Message-State: ACrzQf2NRWgfEn+eot5U9mIf4oB0KxeuoAuZialVq3TaJ9wZT2WoVTTN uqN0bQxOQ/FVG2+Gpaf4TVO7iQ== X-Google-Smtp-Source: AMsMyM5eG+2s9jXvG1t3Rxij8V7DuzueGqgQ+X6u7Armat784Z6q7ZWyldk6p9n0UOu2vgN1SJ1FmA== X-Received: by 2002:a05:6a00:13a5:b0:542:4a6d:9a1e with SMTP id t37-20020a056a0013a500b005424a6d9a1emr10643678pfg.43.1663959452412; Fri, 23 Sep 2022 11:57:32 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id m14-20020a170902db0e00b00172fad607b3sm6397528plx.207.2022.09.23.11.57.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Sep 2022 11:57:32 -0700 (PDT) Date: Fri, 23 Sep 2022 11:57:31 -0700 From: Stephen Hemminger To: Junfeng Guo Cc: qi.z.zhang@intel.com, jingjing.wu@intel.com, ferruh.yigit@xilinx.com, dev@dpdk.org, xiaoyun.li@intel.com, awogbemila@google.com, bruce.richardson@intel.com, xueqin.lin@intel.com, Haiyue Wang Subject: Re: [PATCH v3 1/9] net/gve: introduce GVE PMD base code Message-ID: <20220923115731.1ef62488@hermes.local> In-Reply-To: <20220923093829.3019525-2-junfeng.guo@intel.com> References: <20220829084127.934183-11-junfeng.guo@intel.com> <20220923093829.3019525-1-junfeng.guo@intel.com> <20220923093829.3019525-2-junfeng.guo@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 23 Sep 2022 17:38:21 +0800 Junfeng Guo wrote: > +#define GVE_DEVICE_OPTION_TOO_BIG_FMT "Length of %s option larger than expected. Possible older version of guest driver." Why do you need #define for this? +#define GVE_DEVICE_OPTION_ERROR_FMT "%s option error:\n" \ +"Expected: length=%d, feature_mask=%x.\n" \ +"Actual: length=%d, feature_mask=%x." + Why such a wordy multi-line message, please use single line