From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 21E2EA0542; Wed, 5 Oct 2022 18:11:28 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0F3FB40694; Wed, 5 Oct 2022 18:11:28 +0200 (CEST) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 16BE740143 for ; Wed, 5 Oct 2022 18:11:27 +0200 (CEST) Received: by linux.microsoft.com (Postfix, from userid 1086) id 34F1820E97B6; Wed, 5 Oct 2022 09:11:26 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 34F1820E97B6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1664986286; bh=J36Y0iC9Qs6uaTsntss5ax5XRxON3O/2MbpngtFAO1o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IvB4uwqjO6FmbVEKflOQMTXNLfLIciXxQfMGZv5E2xNtCPmXBufpCLOTm9NTxPyK2 TsNtvXGZrYBwRp1cowYbSGRmjE3MnbEL3oVojTBmCZDw81Ipmimse+p9DZeFZW/ODn u2jEFe7+pZ0nGpN2zx9ON0NuSRR6rTnL3ryC9PUQ= Date: Wed, 5 Oct 2022 09:11:26 -0700 From: Tyler Retzlaff To: David Marchand Cc: dev@dpdk.org, thomas@monjalon.net, dmitry.kozliuk@gmail.com, anatoly.burakov@intel.com Subject: Re: [PATCH v4 0/6] add thread lifetime and attributes API Message-ID: <20221005161126.GB7581@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1654783134-13303-1-git-send-email-roretzla@linux.microsoft.com> <1656348966-10194-1-git-send-email-roretzla@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org hi David, On Wed, Sep 21, 2022 at 10:15:36AM +0200, David Marchand wrote: > On Mon, Jun 27, 2022 at 6:56 PM Tyler Retzlaff > wrote: > > > > add rte thread lifetime and attributes api. with these api additions > > there is now sufficient platform abstracted thread api to remove the > > use of pthread in the unit tests. > > > > v4: > > * update version.map to show api from series added in 22.11 instead > > of 22.07. > > Patch 1 still adds symbols in 22.07 section of the experimental block. this looks like a goofup on my part, i will fix in the next revision. > > Compilation is broken when stopping at patch 4. this was because commit 72b452c5f2599f970f47fd17d3e8e5d60bfebe7a removed #include of from rte_common.h i will fix this in the next revision. > > Newly added code can go to eal_common_thread.c rather than introduce a > new common/rte_thread.c file (or is there a rationale for this?). i will make this change in the next revision. if anyone does object i hope they will do so quickly. > > There are guards for the new structs against RTE_HAS_CPUSET being defined. > Can you elaborate why those guards are needed? eal uses this guard in a couple of places so the best explanation i can provide is an existing pattern was being followed. that being said it's clear that this code won't work without RTE_HAS_CPUSET. i will remove the guard and test if the build breaks for the platforms i have toolchains available. if it builds cleanly i'll remove the guard in the next revision. > > Commitlogs / comments sentences must start with a capital letter. i will fix in next revision, but ew caps. > > Can you prepare a new revision for -rc1? assuming the above actions to address feedback are acceptable the new revision should be up today (PST). > > Thanks. thank you! ty