From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 0BCFDA00C2;
	Thu,  6 Oct 2022 00:20:08 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id E135A40A82;
	Thu,  6 Oct 2022 00:20:07 +0200 (CEST)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id 0B30F40697
 for <dev@dpdk.org>; Thu,  6 Oct 2022 00:20:06 +0200 (CEST)
Received: by linux.microsoft.com (Postfix, from userid 1086)
 id 2D68E203A02C; Wed,  5 Oct 2022 15:20:05 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 2D68E203A02C
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1665008405;
 bh=WnYpmJjraDRX2S20b5b/aDkWkrsO4XPH0q8n2mpACYY=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=poPc2FNQT9DJkCUguZAgJ6RfVK2mVFEyBF56EXYS0cVe/l9cmW6J3YCaLVVRmGz2z
 ycOuv0DCyR/Ccao6nOfm5l8FcUTmxa20hVXRoNW5MW62sdydPbfpjE/oyRmBjUC3dy
 GqZ0y/O6RIg3u41/qmw/ZyVgejj7cUBjC8SMzl14=
Date: Wed, 5 Oct 2022 15:20:05 -0700
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: David Marchand <david.marchand@redhat.com>
Cc: Thomas Monjalon <thomas@monjalon.net>, dev@dpdk.org,
 Stephen Hemminger <stephen@networkplumber.org>,
 Morten =?iso-8859-1?Q?Br=F8rup?= <mb@smartsharesystems.com>
Subject: Re: [PATCH] eal: fix return type of bsf safe functions
Message-ID: <20221005222005.GA9819@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <22501102.ssLaC8jLEa@thomas>
 <20221005154036.4187143-1-thomas@monjalon.net>
 <CAJFAV8x3bxq00D7eMej29sjMw_whQOoGjfTCXoaTjEYHs9pFOg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAJFAV8x3bxq00D7eMej29sjMw_whQOoGjfTCXoaTjEYHs9pFOg@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Wed, Oct 05, 2022 at 09:41:26PM +0200, David Marchand wrote:
> On Wed, Oct 5, 2022 at 5:41 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> >
> > In a recent commit, changing return type from int to uint32_t,
> > I did a last minute change to functions rte_bsf32_safe and rte_bsf64_safe,
> > because thought they were forgotten.
> > Actually these functions are returning 0 or 1, so it should be int.
> > The return type is reverted to the original type for these 2 functions.
> >
> > Fixes: 4b81c145ae37 ("eal: change return type of bsf/fls functions")
> >
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> 
> Reviewed-by: David Marchand <david.marchand@redhat.com>

Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>