DPDK patches and discussions
 help / color / mirror / Atom feed
From: "huzaifa.rahman" <huzaifa.rahman@emumba.com>
To: anatoly.burakov@intel.com
Cc: dev@dpdk.org, stephen@networkplumber.org,
	"huzaifa.rahman" <huzaifa.rahman@emumba.com>
Subject: [PATCH] mem: close rtemap files
Date: Thu,  6 Oct 2022 10:04:05 +0000	[thread overview]
Message-ID: <20221006100405.2809898-1-huzaifa.rahman@emumba.com> (raw)

Bugzilla ID: 560

The memory subsystem is leaving open a file descriptor for each
rtemap file. This can lead to hundreds of extra open file descriptors
which has negative side effects. For example, the application may go
over its maximum file descriptor limit, or the application may be using
limited API's like select that only allow 1024 file descriptors.

The EAL memory subsystem does not need to hold the file open.
Probably the original intention was to keep the file locked, but that is
not necessary. The Linux kernel keeps a reference count on the file,
and the mmap counts is a reference and therefore maintains the file
as locked.

The fix is just to close the file after it is setup.

Signed-off-by: huzaifa.rahman <huzaifa.rahman@emumba.com>
---
 lib/eal/linux/eal_memalloc.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/lib/eal/linux/eal_memalloc.c b/lib/eal/linux/eal_memalloc.c
index f8b1588cae..955c4e4f95 100644
--- a/lib/eal/linux/eal_memalloc.c
+++ b/lib/eal/linux/eal_memalloc.c
@@ -679,6 +679,9 @@ alloc_seg(struct rte_memseg *ms, void *addr, int socket_id,
 
 	huge_recover_sigbus();
 
+	close(fd);
+	fd_list[list_idx].fds[seg_idx] = -1;
+
 	ms->addr = addr;
 	ms->hugepage_sz = alloc_sz;
 	ms->len = alloc_sz;
-- 
2.25.1


             reply	other threads:[~2022-10-06 10:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-06 10:04 huzaifa.rahman [this message]
2022-10-06 10:42 ` Dmitry Kozlyuk
2022-10-20 10:12   ` Huzaifa Rahman
2022-10-20 10:46     ` Dmitry Kozlyuk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221006100405.2809898-1-huzaifa.rahman@emumba.com \
    --to=huzaifa.rahman@emumba.com \
    --cc=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).