From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3B7DFA04FD; Fri, 7 Oct 2022 19:44:49 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E024D42B72; Fri, 7 Oct 2022 19:44:31 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2053.outbound.protection.outlook.com [40.107.94.53]) by mails.dpdk.org (Postfix) with ESMTP id F21C342B6C; Fri, 7 Oct 2022 19:44:29 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TMQHxcKfIqXgTUQ18YgiBx41G4GtdHpajxahGGKDZgJ4GdNYUPdCykcwAnLeXqorcQ6dlKCdej8DWIKwEoR9WdTi9iiQ86GDZhmnuVQlTpEJuaemGBa6ht1OHg5efAn0ClztJ7FHGEIV1R62O2IegWO6yOqt9+4Sy3pJXzZTocJMrC+WLU6WqgDnwxrGKnV8644yoPe0SWv6Ue9Tfry+kG9KiOiD77Teo/POrNeMNFiXZ2GRcuyR14MgrAUA1n4AT4vVxaQU5z+L1LcOPf/wptecPIXhGmRFwVYWSoPcl8wHN9Aqf+bnuiprZwPmFQFJghsupQDZtTawC7aZQ37KFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=40fjOdsZ9XMkJ08cFZgreKod3g1ObzNW5j5dhZ+1Rc4=; b=T6O36NYOjCx4MktetDFmHBsDHXiHg+OTsXhVrV25kHfPGjOddATwQI2/jEV/WF3aXf8w7sjKvBQXKEEvOodf7F76WaDap6WRyoTEF7KoGc5AWaiNV4Sa1AAskRR+1D/reDWkJE3l8ko/FvuwGZa+qqVOyj+sHlED6YIA4bzH3aHMLum0fsXgrLo9848xc7mKCiVwl6NXPwI5mamvof0dJXNNN5fr90++7pAeXUJ0tcgb45KqrPA9PI1UsbQNd15/md9Q2JwwVztvFlzmoF5SMusqmJgnTvh1Q7TyqmfiJ+rwAFBhHkdg/rURQi4aA89INCDz78pttKRmFhMAcqFGPQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=dpdk.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=40fjOdsZ9XMkJ08cFZgreKod3g1ObzNW5j5dhZ+1Rc4=; b=Ccui8HZLlZlIVuv8AOncgV4iUij0bIJwAG6xMcHgmGhoU7YnHVhMmVbHSXy+SqsVA3sYQp5eoG9gHCAWwvg+S7Ve14MDYRk7SI5e2YXOHAIp2F5p3QABc31KWca72g2vZYUqXni1hcVENnE6tq+Qrtxe4Rcrx0huUublLurISgg= Received: from MW4PR03CA0026.namprd03.prod.outlook.com (2603:10b6:303:8f::31) by DM8PR12MB5430.namprd12.prod.outlook.com (2603:10b6:8:28::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.24; Fri, 7 Oct 2022 17:44:27 +0000 Received: from CO1NAM11FT055.eop-nam11.prod.protection.outlook.com (2603:10b6:303:8f:cafe::27) by MW4PR03CA0026.outlook.office365.com (2603:10b6:303:8f::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15 via Frontend Transport; Fri, 7 Oct 2022 17:44:27 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT055.mail.protection.outlook.com (10.13.175.129) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5709.10 via Frontend Transport; Fri, 7 Oct 2022 17:44:26 +0000 Received: from driver-dev1.pensando.io (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Fri, 7 Oct 2022 12:44:25 -0500 From: Andrew Boyer To: CC: Andrew Boyer , , Subject: [PATCH 05/35] net/ionic: fix up reported error stats Date: Fri, 7 Oct 2022 10:43:06 -0700 Message-ID: <20221007174336.54354-6-andrew.boyer@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20221007174336.54354-1-andrew.boyer@amd.com> References: <20221007174336.54354-1-andrew.boyer@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT055:EE_|DM8PR12MB5430:EE_ X-MS-Office365-Filtering-Correlation-Id: 6abfbbca-385b-4ec2-982f-08daa88b944b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: d4KdtCExfKv0zBYk3tVagq4EmU6Dd9CK4bvQV0JvazhLhMCTO8oXePsHF36rEv0f2Xj9mlm58XdDQu2sheZJlElWs9WELipzBkfNqs6/oTXQjArssoo4hcW5Tvr/1G3f7AM7OIpU1F8KLUS89xn49XL/Xv+X1uo6A5RAw8J5xk0R5xY0pP3+H7FzxVl1veGcKyjs+M/7wkQHCe88ai1IYLpmlvD8IzCorrfm1/wf0ExgwD5RIx7+iZgztnvJU0j5uuYgNV7tDAMmUOW5X6IyEXH/8s4C04zzzNB/kI8zB4P2FNelQxc0rBPmXaUUG53O+Wi0lyBiEzt+00LdLBitrO/PGkxC9FqJ37lwKdOD4aUh3dN50dI1nDPA4FxnvxcMprV1fbKCL1vZPIBomI3ba3Tk1kaKV+uAd/Yv66/076DparRhaWNP11kNbJgqms8+HzV4JTruOsR5WN9VJnrVbVwN3ODBHJbphwSleqVEnEDxa2rJ6bpw0gRijN6t1OZXVUmy7T5MexGyIHvjuhEdwJ/Z5kKzXP6rMhZMNoL+mPRtKr3Skhf0EF327sBhOuPdapPX5VA0vWxb6B3n97fIex6k3y3yaS7Uuwe/ge27rL6yAltTJqoUj1o2Yi/AhEDi3A832gEAiVpUomP9elblC/zWV2LgTfc+4yi7XxH7GnFA+nfVAMcForvCd6Ei35/k4aDbD/pQK5RdzHWKa/5Ug9WYUr8Oa33UsKnUH7O91CzB2DbUaWkp6Gm83vrJ+Qm/UboOa26z5XHWc50R7kupofnL3++ESHFbo0XgiMG0b/geb3Lt5P1Eg3e5rWYzyQ8A X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230022)(4636009)(136003)(39860400002)(376002)(346002)(396003)(451199015)(40470700004)(46966006)(36840700001)(82310400005)(186003)(336012)(1076003)(16526019)(47076005)(86362001)(83380400001)(36860700001)(426003)(81166007)(82740400003)(356005)(41300700001)(8936002)(40480700001)(316002)(2906002)(6916009)(8676002)(70586007)(70206006)(4326008)(5660300002)(26005)(54906003)(6666004)(2616005)(44832011)(40460700003)(478600001)(36756003)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Oct 2022 17:44:26.6686 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6abfbbca-385b-4ec2-982f-08daa88b944b X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT055.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR12MB5430 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Report descriptor errors in ierrors instead of imissed. Don't report rx_queue_empty or rx_queue_disabled in imissed, since those packet errors are already included in the rx_*_drop_packets counters. This makes the reported stats correct. Fixes: 3cdfd90579e7 ("net/ionic: add stats") Cc: cardigliano@ntop.org Cc: stable@dpdk.org Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_lif.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/ionic/ionic_lif.c b/drivers/net/ionic/ionic_lif.c index 5e8fdf3893..799530f7f5 100644 --- a/drivers/net/ionic/ionic_lif.c +++ b/drivers/net/ionic/ionic_lif.c @@ -132,7 +132,7 @@ ionic_lif_get_abs_stats(const struct ionic_lif *lif, struct rte_eth_stats *stats for (i = 0; i < lif->nrxqcqs; i++) { struct ionic_rx_stats *rx_stats = &lif->rxqcqs[i]->stats; - stats->imissed += + stats->ierrors += rx_stats->no_cb_arg + rx_stats->bad_cq_status + rx_stats->no_room + @@ -144,10 +144,8 @@ ionic_lif_get_abs_stats(const struct ionic_lif *lif, struct rte_eth_stats *stats ls->rx_mcast_drop_packets + ls->rx_bcast_drop_packets; - stats->imissed += - ls->rx_queue_empty + + stats->ierrors += ls->rx_dma_error + - ls->rx_queue_disabled + ls->rx_desc_fetch_error + ls->rx_desc_data_error; -- 2.17.1