From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 58478A0544; Tue, 11 Oct 2022 02:51:43 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6B55342BAE; Tue, 11 Oct 2022 02:51:42 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2083.outbound.protection.outlook.com [40.107.237.83]) by mails.dpdk.org (Postfix) with ESMTP id 823CF42B9F; Tue, 11 Oct 2022 02:51:41 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T9Wqd5t1oCzmqSK4LLS6MUQQCrlRmbz7EEs+7Iwe0nPStHjIb6mf890ZvJwhbVLL9Wwve9o+vwKy0kf98UPvPZSFv2ICQZ/h0EOfLdMrZeTgSVE7nGAcIE1rpHjJSeylU1f2mmBbb9GZvu2W8P1NzS1eum5u/PD2c2pE9nCDB3MGmbXxdKodVbULV1IvZHe9X1RHdWSscXhCFEgh7KnIt7d/l+vsBapOE2LZX4gVhXuur2EXShzhTHQhUfIJ2moZF64K6B02fvV1hetaebsCB6USZOREp2EDwmgSEw+JKhRppB878Qdq4/CGuYhofIRE2oL0e2QNIuSzsXnJFmHP/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=40fjOdsZ9XMkJ08cFZgreKod3g1ObzNW5j5dhZ+1Rc4=; b=S8pIN/DswrwLVysjz4hp36CjcHROcipVNa7lFCbgIL+giVF1z9Y1L0CH5XJ49OQljgCfZKJIcusZj1oC0V8Bk8DnaotvoRU18LGFxarMSLzPjRsMmza5dhi4CzCCtaj56kZMoV0JILoe8zsTG2e0My0e9WnLeND2GpIo3xzhtQf6am+8gKzkGw+KWFRWXIZVG0rsVM9/SLNczUjeDUFG8HGzoRPcIyT4dHb6R2Qhbe/z609/JTCdYCQ5LTcI8xMpp5XVWUyMzWsUXFDA9SnDaHMtkLoiw7l0RiNhNVU79o7/MH7ar0lur4qh3ev97D9n3hZ9qkoWU8xM85o8i7IqVQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=dpdk.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=40fjOdsZ9XMkJ08cFZgreKod3g1ObzNW5j5dhZ+1Rc4=; b=fPRit2/+Box2UVqWB9WdFU/Krzn8LXnX01xvyUqEHGm8XYg+B8iTR9oQnUH7rLDViX2V9Zwuzmhr0GLTZBp0RFbxZMo80d0hb5NHLJrWv4swWQzDn56hB/cVFIRusvO5Z0WVwNYdIRsWhfxbkElvhumaKDI2SM+6X+mG7X0uc+8= Received: from BN9P221CA0017.NAMP221.PROD.OUTLOOK.COM (2603:10b6:408:10a::8) by DS0PR12MB6584.namprd12.prod.outlook.com (2603:10b6:8:d0::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.30; Tue, 11 Oct 2022 00:51:39 +0000 Received: from BN8NAM11FT004.eop-nam11.prod.protection.outlook.com (2603:10b6:408:10a:cafe::5c) by BN9P221CA0017.outlook.office365.com (2603:10b6:408:10a::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15 via Frontend Transport; Tue, 11 Oct 2022 00:51:38 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT004.mail.protection.outlook.com (10.13.176.164) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5709.10 via Frontend Transport; Tue, 11 Oct 2022 00:51:38 +0000 Received: from driver-dev1.pensando.io (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 10 Oct 2022 19:51:37 -0500 From: Andrew Boyer To: CC: Andrew Boyer , , Subject: [PATCH v1 05/35] net/ionic: fix up reported error stats Date: Mon, 10 Oct 2022 17:50:02 -0700 Message-ID: <20221011005032.47584-6-andrew.boyer@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20221007174336.54354-1-andrew.boyer@amd.com> References: <20221007174336.54354-1-andrew.boyer@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT004:EE_|DS0PR12MB6584:EE_ X-MS-Office365-Filtering-Correlation-Id: e62cc05b-8111-478b-2364-08daab22c14b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: OEIAIiFfaPBRfb5M2uEsyN/ZESYqkxNRKqXEwrOEQgtiA7GiI82ElMoCGs1MGaP58dLqWixpgNVZrGWHkF/b2X753AX5UujcAw8o2QVUOtJ1QO1czf482CboVUEtpqfcvjdg0DO7gqYb/wF7vu0F8yfUKAAU5iQXrtIPMJzTqSVSFHI3/1O2f30BXgftO/UfE7IGF9dRHgXm6IlAB7LiMVumO7Lmvh/rK+l3fnauDxE2+ov+SXjNzHTmTOx8gFvLZfdKXrnrP5jRHkE8+hFFb0j5yDGrbSqw4fHnMva7qafEsLcJ7zz2xkivGa12oHp/AcnjsxXLG0rJJIYYIxJ/shTipVQGSpH6x+Q27BWPd4rm3c8Wc53psP1Y43g4Mp3EaBB2sc3BZ4TBewmlbNjMWN/+m7rPCxXKe/nYgwYVUEjH+qwK1XdFgxaSiTO6oSOso0+WTeWQ5lnDa6nvr4bPqzIoV7JRZ01pwFVW7J6v1WJb86vprvkgYeEr8uaaR4CCrQq0xHnF55x2lqRLcd6SHb3/u/bx+C3s/4umQ7QhkbRbVgNYGLJp87tmaWwSoaFSHT/CUAQZ0fElt7CwjYP0/RhBom52ETb3i8/b2DUi5XOyt50GNpTJFyUby9cFUf85/OtmF+W0KY62KfFoTaah2wx/U161MH8fqxKV18P/FpZZ28YF3lD02XufwzGzy0RdQysuNJiOcsYEz46Mv6XmediA1lV8Ydg/ObLOn9SVNBuvcqxD44suKQlBUfWPh/GgxVZ4JSFUNZ7XWV/bjPus5IMEEDke/vreEJr2nhtefT3TLLii4WWcKPEpJzBEvVC/ X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230022)(4636009)(376002)(396003)(346002)(39860400002)(136003)(451199015)(46966006)(36840700001)(40470700004)(2906002)(81166007)(8936002)(336012)(426003)(16526019)(70206006)(41300700001)(1076003)(44832011)(8676002)(5660300002)(6916009)(36756003)(186003)(316002)(54906003)(36860700001)(86362001)(40460700003)(4326008)(26005)(356005)(478600001)(82740400003)(6666004)(2616005)(82310400005)(83380400001)(70586007)(40480700001)(47076005)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2022 00:51:38.6198 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e62cc05b-8111-478b-2364-08daab22c14b X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT004.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB6584 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Report descriptor errors in ierrors instead of imissed. Don't report rx_queue_empty or rx_queue_disabled in imissed, since those packet errors are already included in the rx_*_drop_packets counters. This makes the reported stats correct. Fixes: 3cdfd90579e7 ("net/ionic: add stats") Cc: cardigliano@ntop.org Cc: stable@dpdk.org Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_lif.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/ionic/ionic_lif.c b/drivers/net/ionic/ionic_lif.c index 5e8fdf3893..799530f7f5 100644 --- a/drivers/net/ionic/ionic_lif.c +++ b/drivers/net/ionic/ionic_lif.c @@ -132,7 +132,7 @@ ionic_lif_get_abs_stats(const struct ionic_lif *lif, struct rte_eth_stats *stats for (i = 0; i < lif->nrxqcqs; i++) { struct ionic_rx_stats *rx_stats = &lif->rxqcqs[i]->stats; - stats->imissed += + stats->ierrors += rx_stats->no_cb_arg + rx_stats->bad_cq_status + rx_stats->no_room + @@ -144,10 +144,8 @@ ionic_lif_get_abs_stats(const struct ionic_lif *lif, struct rte_eth_stats *stats ls->rx_mcast_drop_packets + ls->rx_bcast_drop_packets; - stats->imissed += - ls->rx_queue_empty + + stats->ierrors += ls->rx_dma_error + - ls->rx_queue_disabled + ls->rx_desc_fetch_error + ls->rx_desc_data_error; -- 2.17.1