* [PATCH] net/iavf: fix default state for Rx timestamp enabling
@ 2022-10-12 2:53 Simei Su
2022-10-13 1:47 ` Simei Su
0 siblings, 1 reply; 3+ messages in thread
From: Simei Su @ 2022-10-12 2:53 UTC (permalink / raw)
To: qi.z.zhang, qiming.yang; +Cc: dev, wenjun1.wu, Simei Su, stable
When starting testpmd without "--enable-rx-timestamp", found the
issue that Rx timestamp on Flex descriptor is still enabled.
This patch adds per queue offload check to disable Rx timestamp
support in default state.
Fixes: b5cd735132f6 ("net/iavf: enable Rx timestamp on flex descriptor")
Cc: stable@dpdk.org
Signed-off-by: Simei Su <simei.su@intel.com>
---
drivers/net/iavf/iavf_vchnl.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/iavf/iavf_vchnl.c b/drivers/net/iavf/iavf_vchnl.c
index 4327c5a..729400c 100644
--- a/drivers/net/iavf/iavf_vchnl.c
+++ b/drivers/net/iavf/iavf_vchnl.c
@@ -1070,7 +1070,8 @@ iavf_configure_queues(struct iavf_adapter *adapter,
}
if (vf->vf_res->vf_cap_flags & VIRTCHNL_VF_CAP_PTP &&
- vf->ptp_caps & VIRTCHNL_1588_PTP_CAP_RX_TSTAMP)
+ vf->ptp_caps & VIRTCHNL_1588_PTP_CAP_RX_TSTAMP &&
+ rxq[i]->offloads & RTE_ETH_RX_OFFLOAD_TIMESTAMP)
vc_qp->rxq.flags |= VIRTCHNL_PTP_RX_TSTAMP;
}
#else
--
2.9.5
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH] net/iavf: fix default state for Rx timestamp enabling
2022-10-12 2:53 [PATCH] net/iavf: fix default state for Rx timestamp enabling Simei Su
@ 2022-10-13 1:47 ` Simei Su
2022-10-13 6:14 ` Zhang, Qi Z
0 siblings, 1 reply; 3+ messages in thread
From: Simei Su @ 2022-10-13 1:47 UTC (permalink / raw)
To: qi.z.zhang, qiming.yang; +Cc: dev, wenjun1.wu, Simei Su, stable
This patch adds per queue offload check to turn off Rx timestamp
offload by default.
Fixes: b5cd735132f6 ("net/iavf: enable Rx timestamp on flex descriptor")
Cc: stable@dpdk.org
Signed-off-by: Simei Su <simei.su@intel.com>
v2:
* Refine commit log.
---
drivers/net/iavf/iavf_vchnl.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/iavf/iavf_vchnl.c b/drivers/net/iavf/iavf_vchnl.c
index 4327c5a..729400c 100644
--- a/drivers/net/iavf/iavf_vchnl.c
+++ b/drivers/net/iavf/iavf_vchnl.c
@@ -1070,7 +1070,8 @@ iavf_configure_queues(struct iavf_adapter *adapter,
}
if (vf->vf_res->vf_cap_flags & VIRTCHNL_VF_CAP_PTP &&
- vf->ptp_caps & VIRTCHNL_1588_PTP_CAP_RX_TSTAMP)
+ vf->ptp_caps & VIRTCHNL_1588_PTP_CAP_RX_TSTAMP &&
+ rxq[i]->offloads & RTE_ETH_RX_OFFLOAD_TIMESTAMP)
vc_qp->rxq.flags |= VIRTCHNL_PTP_RX_TSTAMP;
}
#else
--
2.9.5
^ permalink raw reply [flat|nested] 3+ messages in thread* RE: [PATCH] net/iavf: fix default state for Rx timestamp enabling
2022-10-13 1:47 ` Simei Su
@ 2022-10-13 6:14 ` Zhang, Qi Z
0 siblings, 0 replies; 3+ messages in thread
From: Zhang, Qi Z @ 2022-10-13 6:14 UTC (permalink / raw)
To: Su, Simei, Yang, Qiming; +Cc: dev, Wu, Wenjun1, stable
> -----Original Message-----
> From: Su, Simei <simei.su@intel.com>
> Sent: Thursday, October 13, 2022 9:48 AM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Yang, Qiming
> <qiming.yang@intel.com>
> Cc: dev@dpdk.org; Wu, Wenjun1 <wenjun1.wu@intel.com>; Su, Simei
> <simei.su@intel.com>; stable@dpdk.org
> Subject: [PATCH] net/iavf: fix default state for Rx timestamp enabling
>
> This patch adds per queue offload check to turn off Rx timestamp offload by
> default.
>
> Fixes: b5cd735132f6 ("net/iavf: enable Rx timestamp on flex descriptor")
> Cc: stable@dpdk.org
>
> Signed-off-by: Simei Su <simei.su@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-10-13 6:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-12 2:53 [PATCH] net/iavf: fix default state for Rx timestamp enabling Simei Su
2022-10-13 1:47 ` Simei Su
2022-10-13 6:14 ` Zhang, Qi Z
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).