From: Chengwen Feng <fengchengwen@huawei.com>
To: <thomas@monjalon.net>
Cc: <dev@dpdk.org>, <ciara.power@intel.com>
Subject: [PATCH v2] usertools: telemetry json support pretty print
Date: Fri, 14 Oct 2022 03:25:04 +0000 [thread overview]
Message-ID: <20221014032504.32534-1-fengchengwen@huawei.com> (raw)
In-Reply-To: <20221014023338.51464-1-fengchengwen@huawei.com>
Currently, the dpdk-telemetry.py show json in raw format, which is not
good for human reading.
E.g. The command '/ethdev/xstats,0' will output:
{"/ethdev/xstats": {"rx_good_packets": 0, "tx_good_packets": 0,
"rx_good_bytes": 0, "tx_good_bytes": 0, "rx_missed_errors": 0,
"rx_errors": 0, "tx_errors": 0, "rx_mbuf_allocation_errors": 0,
"rx_q0_packets": 0,...}}
This patch supports json pretty print by adding extra indent=4
parameter, so the same command will output:
{
"/ethdev/xstats": {
"rx_good_packets": 0,
"tx_good_packets": 0,
"rx_good_bytes": 0,
"tx_good_bytes": 0,
"rx_missed_errors": 0,
"rx_errors": 0,
"tx_errors": 0,
"rx_mbuf_allocation_errors": 0,
"rx_q0_packets": 0,
...
}
}
Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
---
v2: fix typo of output.
---
usertools/dpdk-telemetry.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/usertools/dpdk-telemetry.py b/usertools/dpdk-telemetry.py
index a81868a547..315f78fb8f 100755
--- a/usertools/dpdk-telemetry.py
+++ b/usertools/dpdk-telemetry.py
@@ -33,7 +33,7 @@ def read_socket(sock, buf_len, echo=True):
sock.close()
raise
if echo:
- print(json.dumps(ret))
+ print(json.dumps(ret, indent=4))
return ret
--
2.17.1
next prev parent reply other threads:[~2022-10-14 3:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-14 2:33 [PATCH] " Chengwen Feng
2022-10-14 3:25 ` Chengwen Feng [this message]
2022-10-14 9:50 ` [PATCH v2] " David Marchand
2022-10-14 12:44 ` Power, Ciara
2022-10-14 13:02 ` Bruce Richardson
2022-10-14 15:01 ` Stephen Hemminger
2022-10-14 15:29 ` Bruce Richardson
2022-10-14 16:10 ` Morten Brørup
2022-10-17 7:56 ` fengchengwen
2022-10-17 7:41 ` [PATCH v3] usertools: telemetry pretty print in interactive mode Chengwen Feng
2022-10-17 9:15 ` Bruce Richardson
2022-10-31 15:16 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221014032504.32534-1-fengchengwen@huawei.com \
--to=fengchengwen@huawei.com \
--cc=ciara.power@intel.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).