DPDK patches and discussions
 help / color / mirror / Atom feed
From: Markus Theil <markus.theil@tu-ilmenau.de>
To: dev@dpdk.org
Cc: Ferruh Yigit <ferruh.yigit@amd.com>,
	Markus Theil <markus.theil@tu-ilmenau.de>
Subject: [PATCH] doc: add deprecation notice for inconsistent socket_id types
Date: Fri, 14 Oct 2022 10:09:44 +0200	[thread overview]
Message-ID: <20221014080944.10992-1-markus.theil@tu-ilmenau.de> (raw)

DPDK uses many different types for socket_id's in its whole code
base. This leads to many warnings and casts in DPDK-based applications
compiled with -Wconversion.

Announce a treewide consolidation to the return type of rte_socket_id
in DPDK 23.11.

Signed-off-by: Markus Theil <markus.theil@tu-ilmenau.de>
---
 doc/guides/rel_notes/deprecation.rst | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 05cacb3ea8..7f4c468542 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -96,3 +96,10 @@ Deprecation Notices
   to have another parameter ``qp_id`` to return the queue pair ID
   which got error interrupt to the application,
   so that application can reset that particular queue pair.
+
+* eal/treewide: currently socket_id's use many different data types
+  throughout the codebase. This complicates compiling DPDK-based
+  applications with enabled -Wconversion. Fix this, by changing
+  all occurences to the return type of rte_socket_id().
+  DPDK 23.11 should receive a batch cleanup to a single, consistent
+  data type.
-- 
2.38.0


             reply	other threads:[~2022-10-14  8:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-14  8:09 Markus Theil [this message]
2022-10-14 10:43 ` Jerin Jacob
2023-07-16 17:34 ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221014080944.10992-1-markus.theil@tu-ilmenau.de \
    --to=markus.theil@tu-ilmenau.de \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).