From: Stephen Hemminger <stephen@networkplumber.org>
To: Arshdeep Kaur <arshdeep.kaur@intel.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH v1] dumpcap: fix select interface
Date: Fri, 14 Oct 2022 13:38:31 -0700 [thread overview]
Message-ID: <20221014133831.2777f778@hermes.local> (raw)
In-Reply-To: <20221014203325.32418-1-arshdeep.kaur@intel.com>
On Fri, 14 Oct 2022 13:33:25 -0700
Arshdeep Kaur <arshdeep.kaur@intel.com> wrote:
> The change to do argument process before EAL init broke
> the support of select-interface option. Fix by setting flag
> and doing select-interface later.
>
> Fixes: cbb44143be74 ("app/dumpcap: add new packet capture application")
>
> Signed-off-by: Arshdeep Kaur <arshdeep.kaur@intel.com>
The right fixes line would be when the order of init changed:
Fixes: a8dde09f97df ("app/dumpcap: allow help/version without primary process")
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
next prev parent reply other threads:[~2022-10-14 20:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-14 20:33 Arshdeep Kaur
2022-10-14 20:38 ` Stephen Hemminger [this message]
2022-10-14 20:48 ` [PATCH v2] " Arshdeep Kaur
2022-10-17 11:56 ` [PATCH v3] " Arshdeep Kaur
2022-10-17 12:07 ` [PATCH v4] " Arshdeep Kaur
2022-10-17 15:12 ` Stephen Hemminger
2022-10-21 13:01 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221014133831.2777f778@hermes.local \
--to=stephen@networkplumber.org \
--cc=arshdeep.kaur@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).