From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D3030A00C2; Fri, 14 Oct 2022 22:38:35 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C694C4280B; Fri, 14 Oct 2022 22:38:35 +0200 (CEST) Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) by mails.dpdk.org (Postfix) with ESMTP id 712E94003C for ; Fri, 14 Oct 2022 22:38:34 +0200 (CEST) Received: by mail-pg1-f172.google.com with SMTP id f193so5336065pgc.0 for ; Fri, 14 Oct 2022 13:38:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=9iJLl51m1nK/RuUJ7rjaSlCK1sxwlkkUzAMmyIblPmw=; b=4p/sEWLbx5XAYKOVS7nNcUVPzvZWtmQfes+nXS+zwTdpL8WhpkDSqmYT61gWpjp91M VfAcjvH2d1REF4L/AWFdTl4KfrFcK+HvMYUXZHN0Km+ojiUu7oMPAmba6h6r3vGo6Bmw Vf1i+vXcvYg+N6QufvlMNCIOxNRhYmUyKign7N4OtCl+wfnxjKX8Kh0BkHAwDAx4EI/N Gug6p9TkPVzDN6lu2ThbumhmKb9V0qhQeZqJ6wjKswNNgggGjbwcxJ2XRkrZW/yW0UVM Q0T6V3KtUbdjb0ygLQ8+3eTgJmNl0h2LaAgOrtYdj8A7Wf7pdteaBBAV4Ijg76YIEz4o pu8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9iJLl51m1nK/RuUJ7rjaSlCK1sxwlkkUzAMmyIblPmw=; b=CUaoLlFr1QTdhxgTAtpXuo3nS8AHd60ZmbMqFrOSrPb+li+WTW+zR6FxrOoFblRCyh dB6oqr+auZHfJ5435jnNnujbxHiW4fGafzbvR7TXYnHpiQ1ps2RODV2+edPkvwxnE2hD OcewYEnjYwx3jkdUnRHyDW68QkyeH4z6U0WQ7hAR0EruSkOPO7/QttKEyBEsAmDHWJVF Pww0n0MsGOm1JehHS4UQjOIAhCXVJ4QbnXqqoXCl9SM7R6oYZEZqu3zNnOWTVMVC116b +DZrpp6jAgc+7JQvbjfcRigflWAclcPKfONUkzu7qNJjRYOSmIZyBInDXthlCNRa8qWV 7rTg== X-Gm-Message-State: ACrzQf28s7dCOYJ7iSzKjToN7YL1D6n6/a7027Ij8eava16Ugwv8cmFW 4gAIVou/CcbYrCpQ9bp2ybh0ls0tf6wsog== X-Google-Smtp-Source: AMsMyM7t1J0ytIastVOJJIjGXb2J7zaaIDbBdMpa9vmStMtKTKDycNgwH1vmZh9EWQcTszpCxW8lkw== X-Received: by 2002:a63:1f13:0:b0:455:80ce:6d36 with SMTP id f19-20020a631f13000000b0045580ce6d36mr6248398pgf.111.1665779913653; Fri, 14 Oct 2022 13:38:33 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id y68-20020a626447000000b005624b4bd738sm2112173pfb.156.2022.10.14.13.38.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Oct 2022 13:38:33 -0700 (PDT) Date: Fri, 14 Oct 2022 13:38:31 -0700 From: Stephen Hemminger To: Arshdeep Kaur Cc: dev@dpdk.org Subject: Re: [PATCH v1] dumpcap: fix select interface Message-ID: <20221014133831.2777f778@hermes.local> In-Reply-To: <20221014203325.32418-1-arshdeep.kaur@intel.com> References: <20221014203325.32418-1-arshdeep.kaur@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 14 Oct 2022 13:33:25 -0700 Arshdeep Kaur wrote: > The change to do argument process before EAL init broke > the support of select-interface option. Fix by setting flag > and doing select-interface later. > > Fixes: cbb44143be74 ("app/dumpcap: add new packet capture application") > > Signed-off-by: Arshdeep Kaur The right fixes line would be when the order of init changed: Fixes: a8dde09f97df ("app/dumpcap: allow help/version without primary process") Acked-by: Stephen Hemminger