From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0C3C7A0556; Mon, 17 Oct 2022 11:11:39 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EBEF14021D; Mon, 17 Oct 2022 11:11:38 +0200 (CEST) Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by mails.dpdk.org (Postfix) with ESMTP id 37CFA40143 for ; Mon, 17 Oct 2022 11:11:37 +0200 (CEST) Received: from dggpeml500024.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4MrWMd6jT7zmVFh; Mon, 17 Oct 2022 17:06:53 +0800 (CST) Received: from localhost.localdomain (10.67.165.24) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 17 Oct 2022 17:11:35 +0800 From: Chengwen Feng To: , CC: , , Subject: [PATCH] app/testpmd: remove jumbo offload related code Date: Mon, 17 Oct 2022 09:05:50 +0000 Message-ID: <20221017090550.4188-1-fengchengwen@huawei.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.67.165.24] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpeml500024.china.huawei.com (7.185.36.10) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The jumbo offload was removed from patch [1], but testpmd still exist jumbo offload related code, this patch removes it, and also updates the rst file. [1] ethdev: remove jumbo offload flag Fixes: b563c1421282 ("ethdev: remove jumbo offload flag") Cc: stable@dpdk.org Signed-off-by: Chengwen Feng --- app/test-pmd/cmdline.c | 12 ++++++------ app/test-pmd/testpmd.h | 1 - doc/guides/testpmd_app_ug/testpmd_funcs.rst | 8 ++++---- 3 files changed, 10 insertions(+), 11 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 17be2de402..0667869a4d 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -714,7 +714,7 @@ static void cmd_help_long_parsed(void *parsed_result, "port config rx_offload vlan_strip|" "ipv4_cksum|udp_cksum|tcp_cksum|tcp_lro|qinq_strip|" "outer_ipv4_cksum|macsec_strip|" - "vlan_filter|vlan_extend|jumbo_frame|scatter|" + "vlan_filter|vlan_extend|scatter|" "buffer_split|timestamp|security|keep_crc on|off\n" " Enable or disable a per port Rx offloading" " on all Rx queues of a port\n\n" @@ -722,7 +722,7 @@ static void cmd_help_long_parsed(void *parsed_result, "port (port_id) rxq (queue_id) rx_offload vlan_strip|" "ipv4_cksum|udp_cksum|tcp_cksum|tcp_lro|qinq_strip|" "outer_ipv4_cksum|macsec_strip|" - "vlan_filter|vlan_extend|jumbo_frame|scatter|" + "vlan_filter|vlan_extend|scatter|" "buffer_split|timestamp|security|keep_crc on|off\n" " Enable or disable a per queue Rx offloading" " only on a specific Rx queue\n\n" @@ -10960,7 +10960,7 @@ static cmdline_parse_token_string_t cmd_config_per_port_rx_offload_result_offloa (struct cmd_config_per_port_rx_offload_result, offload, "vlan_strip#ipv4_cksum#udp_cksum#tcp_cksum#tcp_lro#" "qinq_strip#outer_ipv4_cksum#macsec_strip#" - "vlan_filter#vlan_extend#jumbo_frame#" + "vlan_filter#vlan_extend#" "scatter#buffer_split#timestamp#security#" "keep_crc#rss_hash"); static cmdline_parse_token_string_t cmd_config_per_port_rx_offload_result_on_off = @@ -11043,7 +11043,7 @@ static cmdline_parse_inst_t cmd_config_per_port_rx_offload = { .help_str = "port config rx_offload vlan_strip|ipv4_cksum|" "udp_cksum|tcp_cksum|tcp_lro|qinq_strip|outer_ipv4_cksum|" "macsec_strip|vlan_filter|vlan_extend|" - "jumbo_frame|scatter|buffer_split|timestamp|security|" + "scatter|buffer_split|timestamp|security|" "keep_crc|rss_hash on|off", .tokens = { (void *)&cmd_config_per_port_rx_offload_result_port, @@ -11092,7 +11092,7 @@ static cmdline_parse_token_string_t cmd_config_per_queue_rx_offload_result_offlo (struct cmd_config_per_queue_rx_offload_result, offload, "vlan_strip#ipv4_cksum#udp_cksum#tcp_cksum#tcp_lro#" "qinq_strip#outer_ipv4_cksum#macsec_strip#" - "vlan_filter#vlan_extend#jumbo_frame#" + "vlan_filter#vlan_extend#" "scatter#buffer_split#timestamp#security#keep_crc"); static cmdline_parse_token_string_t cmd_config_per_queue_rx_offload_result_on_off = TOKEN_STRING_INITIALIZER @@ -11151,7 +11151,7 @@ static cmdline_parse_inst_t cmd_config_per_queue_rx_offload = { "vlan_strip|ipv4_cksum|" "udp_cksum|tcp_cksum|tcp_lro|qinq_strip|outer_ipv4_cksum|" "macsec_strip|vlan_filter|vlan_extend|" - "jumbo_frame|scatter|buffer_split|timestamp|security|" + "scatter|buffer_split|timestamp|security|" "keep_crc on|off", .tokens = { (void *)&cmd_config_per_queue_rx_offload_result_port, diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h index e65be323b8..a9dbefd69b 100644 --- a/app/test-pmd/testpmd.h +++ b/app/test-pmd/testpmd.h @@ -1150,7 +1150,6 @@ uint16_t tx_pkt_set_dynf(uint16_t port_id, __rte_unused uint16_t queue, void add_tx_dynf_callback(portid_t portid); void remove_tx_dynf_callback(portid_t portid); int update_mtu_from_frame_size(portid_t portid, uint32_t max_rx_pktlen); -int update_jumbo_frame_offload(portid_t portid); void flex_item_create(portid_t port_id, uint16_t flex_id, const char *filename); void flex_item_destroy(portid_t port_id, uint16_t flex_id); void port_flex_item_flush(portid_t port_id); diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst index b3f31df69a..d0fe73dff6 100644 --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst @@ -1553,8 +1553,8 @@ Enable or disable a per port Rx offloading on all Rx queues of a port:: * ``offloading``: can be any of these offloading capability: vlan_strip, ipv4_cksum, udp_cksum, tcp_cksum, tcp_lro, qinq_strip, outer_ipv4_cksum, macsec_strip, - vlan_filter, vlan_extend, jumbo_frame, - scatter, timestamp, security, keep_crc, rss_hash + vlan_filter, vlan_extend, scatter, timestamp, security, + keep_crc, rss_hash This command should be run when the port is stopped, or else it will fail. @@ -1568,8 +1568,8 @@ Enable or disable a per queue Rx offloading only on a specific Rx queue:: * ``offloading``: can be any of these offloading capability: vlan_strip, ipv4_cksum, udp_cksum, tcp_cksum, tcp_lro, qinq_strip, outer_ipv4_cksum, macsec_strip, - vlan_filter, vlan_extend, jumbo_frame, - scatter, timestamp, security, keep_crc + vlan_filter, vlan_extend, scatter, timestamp, security, + keep_crc This command should be run when the port is stopped, or else it will fail. -- 2.17.1