* [PATCH 1/3] eal: remove experimental from rte_epoll_wait_interruptible
2022-10-18 1:57 [PATCH 0/3] remove more experimental tags Stephen Hemminger
@ 2022-10-18 1:57 ` Stephen Hemminger
2022-10-18 1:57 ` [PATCH 2/3] eal: make rte_log_list_types not experimental Stephen Hemminger
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Stephen Hemminger @ 2022-10-18 1:57 UTC (permalink / raw)
To: dev; +Cc: Stephen Hemminger, Harman Kalra
This call was added in 20.11, so time to make it not experimental.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
lib/eal/include/rte_epoll.h | 1 -
lib/eal/version.map | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/lib/eal/include/rte_epoll.h b/lib/eal/include/rte_epoll.h
index 56b7b6bad694..8c73031910fe 100644
--- a/lib/eal/include/rte_epoll.h
+++ b/lib/eal/include/rte_epoll.h
@@ -85,7 +85,6 @@ rte_epoll_wait(int epfd, struct rte_epoll_event *events,
* - On success, returns the number of available event.
* - On failure, a negative value.
*/
-__rte_experimental
int
rte_epoll_wait_interruptible(int epfd, struct rte_epoll_event *events,
int maxevents, int timeout);
diff --git a/lib/eal/version.map b/lib/eal/version.map
index 2d64a2592e36..3455388cc8c8 100644
--- a/lib/eal/version.map
+++ b/lib/eal/version.map
@@ -76,6 +76,7 @@ DPDK_23 {
rte_eal_wait_lcore;
rte_epoll_ctl;
rte_epoll_wait;
+ rte_epoll_wait_interruptible;
rte_exit;
rte_extmem_attach;
rte_extmem_detach;
@@ -387,7 +388,6 @@ EXPERIMENTAL {
# added in 20.11
__rte_eal_trace_generic_size_t; # WINDOWS_NO_EXPORT
rte_cpu_get_intrinsics_support; # WINDOWS_NO_EXPORT
- rte_epoll_wait_interruptible;
rte_service_lcore_may_be_active;
rte_vect_get_max_simd_bitwidth;
rte_vect_set_max_simd_bitwidth;
--
2.35.1
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH 2/3] eal: make rte_log_list_types not experimental
2022-10-18 1:57 [PATCH 0/3] remove more experimental tags Stephen Hemminger
2022-10-18 1:57 ` [PATCH 1/3] eal: remove experimental from rte_epoll_wait_interruptible Stephen Hemminger
@ 2022-10-18 1:57 ` Stephen Hemminger
2022-10-18 1:57 ` [PATCH 3/3] rwlock: make trylock operations no longer experimental Stephen Hemminger
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Stephen Hemminger @ 2022-10-18 1:57 UTC (permalink / raw)
To: dev; +Cc: Stephen Hemminger
This call was added in 21.05 so time to make it stable.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
lib/eal/include/rte_log.h | 4 ----
lib/eal/version.map | 2 +-
2 files changed, 1 insertion(+), 5 deletions(-)
diff --git a/lib/eal/include/rte_log.h b/lib/eal/include/rte_log.h
index 25ce42cdfc4d..bba5da3d85dc 100644
--- a/lib/eal/include/rte_log.h
+++ b/lib/eal/include/rte_log.h
@@ -235,9 +235,6 @@ int rte_log_register(const char *name);
int rte_log_register_type_and_pick_level(const char *name, uint32_t level_def);
/**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
* Dump name of each logtype, one per line.
*
* @param out
@@ -245,7 +242,6 @@ int rte_log_register_type_and_pick_level(const char *name, uint32_t level_def);
* @param prefix
* String preceding each logtype in the output.
*/
-__rte_experimental
void rte_log_list_types(FILE *out, const char *prefix);
/**
diff --git a/lib/eal/version.map b/lib/eal/version.map
index 3455388cc8c8..7ad12a7dc985 100644
--- a/lib/eal/version.map
+++ b/lib/eal/version.map
@@ -148,6 +148,7 @@ DPDK_23 {
rte_log_get_global_level;
rte_log_get_level;
rte_log_get_stream;
+ rte_log_list_types;
rte_log_register;
rte_log_register_type_and_pick_level;
rte_log_set_global_level;
@@ -400,7 +401,6 @@ EXPERIMENTAL {
# added in 21.05
rte_devargs_reset;
rte_intr_callback_unregister_sync;
- rte_log_list_types;
rte_thread_key_create;
rte_thread_key_delete;
rte_thread_value_get;
--
2.35.1
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH 3/3] rwlock: make trylock operations no longer experimental
2022-10-18 1:57 [PATCH 0/3] remove more experimental tags Stephen Hemminger
2022-10-18 1:57 ` [PATCH 1/3] eal: remove experimental from rte_epoll_wait_interruptible Stephen Hemminger
2022-10-18 1:57 ` [PATCH 2/3] eal: make rte_log_list_types not experimental Stephen Hemminger
@ 2022-10-18 1:57 ` Stephen Hemminger
2022-10-18 14:15 ` [PATCH 0/3] remove more experimental tags David Marchand
2022-10-27 11:16 ` David Marchand
4 siblings, 0 replies; 6+ messages in thread
From: Stephen Hemminger @ 2022-10-18 1:57 UTC (permalink / raw)
To: dev; +Cc: Stephen Hemminger
These have been in for since 19.02, time to take off the
experimental tag.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
lib/eal/include/generic/rte_rwlock.h | 12 ++----------
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/lib/eal/include/generic/rte_rwlock.h b/lib/eal/include/generic/rte_rwlock.h
index 90f77dfe23b0..233d4262bede 100644
--- a/lib/eal/include/generic/rte_rwlock.h
+++ b/lib/eal/include/generic/rte_rwlock.h
@@ -108,10 +108,7 @@ rte_rwlock_read_lock(rte_rwlock_t *rwl)
}
/**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice.
- *
- * try to take a read lock.
+ * Try to take a read lock.
*
* @param rwl
* A pointer to a rwlock structure.
@@ -120,7 +117,6 @@ rte_rwlock_read_lock(rte_rwlock_t *rwl)
* - -EBUSY if lock could not be acquired for reading because a
* writer holds the lock
*/
-__rte_experimental
static inline int
rte_rwlock_read_trylock(rte_rwlock_t *rwl)
{
@@ -159,10 +155,7 @@ rte_rwlock_read_unlock(rte_rwlock_t *rwl)
}
/**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice.
- *
- * try to take a write lock.
+ * Try to take a write lock.
*
* @param rwl
* A pointer to a rwlock structure.
@@ -171,7 +164,6 @@ rte_rwlock_read_unlock(rte_rwlock_t *rwl)
* - -EBUSY if lock could not be acquired for writing because
* it was already locked for reading or writing
*/
-__rte_experimental
static inline int
rte_rwlock_write_trylock(rte_rwlock_t *rwl)
{
--
2.35.1
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 0/3] remove more experimental tags
2022-10-18 1:57 [PATCH 0/3] remove more experimental tags Stephen Hemminger
` (2 preceding siblings ...)
2022-10-18 1:57 ` [PATCH 3/3] rwlock: make trylock operations no longer experimental Stephen Hemminger
@ 2022-10-18 14:15 ` David Marchand
2022-10-27 11:16 ` David Marchand
4 siblings, 0 replies; 6+ messages in thread
From: David Marchand @ 2022-10-18 14:15 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: dev
On Tue, Oct 18, 2022 at 3:58 AM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> Remove some of the older experimental tags for 22.11
>
> Stephen Hemminger (3):
> eal: remove experimental from rte_epoll_wait_interruptible
> eal: make rte_log_list_types not experimental
> rwlock: make trylock operations no longer experimental
>
> lib/eal/include/generic/rte_rwlock.h | 12 ++----------
> lib/eal/include/rte_epoll.h | 1 -
> lib/eal/include/rte_log.h | 4 ----
> lib/eal/version.map | 4 ++--
> 4 files changed, 4 insertions(+), 17 deletions(-)
Patch 1 (resp. 2) removes the last remaining experimental function
declared in rte_epoll.h (resp. rte_log.h).
We can drop #include <rte_compat.h> in this header.
For the series,
Reviewed-by: David Marchand <david.marchand@redhat.com>
--
David Marchand
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 0/3] remove more experimental tags
2022-10-18 1:57 [PATCH 0/3] remove more experimental tags Stephen Hemminger
` (3 preceding siblings ...)
2022-10-18 14:15 ` [PATCH 0/3] remove more experimental tags David Marchand
@ 2022-10-27 11:16 ` David Marchand
4 siblings, 0 replies; 6+ messages in thread
From: David Marchand @ 2022-10-27 11:16 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: dev
On Tue, Oct 18, 2022 at 3:58 AM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> Remove some of the older experimental tags for 22.11
>
> Stephen Hemminger (3):
> eal: remove experimental from rte_epoll_wait_interruptible
> eal: make rte_log_list_types not experimental
> rwlock: make trylock operations no longer experimental
>
> lib/eal/include/generic/rte_rwlock.h | 12 ++----------
> lib/eal/include/rte_epoll.h | 1 -
> lib/eal/include/rte_log.h | 4 ----
> lib/eal/version.map | 4 ++--
> 4 files changed, 4 insertions(+), 17 deletions(-)
Series applied.
I added to my todolist that we need a cleanup for unneeded inclusion
of rte_compat.h (the headers touched in this series are not the only
one concerned).
--
David Marchand
^ permalink raw reply [flat|nested] 6+ messages in thread